File tree Expand file tree Collapse file tree 2 files changed +6
-17
lines changed Expand file tree Collapse file tree 2 files changed +6
-17
lines changed Original file line number Diff line number Diff line change @@ -46,22 +46,13 @@ class SessionsSettings: SettingsProtocol {
46
46
}
47
47
48
48
var sessionsEnabled : Bool {
49
- // TODO: Remove this block before release
50
- // Disabling the SDK because some customers seem to be building from master
51
- // Uncomment the code below before release
49
+ // Order of precendence LocalOverrides > Remote Settings > SDK Defaults
52
50
if let sessionEnabled = localOverrides. sessionsEnabled {
53
51
return sessionEnabled
52
+ } else if let sessionEnabled = remoteSettings. sessionsEnabled {
53
+ return sessionEnabled
54
54
}
55
- return false
56
-
57
- // TODO: uncomment before release
58
- // // Order of precendence LocalOverrides > Remote Settings > SDK Defaults
59
- // if let sessionEnabled = localOverrides.sessionsEnabled {
60
- // return sessionEnabled
61
- // } else if let sessionEnabled = remoteSettings.sessionsEnabled {
62
- // return sessionEnabled
63
- // }
64
- // return sdkDefaults.sessionsEnabled!
55
+ return sdkDefaults. sessionsEnabled!
65
56
}
66
57
67
58
var sessionTimeout : TimeInterval {
Original file line number Diff line number Diff line change @@ -82,8 +82,7 @@ class SessionsSettingsTests: XCTestCase {
82
82
remoteSettings: remoteSettings
83
83
)
84
84
85
- // TODO: uncomment before release
86
- // XCTAssertTrue(sessionSettings.sessionsEnabled)
85
+ XCTAssertTrue ( sessionSettings. sessionsEnabled)
87
86
XCTAssertEqual ( sessionSettings. samplingRate, 1.0 )
88
87
XCTAssertEqual ( sessionSettings. sessionTimeout, 30 * 60 )
89
88
}
@@ -110,8 +109,7 @@ class SessionsSettingsTests: XCTestCase {
110
109
remoteSettings: remoteSettings
111
110
)
112
111
113
- // TODO: uncomment before release
114
- // XCTAssertTrue(sessionSettings.sessionsEnabled)
112
+ XCTAssertTrue ( sessionSettings. sessionsEnabled)
115
113
XCTAssertEqual ( sessionSettings. samplingRate, 0.8 )
116
114
XCTAssertEqual ( sessionSettings. sessionTimeout, 50 )
117
115
}
You can’t perform that action at this time.
0 commit comments