From cddeb7365bcbda8ed90576c9f4e6d6013494572e Mon Sep 17 00:00:00 2001 From: Seyed Mojtaba Hosseini Zeidabadi Date: Tue, 1 Oct 2024 11:59:53 +0330 Subject: [PATCH 1/2] docs: fix typos in comments --- FirebaseCore/Tests/Unit/FIRAppTest.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/FirebaseCore/Tests/Unit/FIRAppTest.m b/FirebaseCore/Tests/Unit/FIRAppTest.m index b231e608b92..9e29919087f 100644 --- a/FirebaseCore/Tests/Unit/FIRAppTest.m +++ b/FirebaseCore/Tests/Unit/FIRAppTest.m @@ -115,7 +115,7 @@ + (void)tearDown { // We stop mocking `FIRHeartbeatLogger` in the class `tearDown` method to // prevent interfering with other tests that use the real `FIRHeartbeatLogger`. // Doing this in the instance `tearDown` causes test failures due to a race - // condition between `NSNoticationCenter` and `OCMVerifyAllWithDelay`. + // condition between `NSNotificationCenter` and `OCMVerifyAllWithDelay`. // Affected tests: // - testHeartbeatLogIsAttemptedWhenAppDidBecomeActive [OCMClassMock([FIRHeartbeatLogger class]) stopMocking]; @@ -301,7 +301,7 @@ - (void)testConfigureDefaultAppInExtension { XCTAssertThrows([FIRApp configureWithOptions:differentOptions]); XCTAssertEqual([FIRApp allApps].count, 1); - // Explicily stop the environmentMock. + // Explicitly stop the environmentMock. [environmentMock stopMocking]; environmentMock = nil; } @@ -330,7 +330,7 @@ - (void)testConfigureCustomAppInExtension { XCTAssertThrows([FIRApp configureWithName:kFIRTestAppName1 options:differentOptions]); XCTAssertEqual([FIRApp allApps].count, 1); - // Explicily stop the environmentMock. + // Explicitly stop the environmentMock. [environmentMock stopMocking]; environmentMock = nil; } From 2dd42f18646102d9b19841751cfd11058b454935 Mon Sep 17 00:00:00 2001 From: Seyed Mojtaba Hosseini Zeidabadi Date: Tue, 1 Oct 2024 12:00:07 +0330 Subject: [PATCH 2/2] fix: a typo in a method name --- FirebaseCore/Tests/Unit/FIRAppTest.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FirebaseCore/Tests/Unit/FIRAppTest.m b/FirebaseCore/Tests/Unit/FIRAppTest.m index 9e29919087f..ea4107a371c 100644 --- a/FirebaseCore/Tests/Unit/FIRAppTest.m +++ b/FirebaseCore/Tests/Unit/FIRAppTest.m @@ -601,7 +601,7 @@ - (void)testAppIDContainsInvalidBundleIDHash { // Uncomment if you need to measure performance of [FIRApp validateAppID:]. // It is commented because measures are heavily dependent on a build agent configuration, // so it cannot produce reliable resault on CI -//- (void)testAppIDValidationPerfomance { +//- (void)testAppIDValidationPerformance { // [self measureBlock:^{ // for (NSInteger i = 0; i < 100; ++i) { // [self testAppIDPrefix];