Skip to content

Fix FirebaseCore tests comments #13777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix FirebaseCore tests comments #13777

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cddeb73
docs: fix typos in comments
MojtabaHs Oct 1, 2024
2dd42f1
fix: a typo in a method name
MojtabaHs Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions FirebaseCore/Tests/Unit/FIRAppTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ + (void)tearDown {
// We stop mocking `FIRHeartbeatLogger` in the class `tearDown` method to
// prevent interfering with other tests that use the real `FIRHeartbeatLogger`.
// Doing this in the instance `tearDown` causes test failures due to a race
// condition between `NSNoticationCenter` and `OCMVerifyAllWithDelay`.
// condition between `NSNotificationCenter` and `OCMVerifyAllWithDelay`.
// Affected tests:
// - testHeartbeatLogIsAttemptedWhenAppDidBecomeActive
[OCMClassMock([FIRHeartbeatLogger class]) stopMocking];
Expand Down Expand Up @@ -301,7 +301,7 @@ - (void)testConfigureDefaultAppInExtension {
XCTAssertThrows([FIRApp configureWithOptions:differentOptions]);
XCTAssertEqual([FIRApp allApps].count, 1);

// Explicily stop the environmentMock.
// Explicitly stop the environmentMock.
[environmentMock stopMocking];
environmentMock = nil;
}
Expand Down Expand Up @@ -330,7 +330,7 @@ - (void)testConfigureCustomAppInExtension {
XCTAssertThrows([FIRApp configureWithName:kFIRTestAppName1 options:differentOptions]);
XCTAssertEqual([FIRApp allApps].count, 1);

// Explicily stop the environmentMock.
// Explicitly stop the environmentMock.
[environmentMock stopMocking];
environmentMock = nil;
}
Expand Down Expand Up @@ -601,7 +601,7 @@ - (void)testAppIDContainsInvalidBundleIDHash {
// Uncomment if you need to measure performance of [FIRApp validateAppID:].
// It is commented because measures are heavily dependent on a build agent configuration,
// so it cannot produce reliable resault on CI
//- (void)testAppIDValidationPerfomance {
//- (void)testAppIDValidationPerformance {
// [self measureBlock:^{
// for (NSInteger i = 0; i < 100; ++i) {
// [self testAppIDPrefix];
Expand Down
Loading