Skip to content

Fix FirebaseDatabase integration test files content #13781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix FirebaseDatabase integration test files content #13781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8bd5dc
fix: a typo in a property name
MojtabaHs Oct 1, 2024
3b1603f
fix: a typo in a property name
MojtabaHs Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FirebaseDatabase/Tests/Integration/FData.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,10 +1190,10 @@ - (void)testEffectsOfSetPriorityIsImmediatelyEvident {
}];

NSArray *expectedValues = @[ @5, @5 ];
NSArray *expectedPriorites = @[ [NSNull null], @10 ];
NSArray *expectedPriorities = @[ [NSNull null], @10 ];
XCTAssertTrue([values isEqualToArray:expectedValues],
@"Expected both listeners to get 5, got %@ instead", values);
XCTAssertTrue([priorities isEqualToArray:expectedPriorites],
XCTAssertTrue([priorities isEqualToArray:expectedPriorities],
@"The first listener should have missed the priority, got %@ instead", priorities);
}

Expand Down
4 changes: 2 additions & 2 deletions FirebaseDatabase/Tests/Integration/FTransactionTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,14 +720,14 @@ - (void)testUpdateShouldNotCancelUnrelatedTransactions {
barTransactionDone = YES;
}];

NSDictionary *udpateData = @{
NSDictionary *updateData = @{
@"foo" : @"newValue",
@"boo" : @"newValue",
@"doo/foo" : @"newValue",
@"loo" : @{@"doo" : @{@"boo" : @"newValue"}}
};

[self waitForCompletionOf:ref updateChildValues:udpateData];
[self waitForCompletionOf:ref updateChildValues:updateData];
XCTAssertTrue(fooTransactionDone, "Should have gotten cancelled before the update");
XCTAssertFalse(barTransactionDone, "Should run after the update");
[ref.repo setHijackHash:NO];
Expand Down
Loading