Skip to content

Fix a method name in FirebaseInAppMessaging #13789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix a method name in FirebaseInAppMessaging #13789

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79a442a
fix: a typo in a method name
MojtabaHs Oct 1, 2024
8c13aab
style: satisfy the lint
MojtabaHs Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions FirebaseInAppMessaging/Sources/Flows/FIRIAMFetchFlow.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ - (void)sendFetchIsDoneNotification {
object:self];
}

- (void)handleSuccessullyFetchedMessages:(NSArray<FIRIAMMessageDefinition *> *)messagesInResponse
withFetchWaitTime:(NSNumber *_Nullable)fetchWaitTime
requestImpressions:(NSArray<FIRIAMImpressionRecord *> *)requestImpressions {
- (void)handleSuccessfullyFetchedMessages:(NSArray<FIRIAMMessageDefinition *> *)messagesInResponse
withFetchWaitTime:(NSNumber *_Nullable)fetchWaitTime
requestImpressions:(NSArray<FIRIAMImpressionRecord *> *)requestImpressions {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM700004", @"%lu messages were fetched successfully.",
(unsigned long)messagesInResponse.count);

Expand Down Expand Up @@ -233,9 +233,9 @@ - (void)checkAndFetchForInitialAppLaunch:(BOOL)forInitialAppLaunch {
[self.activityLogger addLogRecord:record];

// Now handle the fetched messages.
[self handleSuccessullyFetchedMessages:messages
withFetchWaitTime:nextFetchWaitTime
requestImpressions:impressions];
[self handleSuccessfullyFetchedMessages:messages
withFetchWaitTime:nextFetchWaitTime
requestImpressions:impressions];

if (forInitialAppLaunch) {
[self checkForAppLaunchMessage];
Expand Down
Loading