Skip to content

[Config] Port ConfigContentTest.swift #14370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rc-swift
Choose a base branch
from
+597 −4
Open

[Config] Port ConfigContentTest.swift #14370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions FirebaseRemoteConfig/SwiftNew/ConfigContent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,18 @@ class ConfigContent: NSObject {
@objc public
static let sharedInstance = ConfigContent(dbManager: ConfigDBManager.sharedInstance)

/// Designated initializer
// TODO(ncooke3): Remove when ObjC usage goes away.
/// Convenience initializer
@objc(initWithDBManager:) public
init(dbManager: ConfigDBManager) {
convenience init(dbManager: ConfigDBManager) {
self.init(dbManager: dbManager, bundleIdentifier: Bundle.main.bundleIdentifier)
}

/// Designated initializer
public init(dbManager: ConfigDBManager, bundleIdentifier: String?) {
self.dbManager = dbManager
bundleIdentifier = Bundle.main.bundleIdentifier ?? ""
if bundleIdentifier.isEmpty {
self.bundleIdentifier = bundleIdentifier ?? ""
if self.bundleIdentifier.isEmpty {
RCLog.notice("I-RCN000038",
"Main bundle identifier is missing. Remote Config might not work properly.")
}
Expand Down
Loading
Loading