From 24129877d45a204deaa36ef31ff0caf3ac2deaeb Mon Sep 17 00:00:00 2001 From: rizafran Date: Tue, 8 Apr 2025 00:55:14 +0800 Subject: [PATCH 1/3] Changed actionCodeOperation types --- .../Sources/Swift/ActionCode/ActionCodeInfo.swift | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/FirebaseAuth/Sources/Swift/ActionCode/ActionCodeInfo.swift b/FirebaseAuth/Sources/Swift/ActionCode/ActionCodeInfo.swift index ee249699808..3cfa35909f6 100644 --- a/FirebaseAuth/Sources/Swift/ActionCode/ActionCodeInfo.swift +++ b/FirebaseAuth/Sources/Swift/ActionCode/ActionCodeInfo.swift @@ -42,12 +42,12 @@ import Foundation /// - Returns: The corresponding ActionCodeOperation for the supplied request type. class func actionCodeOperation(forRequestType requestType: String?) -> ActionCodeOperation { switch requestType { - case "PASSWORD_RESET": return .passwordReset - case "VERIFY_EMAIL": return .verifyEmail - case "RECOVER_EMAIL": return .recoverEmail - case "EMAIL_SIGNIN": return .emailLink - case "VERIFY_AND_CHANGE_EMAIL": return .verifyAndChangeEmail - case "REVERT_SECOND_FACTOR_ADDITION": return .revertSecondFactorAddition + case "resetPassword": return .passwordReset + case "verifyEmail": return .verifyEmail + case "recoverEmail": return .recoverEmail + case "signIn": return .emailLink + case "verifyAndChangeEmail": return .verifyAndChangeEmail + case "revertSecondFactorAddition": return .revertSecondFactorAddition default: return .unknown } } From 1ce68ca4ae89cef6870cea6f7112c023ef9b7ed9 Mon Sep 17 00:00:00 2001 From: rizafran Date: Tue, 8 Apr 2025 19:38:49 +0800 Subject: [PATCH 2/3] Changed requestType from VERIFY_EMAIL to verifyEmail --- FirebaseAuth/Tests/Unit/AuthTests.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FirebaseAuth/Tests/Unit/AuthTests.swift b/FirebaseAuth/Tests/Unit/AuthTests.swift index fe7be777cc9..dc39e1448cb 100644 --- a/FirebaseAuth/Tests/Unit/AuthTests.swift +++ b/FirebaseAuth/Tests/Unit/AuthTests.swift @@ -538,7 +538,7 @@ class AuthTests: RPCBaseTests { */ func testCheckActionCodeSuccess() throws { let kNewEmail = "newEmail@example.com" - let verifyEmailRequestType = "VERIFY_EMAIL" + let verifyEmailRequestType = "verifyEmail" let expectation = self.expectation(description: #function) // 1. Setup respond block to test and fake send request. From 27a78349c5865037a3cc9d5585d20ed6b77fcf8a Mon Sep 17 00:00:00 2001 From: rizafran Date: Wed, 9 Apr 2025 22:15:41 +0800 Subject: [PATCH 3/3] Updated changelog --- FirebaseAuth/CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/FirebaseAuth/CHANGELOG.md b/FirebaseAuth/CHANGELOG.md index 01349d8f334..72fa2cad2d6 100644 --- a/FirebaseAuth/CHANGELOG.md +++ b/FirebaseAuth/CHANGELOG.md @@ -1,3 +1,6 @@ +# Unreleased +- [fixed] Fix the parameters for requestType in ActionCodeOperation. (#14665) + # 11.9.0 - [changed] Using reCAPTCHA Enterprise and Firebase Auth requires reCAPTCHA Enterprise 18.7.0 or later.