From 5f533f60cf734bf49b8497f607aaf8fb15029b11 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Fri, 30 May 2025 10:56:17 -0400 Subject: [PATCH 1/6] [Infra] Migrate firestore.yml to use reusable workflow jobs --- .github/workflows/firestore.yml | 62 +++++++++------------------------ 1 file changed, 17 insertions(+), 45 deletions(-) diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index 6282b0511d5..a029ba23630 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -83,6 +83,10 @@ jobs: # This workflow - '.github/workflows/firestore.yml' + # Workflows this one depends on. + - '.github/workflows/common.yml' + - '.github/workflows/common_cocoapods.yml' + # Rebuild on Ruby infrastructure changes. - 'Gemfile*' @@ -379,37 +383,17 @@ jobs: export EXPERIMENTAL_MODE=true scripts/third_party/travis/retry.sh scripts/build.sh Firestore ${{ matrix.target }} xcodebuild - - pod-lib-lint: + pod_lib_lint: needs: check - # Either a scheduled run from public repo, or a pull request with firestore changes. - if: | - (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || - (github.event_name == 'pull_request') - runs-on: macos-15 strategy: matrix: - podspec: [ - 'FirebaseFirestoreInternal.podspec', - 'FirebaseFirestore.podspec', - ] - - steps: - - uses: actions/checkout@v4 - - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Setup Bundler - run: ./scripts/setup_bundler.sh - - name: Xcode - run: sudo xcode-select -s /Applications/Xcode_16.3.app/Contents/Developer - - - name: Pod lib lint - # TODO(#9565, b/227461966): Remove --no-analyze when absl is fixed. - run: | - scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb ${{ matrix.podspec }} \ - --platforms=ios \ - --allow-warnings \ - --no-analyze + product: ['FirebaseFirestoreInternal', 'FirebaseFirestore'] + uses: ./.github/workflows/common_cocoapods.yml + with: + product: FirebaseFunctions + platforms: iOS + allow_warnings: true + # --no-analyze # TODO(#9565, b/227461966): Remove --no-analyze when absl is fixed. # `pod lib lint` takes a long time so only run the other platforms and static frameworks build in the cron. pod-lib-lint-cron: @@ -524,23 +508,11 @@ jobs: run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestore ${{ matrix.target }} spmbuildonly spm-binary: - needs: check - # Either a scheduled run from public repo, or a pull request with firestore changes. - if: | - (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || - (github.event_name == 'pull_request' && needs.changes.outputs.changed == 'true') - runs-on: macos-15 - steps: - - uses: actions/checkout@v4 - - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 - with: - cache_key: spm-binary - - name: Xcode - run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer - - name: Initialize xcodebuild - run: scripts/setup_spm_tests.sh - - name: iOS Build Test - run: scripts/third_party/travis/retry.sh ./scripts/build.sh FirebaseFirestore iOS spmbuildonly + uses: ./.github/workflows/common.yml + with: + target: FirebaseFirestore + platforms: iOS + buildonly_platforms: iOS check-firestore-internal-public-headers: needs: check From ed38aaaa73422362d60bb93fd5ac39b2999d846e Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 2 Jun 2025 15:44:27 -0400 Subject: [PATCH 2/6] Update .github/workflows/firestore.yml --- .github/workflows/firestore.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index a029ba23630..38b4b639147 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -390,7 +390,7 @@ jobs: product: ['FirebaseFirestoreInternal', 'FirebaseFirestore'] uses: ./.github/workflows/common_cocoapods.yml with: - product: FirebaseFunctions + product: ${{ matrix.product }} platforms: iOS allow_warnings: true # --no-analyze # TODO(#9565, b/227461966): Remove --no-analyze when absl is fixed. From aae3cc9717d1b0f2c07073780f76641229d7d531 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 2 Jun 2025 17:02:45 -0400 Subject: [PATCH 3/6] CI fix --- .github/workflows/common_cocoapods.yml | 6 ++++++ .github/workflows/firestore.yml | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index 50834b04431..41b75ab3998 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -69,6 +69,12 @@ on: required: false default: false + # Whether to lint with `--analyze`. Defaults to true. + analyze: + type: boolean + required: false + default: true + # Whether to additionally build with Swift 6. Defaults to false. supports_swift6: type: boolean diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index 38b4b639147..8f4ac2b1264 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -393,7 +393,7 @@ jobs: product: ${{ matrix.product }} platforms: iOS allow_warnings: true - # --no-analyze # TODO(#9565, b/227461966): Remove --no-analyze when absl is fixed. + analyze: false # TODO(#9565, b/227461966): Remove when absl is fixed. # `pod lib lint` takes a long time so only run the other platforms and static frameworks build in the cron. pod-lib-lint-cron: From b21c9790c7c6a9d2a2719c9336f68fd25d73f807 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 2 Jun 2025 17:04:12 -0400 Subject: [PATCH 4/6] [will revert] disable workflow trigger for non-fst workflows --- .github/workflows/abtesting.yml | 2 +- .github/workflows/appdistribution.yml | 2 +- .github/workflows/auth.yml | 2 +- .github/workflows/core.yml | 2 +- .github/workflows/core_extension.yml | 2 +- .github/workflows/core_internal.yml | 2 +- .github/workflows/crashlytics.yml | 2 +- .github/workflows/database.yml | 2 +- .github/workflows/dynamiclinks.yml | 2 +- .github/workflows/firebase_app_check.yml | 2 +- .github/workflows/firebaseai.yml | 2 +- .github/workflows/functions.yml | 2 +- .github/workflows/inappmessaging.yml | 2 +- .github/workflows/messaging.yml | 2 +- .github/workflows/mlmodeldownloader.yml | 2 +- .github/workflows/performance.yml | 2 +- .github/workflows/remoteconfig.yml | 2 +- .github/workflows/sessions.yml | 2 +- .github/workflows/shared-swift.yml | 2 +- .github/workflows/vertexai.yml | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/abtesting.yml b/.github/workflows/abtesting.yml index f874410e988..61568b28433 100644 --- a/.github/workflows/abtesting.yml +++ b/.github/workflows/abtesting.yml @@ -11,7 +11,7 @@ on: - 'Interop/Analytics/Public/*.h' - '.github/workflows/abtesting.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am(PST) - cron uses UTC times diff --git a/.github/workflows/appdistribution.yml b/.github/workflows/appdistribution.yml index 059a5ab88b6..5d8a2f304f9 100644 --- a/.github/workflows/appdistribution.yml +++ b/.github/workflows/appdistribution.yml @@ -10,7 +10,7 @@ on: - 'FirebaseAppDistribution**' - '.github/workflows/appdistribution.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am (PST) - cron uses UTC times diff --git a/.github/workflows/auth.yml b/.github/workflows/auth.yml index 8426fefcfbe..b88fb80a0f6 100644 --- a/.github/workflows/auth.yml +++ b/.github/workflows/auth.yml @@ -11,7 +11,7 @@ on: - 'FirebaseAuth/Interop/*.h' - '.github/workflows/auth.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'scripts/gha-encrypted/AuthSample/SwiftApplication.plist.gpg' - 'Gemfile*' schedule: diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index ccaeb26736b..9181841aa22 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -10,7 +10,7 @@ on: - 'FirebaseCore**' - '.github/workflows/core.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/core_extension.yml b/.github/workflows/core_extension.yml index 15b86f38538..4ce7b9fd967 100644 --- a/.github/workflows/core_extension.yml +++ b/.github/workflows/core_extension.yml @@ -11,7 +11,7 @@ on: - 'FirebaseCore/Extension/**' - '.github/workflows/core_extension.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/core_internal.yml b/.github/workflows/core_internal.yml index 02ae537a6ff..dd42177207c 100644 --- a/.github/workflows/core_internal.yml +++ b/.github/workflows/core_internal.yml @@ -11,7 +11,7 @@ on: - 'FirebaseCore/Internal/**' - '.github/workflows/core_internal.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 05f492d68d3..e18d81f85fe 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -11,7 +11,7 @@ on: - 'FirebaseCrashlytics.podspec' - '.github/workflows/crashlytics.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Interop/Analytics/Public/*.h' - 'Gemfile*' schedule: diff --git a/.github/workflows/database.yml b/.github/workflows/database.yml index 694ed7b48e5..5f852a3b7c9 100644 --- a/.github/workflows/database.yml +++ b/.github/workflows/database.yml @@ -14,7 +14,7 @@ on: - 'FirebaseAuth/Interop/*.h' - '.github/workflows/database.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' - 'scripts/run_database_emulator.sh' schedule: diff --git a/.github/workflows/dynamiclinks.yml b/.github/workflows/dynamiclinks.yml index b6c2ff19c0b..42505a41d5e 100644 --- a/.github/workflows/dynamiclinks.yml +++ b/.github/workflows/dynamiclinks.yml @@ -11,7 +11,7 @@ on: - '.github/workflows/dynamiclinks.yml' - 'Interop/Analytics/Public/*.h' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am (PST) - cron uses UTC times diff --git a/.github/workflows/firebase_app_check.yml b/.github/workflows/firebase_app_check.yml index 5e5c749d808..4098e892c1b 100644 --- a/.github/workflows/firebase_app_check.yml +++ b/.github/workflows/firebase_app_check.yml @@ -10,7 +10,7 @@ on: - 'FirebaseAppCheck**' - '.github/workflows/firebase_app_check.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 11pm (PST) - cron uses UTC times diff --git a/.github/workflows/firebaseai.yml b/.github/workflows/firebaseai.yml index 1184ce74897..17360bf793a 100644 --- a/.github/workflows/firebaseai.yml +++ b/.github/workflows/firebaseai.yml @@ -6,7 +6,7 @@ on: - 'FirebaseAI**' - '.github/workflows/firebaseai.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'scripts/quickstart_build_spm.sh' - 'scripts/quickstart_spm_xcodeproj.sh' - 'Gemfile*' diff --git a/.github/workflows/functions.yml b/.github/workflows/functions.yml index c7a8b6e54ca..1492e217590 100644 --- a/.github/workflows/functions.yml +++ b/.github/workflows/functions.yml @@ -11,7 +11,7 @@ on: - 'FirebaseSharedSwift**' - '.github/workflows/functions.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'FirebaseAuth/Interop/*.h' - 'FirebaseMessaging/Interop/*.h' - 'FirebaseTestingSupport/Functions/**' diff --git a/.github/workflows/inappmessaging.yml b/.github/workflows/inappmessaging.yml index 6650fbb8fc9..a602c6c6a4b 100644 --- a/.github/workflows/inappmessaging.yml +++ b/.github/workflows/inappmessaging.yml @@ -11,7 +11,7 @@ on: - 'Interop/Analytics/Public/*.h' - '.github/workflows/inappmessaging.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 10pm (PST) - cron uses UTC times diff --git a/.github/workflows/messaging.yml b/.github/workflows/messaging.yml index 71d8c111578..a61ce303eaf 100644 --- a/.github/workflows/messaging.yml +++ b/.github/workflows/messaging.yml @@ -17,7 +17,7 @@ on: - '.github/workflows/messaging.yml' # Re-usable workflows being used by this file. - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' # Rebuild on Ruby infrastructure changes - 'Gemfile*' schedule: diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 6e16642d311..07d52ae5063 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -10,7 +10,7 @@ on: - 'FirebaseMLModelDownloader**' - '.github/workflows/mlmodeldownloader.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 11pm (PST) - cron uses UTC times diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index b5e0beea295..a133cefd349 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -17,7 +17,7 @@ on: - '.github/workflows/performance.yml' # Re-usable workflows depended on by this file. - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' # Rebuild on Ruby infrastructure changes - 'Gemfile*' schedule: diff --git a/.github/workflows/remoteconfig.yml b/.github/workflows/remoteconfig.yml index 3f23f427b3a..0046302314c 100644 --- a/.github/workflows/remoteconfig.yml +++ b/.github/workflows/remoteconfig.yml @@ -11,7 +11,7 @@ on: - 'Interop/Analytics/Public/*.h' - '.github/workflows/remoteconfig.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' - 'scripts/generate_access_token.sh' - 'scripts/gha-encrypted/RemoteConfigSwiftAPI/**' diff --git a/.github/workflows/sessions.yml b/.github/workflows/sessions.yml index 976b3886c1f..c8c3002a256 100644 --- a/.github/workflows/sessions.yml +++ b/.github/workflows/sessions.yml @@ -11,7 +11,7 @@ on: - 'FirebaseSessions.podspec' - '.github/workflows/sessions.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 9am (PST) - cron uses UTC times diff --git a/.github/workflows/shared-swift.yml b/.github/workflows/shared-swift.yml index b1292ebb253..e75a07ebe22 100644 --- a/.github/workflows/shared-swift.yml +++ b/.github/workflows/shared-swift.yml @@ -10,7 +10,7 @@ on: - 'FirebaseSharedSwift**' - '.github/workflows/shared-swift.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/vertexai.yml b/.github/workflows/vertexai.yml index c5db31d75df..605a34ebbd7 100644 --- a/.github/workflows/vertexai.yml +++ b/.github/workflows/vertexai.yml @@ -10,7 +10,7 @@ on: - 'FirebaseVertexAI**' - '.github/workflows/vertexai.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' + # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 11pm (PST) - cron uses UTC times From a0419e49575671c9c74d7f778fb48507bd69aaf3 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 2 Jun 2025 17:10:34 -0400 Subject: [PATCH 5/6] revert earlier change --- .github/workflows/abtesting.yml | 2 +- .github/workflows/appdistribution.yml | 2 +- .github/workflows/auth.yml | 2 +- .github/workflows/core.yml | 2 +- .github/workflows/core_extension.yml | 2 +- .github/workflows/core_internal.yml | 2 +- .github/workflows/crashlytics.yml | 2 +- .github/workflows/database.yml | 2 +- .github/workflows/dynamiclinks.yml | 2 +- .github/workflows/firebase_app_check.yml | 2 +- .github/workflows/firebaseai.yml | 2 +- .github/workflows/functions.yml | 2 +- .github/workflows/inappmessaging.yml | 2 +- .github/workflows/messaging.yml | 2 +- .github/workflows/mlmodeldownloader.yml | 2 +- .github/workflows/performance.yml | 2 +- .github/workflows/remoteconfig.yml | 2 +- .github/workflows/sessions.yml | 2 +- .github/workflows/shared-swift.yml | 2 +- .github/workflows/vertexai.yml | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/abtesting.yml b/.github/workflows/abtesting.yml index a370de51a90..a8701041b72 100644 --- a/.github/workflows/abtesting.yml +++ b/.github/workflows/abtesting.yml @@ -11,7 +11,7 @@ on: - 'Interop/Analytics/Public/*.h' - '.github/workflows/abtesting.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/appdistribution.yml b/.github/workflows/appdistribution.yml index f50e4ea8c85..026e95f81ac 100644 --- a/.github/workflows/appdistribution.yml +++ b/.github/workflows/appdistribution.yml @@ -10,7 +10,7 @@ on: - 'FirebaseAppDistribution**' - '.github/workflows/appdistribution.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/auth.yml b/.github/workflows/auth.yml index 82db22d6947..9f207d650f5 100644 --- a/.github/workflows/auth.yml +++ b/.github/workflows/auth.yml @@ -11,7 +11,7 @@ on: - 'FirebaseAuth/Interop/*.h' - '.github/workflows/auth.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'scripts/gha-encrypted/AuthSample/SwiftApplication.plist.gpg' - 'Gemfile*' diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 5a8b85eee45..f380a85947b 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -10,7 +10,7 @@ on: - 'FirebaseCore**' - '.github/workflows/core.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/core_extension.yml b/.github/workflows/core_extension.yml index 4ce7b9fd967..15b86f38538 100644 --- a/.github/workflows/core_extension.yml +++ b/.github/workflows/core_extension.yml @@ -11,7 +11,7 @@ on: - 'FirebaseCore/Extension/**' - '.github/workflows/core_extension.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/core_internal.yml b/.github/workflows/core_internal.yml index 68744902e1d..d1b8dd6cf73 100644 --- a/.github/workflows/core_internal.yml +++ b/.github/workflows/core_internal.yml @@ -11,7 +11,7 @@ on: - 'FirebaseCore/Internal/**' - '.github/workflows/core_internal.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 72be2ffbc3d..a32d474a61b 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -11,7 +11,7 @@ on: - 'FirebaseCrashlytics.podspec' - '.github/workflows/crashlytics.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Interop/Analytics/Public/*.h' - 'Gemfile*' diff --git a/.github/workflows/database.yml b/.github/workflows/database.yml index d6eb34596d9..6177b637cae 100644 --- a/.github/workflows/database.yml +++ b/.github/workflows/database.yml @@ -14,7 +14,7 @@ on: - 'FirebaseAuth/Interop/*.h' - '.github/workflows/database.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' - 'scripts/run_database_emulator.sh' diff --git a/.github/workflows/dynamiclinks.yml b/.github/workflows/dynamiclinks.yml index 42505a41d5e..b6c2ff19c0b 100644 --- a/.github/workflows/dynamiclinks.yml +++ b/.github/workflows/dynamiclinks.yml @@ -11,7 +11,7 @@ on: - '.github/workflows/dynamiclinks.yml' - 'Interop/Analytics/Public/*.h' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am (PST) - cron uses UTC times diff --git a/.github/workflows/firebase_app_check.yml b/.github/workflows/firebase_app_check.yml index f85337b1d53..ff30db15a66 100644 --- a/.github/workflows/firebase_app_check.yml +++ b/.github/workflows/firebase_app_check.yml @@ -10,7 +10,7 @@ on: - 'FirebaseAppCheck**' - '.github/workflows/firebase_app_check.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/firebaseai.yml b/.github/workflows/firebaseai.yml index 17360bf793a..1184ce74897 100644 --- a/.github/workflows/firebaseai.yml +++ b/.github/workflows/firebaseai.yml @@ -6,7 +6,7 @@ on: - 'FirebaseAI**' - '.github/workflows/firebaseai.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'scripts/quickstart_build_spm.sh' - 'scripts/quickstart_spm_xcodeproj.sh' - 'Gemfile*' diff --git a/.github/workflows/functions.yml b/.github/workflows/functions.yml index 1492e217590..c7a8b6e54ca 100644 --- a/.github/workflows/functions.yml +++ b/.github/workflows/functions.yml @@ -11,7 +11,7 @@ on: - 'FirebaseSharedSwift**' - '.github/workflows/functions.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'FirebaseAuth/Interop/*.h' - 'FirebaseMessaging/Interop/*.h' - 'FirebaseTestingSupport/Functions/**' diff --git a/.github/workflows/inappmessaging.yml b/.github/workflows/inappmessaging.yml index a602c6c6a4b..6650fbb8fc9 100644 --- a/.github/workflows/inappmessaging.yml +++ b/.github/workflows/inappmessaging.yml @@ -11,7 +11,7 @@ on: - 'Interop/Analytics/Public/*.h' - '.github/workflows/inappmessaging.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 10pm (PST) - cron uses UTC times diff --git a/.github/workflows/messaging.yml b/.github/workflows/messaging.yml index bab6da7598b..cd89ca840fc 100644 --- a/.github/workflows/messaging.yml +++ b/.github/workflows/messaging.yml @@ -17,7 +17,7 @@ on: - '.github/workflows/messaging.yml' # Re-usable workflows being used by this file. - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' # Rebuild on Ruby infrastructure changes - 'Gemfile*' diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index f4e27a57c61..3eddabeadec 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -10,7 +10,7 @@ on: - 'FirebaseMLModelDownloader**' - '.github/workflows/mlmodeldownloader.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index d0d58cd4e91..b1073dfd11f 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -17,7 +17,7 @@ on: - '.github/workflows/performance.yml' # Re-usable workflows depended on by this file. - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' # Rebuild on Ruby infrastructure changes - 'Gemfile*' diff --git a/.github/workflows/remoteconfig.yml b/.github/workflows/remoteconfig.yml index 81e7ef31e7e..dc764c6a88d 100644 --- a/.github/workflows/remoteconfig.yml +++ b/.github/workflows/remoteconfig.yml @@ -11,7 +11,7 @@ on: - 'Interop/Analytics/Public/*.h' - '.github/workflows/remoteconfig.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' - 'scripts/generate_access_token.sh' diff --git a/.github/workflows/sessions.yml b/.github/workflows/sessions.yml index 30efce6a912..d3ec5adb7f1 100644 --- a/.github/workflows/sessions.yml +++ b/.github/workflows/sessions.yml @@ -11,7 +11,7 @@ on: - 'FirebaseSessions.podspec' - '.github/workflows/sessions.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/shared-swift.yml b/.github/workflows/shared-swift.yml index e75a07ebe22..b1292ebb253 100644 --- a/.github/workflows/shared-swift.yml +++ b/.github/workflows/shared-swift.yml @@ -10,7 +10,7 @@ on: - 'FirebaseSharedSwift**' - '.github/workflows/shared-swift.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/vertexai.yml b/.github/workflows/vertexai.yml index 605a34ebbd7..c5db31d75df 100644 --- a/.github/workflows/vertexai.yml +++ b/.github/workflows/vertexai.yml @@ -10,7 +10,7 @@ on: - 'FirebaseVertexAI**' - '.github/workflows/vertexai.yml' - '.github/workflows/common.yml' - # - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 11pm (PST) - cron uses UTC times From 7b84de3b86327c34d00f44d644c5d37cd66ea7b3 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 2 Jun 2025 18:58:14 -0400 Subject: [PATCH 6/6] actually use new param --- .github/workflows/common_cocoapods.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index 41b75ab3998..6536c5a3f47 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -146,5 +146,6 @@ jobs: command: | scripts/pod_lib_lint.rb ${{ inputs.product }}.podspec --platforms=${{ matrix.platform }} \ ${{ inputs.allow_warnings == true && '--allow-warnings' || '' }} \ + ${{ inputs.analyze == false && '--no-analyze' || '' }} \ ${{ inputs.test_specs != '' && format('--test-specs={0}', inputs.test_specs) || '' }} \ ${{ (contains(inputs.buildonly_platforms, matrix.platform) || contains(inputs.buildonly_platforms, 'all')) && '--skip-tests' || '' }}