use yarn/node_modules cache everywhere, and upload test-changed builds

Author: dlarocque

.github/workflows/build.yml

@@ -31,12 +31,18 @@ jobs:
       with:
         # Canary release script requires git history and tags.
         fetch-depth: 0
-    - name: Set up Node (20)
-      uses: actions/setup-node@v4
+    - uses: actions/setup-node@v4
       with:
         node-version-file: '.nvmrc'
-    - name: Yarn install
-      run: yarn
+        cache: yarn
+        cache-dependency-path: yarn.lock
+    - name: Restore cached node_modules
+      uses: actions/cache@v4
+      id: node_modules
+      with:
+        path: "**/node_modules"
+        key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+    - run: yarn install --frozen-lockfile
     - name: Deploy canary
       run: yarn release canary
       env:

.github/workflows/canary-deploy.yml

@@ -34,12 +34,18 @@ jobs:
       with:
         # This makes Actions fetch all Git history so check_changeset script can diff properly.
         fetch-depth: 0
-    - name: Set up Node (20)
-      uses: actions/setup-node@v4
+    - uses: actions/setup-node@v4
       with:
         node-version-file: '.nvmrc'
-    - name: Yarn install
-      run: yarn
+        cache: yarn
+        cache-dependency-path: yarn.lock
+    - name: Restore cached node_modules
+      uses: actions/cache@v4
+      id: node_modules
+      with:
+        path: "**/node_modules"
+        key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+    - run: yarn install --frozen-lockfile
     - name: Run changeset script
       # pull main so changeset can diff against it
       run: |

.github/workflows/check-changeset.yml

@@ -27,12 +27,18 @@ jobs:
       with:
         # get all history for the diff
         fetch-depth: 0
-    - name: Set up Node (20)
-      uses: actions/setup-node@v4
+    - uses: actions/setup-node@v4
       with:
         node-version-file: '.nvmrc'
-    - name: Yarn install
-      run: yarn
+        cache: yarn
+        cache-dependency-path: yarn.lock
+    - name: Restore cached node_modules
+      uses: actions/cache@v4
+      id: node_modules
+      with:
+        path: "**/node_modules"
+        key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+    - run: yarn install --frozen-lockfile
     - name: Run doc generation
       run: yarn docgen:all
     - name: Check for changes in docs-devsite dir (fail if so)

.github/workflows/check-docs.yml

@@ -15,15 +15,10 @@
 name: Test Package Paths
 
 on:
-  workflow_run:
-    workflows: ["Build"]
-    types:
-      - completed
   pull_request:
 
 jobs:
   test:
-    if: ${{ github.event.workflow_run.conclusion == 'success'}}
     name: Test Package Paths
     runs-on: ubuntu-latest
 
@@ -45,10 +40,7 @@ jobs:
         path: "**/node_modules"
         key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
     - run: yarn install --frozen-lockfile
-    - name: Download build archive
-      uses: actions/download-artifact@v4
-      with:
-        name: dists-${{ github.sha }}
+    - run: yarn build
     - name: Swap in public typings
       run: yarn release:prepare
     - name: Check paths

.github/workflows/check-pkg-paths.yml

@@ -35,12 +35,18 @@ jobs:
       with:
         # This makes Actions fetch all Git history so run-changed script can diff properly.
         fetch-depth: 0
-    - name: Set up node (20)
-      uses: actions/setup-node@v4
+    - uses: actions/setup-node@v4
       with:
         node-version-file: '.nvmrc'
-    - name: Yarn install
-      run: yarn
+        cache: yarn
+        cache-dependency-path: yarn.lock
+    - name: Restore cached node_modules
+      uses: actions/cache@v4
+      id: node_modules
+      with:
+        path: "**/node_modules"
+        key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+    - run: yarn install --frozen-lockfile
     - name: Deploy project config if needed
       run: yarn ts-node scripts/ci-test/deploy-if-needed.ts
       env:

.github/workflows/deploy-config.yml

@@ -36,10 +36,11 @@ jobs:
     steps:
       - name: Checkout Repo
         uses: actions/checkout@v4
-      - name: Set up Node (20)
-        uses: actions/setup-node@master
+      - uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
+          cache: yarn
+          cache-dependency-path: yarn.lock
       - name: install Chrome stable
         run: |
           sudo apt-get update

.github/workflows/e2e-test.yml

@@ -31,12 +31,18 @@ jobs:
       with:
         # get all history for the diff
         fetch-depth: 0
-    - name: Set up node (20)
-      uses: actions/setup-node@v4
+    - uses: actions/setup-node@v4
       with:
         node-version-file: '.nvmrc'
-    - name: Yarn install
-      run: yarn
+        cache: yarn
+        cache-dependency-path: yarn.lock
+    - name: Restore cached node_modules
+      uses: actions/cache@v4
+      id: node_modules
+      with:
+        path: "**/node_modules"
+        key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+    - run: yarn install --frozen-lockfile
     - name: Run formatting script
       run: yarn format
     - name: Check for changes (fail if so)

.github/workflows/format.yml

@@ -15,10 +15,6 @@
 name: Health Metrics
 
 on:
-  workflow_run:
-    workflows: ["Build"]
-    types:
-      - completed
   push:
     branches: ['**']
   pull_request:
@@ -39,7 +35,7 @@ env:
 jobs:
   binary-size:
     name: Binary Size
-    if: (${{ github.event.workflow_run.conclusion == 'success'}} && (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]'))
+    if: (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -59,15 +55,12 @@ jobs:
         with:
           credentials_json: '${{ secrets.GCP_SA_KEY }}'
       - uses: google-github-actions/setup-gcloud@v2
-      - name: Download build archive
-        uses: actions/download-artifact@v4
-        with:
-          name: dists-${{ github.sha }}
+      - run: yarn build
       - name: Run health-metrics/binary-size test
         run: yarn size-report
   modular-export-size:
     name: Binary Size For Modular Exports
-    if: (${{ github.event.workflow_run.conclusion == 'success'}} && (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]'))
+    if: (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -85,10 +78,7 @@ jobs:
           path: "**/node_modules"
           key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
       - run: yarn install --frozen-lockfile
-      - name: Download build archive
-        uses: actions/download-artifact@v4
-        with:
-          name: dists-${{ github.sha }}
+      - run: yarn build
       - name: Run health-metrics/modular-exports-binary-size test
         run: yarn modular-export-size-report
   # TODO(yifany): Enable startup times testing on CI.

.github/workflows/health-metrics-pull-request.yml

@@ -23,11 +23,17 @@ jobs:
 
     steps:
     - uses: actions/checkout@v3
-    - name: Set up node (20)
-      uses: actions/setup-node@v4
+    - uses: actions/setup-node@v4
       with:
         node-version-file: '.nvmrc'
-    - name: yarn install
-      run: yarn
+        cache: yarn
+        cache-dependency-path: yarn.lock
+    - name: Restore cached node_modules
+      uses: actions/cache@v4
+      id: node_modules
+      with:
+        path: "**/node_modules"
+        key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+    - run: yarn install --frozen-lockfile
     - name: yarn lint
       run: yarn lint