Skip to content

Commit 157cf6b

Browse files
committed
Fix public typings
1 parent d40fa1c commit 157cf6b

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

common/api-review/telemetry.api.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
import { AnyValueMap } from '@opentelemetry/api-logs';
88
import { FirebaseApp } from '@firebase/app';
9-
import { Instrumentation } from 'next';
109
import { LoggerProvider } from '@opentelemetry/sdk-logs';
1110

1211
// @public
@@ -18,7 +17,13 @@ export function flush(telemetry: Telemetry): Promise<void>;
1817
// @public
1918
export function getTelemetry(app?: FirebaseApp): Telemetry;
2019

21-
export { Instrumentation }
20+
// @public (undocumented)
21+
export namespace Instrumentation {
22+
// Warning: (ae-forgotten-export) The symbol "InstrumentationOnRequestError" needs to be exported by the entry point index.d.ts
23+
//
24+
// (undocumented)
25+
export type onRequestError = InstrumentationOnRequestError;
26+
}
2227

2328
// @public
2429
export const nextOnRequestError: Instrumentation.onRequestError;

packages/telemetry/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@
4848
"test:browser": "karma start",
4949
"test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha **/*.test.ts src/**/*.test.ts --config ../../config/mocharc.node.js",
5050
"trusted-type-check": "tsec -p tsconfig.json --noEmit",
51-
"api-report": "ts-node-script ../../repo-scripts/prune-dts/extract-public-api.ts --package telemetry --packageRoot . --typescriptDts ./dist/index.d.ts --rollupDts ./dist/private.d.ts --untrimmedRollupDts ./dist/internal.d.ts --publicDts ./dist/telemetry-public.d.ts",
52-
"typings:public": "node ../../scripts/build/use_typings.js ./dist/telemetry-public.d.ts"
51+
"api-report": "api-extractor run --local --verbose",
52+
"typings:public": "node ../../scripts/build/use_typings.js ./dist/index.d.ts"
5353
},
5454
"peerDependencies": {
5555
"@firebase/app": "0.x",
@@ -102,7 +102,7 @@
102102
"bugs": {
103103
"url": "https://github.com/firebase/firebase-js-sdk/issues"
104104
},
105-
"typings": "./dist/telemetry-public.d.ts",
105+
"typings": "./dist/index.d.ts",
106106
"nyc": {
107107
"extension": [
108108
".ts"

0 commit comments

Comments
 (0)