Skip to content

Commit 22c8fa2

Browse files
committed
Removed unnecessary changes
1 parent d210372 commit 22c8fa2

File tree

3 files changed

+11
-38
lines changed

3 files changed

+11
-38
lines changed

common/api-review/data-connect.api.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ import { FirebaseError } from '@firebase/util';
1111
import { LogLevelString } from '@firebase/logger';
1212
import { Provider } from '@firebase/component';
1313

14-
// @public (undocumented)
15-
export function areTransportOptionsEqual(transportOptions1: TransportOptions, transportOptions2: TransportOptions): boolean;
16-
1714
// @public (undocumented)
1815
export interface CancellableOperation<T> extends PromiseLike<{
1916
data: T;
@@ -162,9 +159,6 @@ export function queryRef<Data>(dcInstance: DataConnect, queryName: string): Quer
162159
// @public
163160
export function queryRef<Data, Variables>(dcInstance: DataConnect, queryName: string, variables: Variables): QueryRef<Data, Variables>;
164161

165-
// @public (undocumented)
166-
export function queryRef<Data, Variables>(dcInstance: DataConnect, serializedRef: SerializedRef<Data, Variables>): QueryRef<Data, Variables>;
167-
168162
// @public
169163
export interface QueryResult<Data, Variables> extends DataConnectResult<Data, Variables> {
170164
// (undocumented)

packages/data-connect/src/api/DataConnect.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,12 @@ export class DataConnect {
194194
}
195195
}
196196

197-
// @internal
197+
/**
198+
* @internal
199+
* @param transportOptions1
200+
* @param transportOptions2
201+
* @returns
202+
*/
198203
export function areTransportOptionsEqual(
199204
transportOptions1: TransportOptions,
200205
transportOptions2: TransportOptions

packages/data-connect/src/api/query.ts

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -104,53 +104,27 @@ export function queryRef<Data, Variables>(
104104
queryName: string,
105105
variables: Variables
106106
): QueryRef<Data, Variables>;
107-
108-
export function queryRef<Data, Variables>(
109-
dcInstance: DataConnect,
110-
serializedRef: SerializedRef<Data, Variables>
111-
): QueryRef<Data, Variables>;
112-
113107
/**
114108
* Execute Query
115109
* @param dcInstance Data Connect instance to use.
116-
* @param queryNameOrSerializedRef Query to execute
110+
* @param queryName Query to execute
117111
* @param variables Variables to execute with
118112
* @param initialCache initial cache to use for client hydration
119113
* @returns `QueryRef`
120114
*/
121115
export function queryRef<Data, Variables>(
122116
dcInstance: DataConnect,
123-
queryNameOrSerializedRef: string | SerializedRef<Data, Variables>,
117+
queryName: string,
124118
variables?: Variables,
125119
initialCache?: QueryResult<Data, Variables>
126120
): QueryRef<Data, Variables> {
127121
dcInstance.setInitialized();
128-
if (typeof queryNameOrSerializedRef === 'string') {
129-
dcInstance._queryManager.track(
130-
queryNameOrSerializedRef,
131-
variables,
132-
initialCache
133-
);
134-
} else {
135-
dcInstance._queryManager.track(
136-
queryNameOrSerializedRef.refInfo.name,
137-
queryNameOrSerializedRef.refInfo.variables,
138-
queryNameOrSerializedRef
139-
);
140-
}
141-
const vars =
142-
typeof queryNameOrSerializedRef !== 'string'
143-
? queryNameOrSerializedRef.refInfo.variables
144-
: variables;
145-
const name =
146-
typeof queryNameOrSerializedRef !== 'string'
147-
? queryNameOrSerializedRef.refInfo.name
148-
: queryNameOrSerializedRef;
122+
dcInstance._queryManager.track(queryName, variables, initialCache);
149123
return {
150124
dataConnect: dcInstance,
151125
refType: QUERY_STR,
152-
name,
153-
variables: vars
126+
name: queryName,
127+
variables: variables as Variables
154128
};
155129
}
156130
/**

0 commit comments

Comments
 (0)