Skip to content

Commit 2cdb529

Browse files
google-oss-botgoogle-oss-bot
authored
Merge master into release
2 parents 242a347 + 7bde55c commit 2cdb529

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+679
-221
lines changed

‎.changeset/funny-ways-carry.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/app': patch
3+
---
4+
5+
Make the error more helpful when `getApp()` is called before `initializeApp()`.

‎.changeset/long-lemons-change.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@firebase/firestore': minor
3+
'firebase': minor
4+
---
5+
6+
Enabled long-polling networking mode auto detection by default. It can be explicitly disabled by setting `FirestoreSettings.experimentalForceLongPolling` to `false`.

‎.changeset/sixty-dolls-report.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/app': patch
3+
---
4+
5+
Catch more heartbeat read/write errors.

‎.changeset/small-chairs-explain.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/auth': patch
3+
---
4+
5+
Allow port numbers in authDomain

‎.changeset/witty-wasps-play.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@firebase/firestore': minor
3+
'firebase': minor
4+
---
5+
6+
Added the ability to configure the long-polling hanging get request timeout using the new `experimentalLongPollingOptions.timeoutSeconds` setting

‎.github/ISSUE_TEMPLATE/bug_report_v2.yaml

Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,84 @@
1+
name: 🐞 Bug Report V2
2+
description: File a bug report
3+
title: '[Bug]: '
4+
body:
5+
- type: markdown
6+
id: before-you-start
7+
attributes:
8+
value: |
9+
*[READ THIS]:* to evaluate if you are in the right place?
10+
- For issues or feature requests related to __the code in this repository__, file a Github issue.
11+
- If this is a __feature request__, make sure the issue title starts with "FR:".
12+
- For general technical questions, post a question on [StackOverflow](http://stackoverflow.com/) with the firebase tag.
13+
- For general Firebase discussion, use the [firebase-talk](https://groups.google.com/forum/#!forum/firebase-talk) google group.
14+
- For help troubleshooting your application that does not fall under one of the above categories, reach out to the personalized [Firebase support channel](https://firebase.google.com/support/).
15+
- type: input
16+
id: operating-system
17+
attributes:
18+
label: Operating System
19+
description: Describe your operating system
20+
placeholder: ex. iOS 16.4
21+
validations:
22+
required: true
23+
- type: input
24+
id: browser-version
25+
attributes:
26+
label: Browser Version
27+
description: Describe your browser version
28+
placeholder: ex. Safari/604.1
29+
validations:
30+
required: true
31+
- type: input
32+
id: firebase-sdk-version
33+
attributes:
34+
label: Firebase SDK Version
35+
description: Describe your Firebase SDK Version
36+
placeholder: ex. 9.16.0
37+
validations:
38+
required: true
39+
- type: dropdown
40+
id: firebase-sdk-products
41+
attributes:
42+
label: 'Firebase SDK Product:'
43+
description: Which Firebase Products are used in your app?
44+
multiple: true
45+
options:
46+
- Analytics
47+
- AppCheck
48+
- Auth
49+
- Component
50+
- Database
51+
- Firestore
52+
- Functions
53+
- Installations
54+
- Logger
55+
- Messaging
56+
- Performance
57+
- Remote-Config
58+
- Storage
59+
validations:
60+
required: true
61+
- type: textarea
62+
id: project-tooling
63+
attributes:
64+
label: Describe your project's tooling
65+
description: Describe the tooling your app is built with
66+
placeholder: React app with Webpack and Jest
67+
validations:
68+
required: true
69+
- type: textarea
70+
id: describe-your-problem
71+
attributes:
72+
label: Describe the problem
73+
description: Describe what you were trying to do and what occurred
74+
placeholder: |
75+
What were you trying to accomplish? What happened? This should include a background description, log/console output, etc.
76+
validations:
77+
required: true
78+
- type: textarea
79+
id: reproduce-code
80+
attributes:
81+
label: Steps and code to reproduce issue
82+
description: Please provide a description of how to replicate your issue. Copy and paste any relevant code here to reproduce the problem or links to code to reproduce it.
83+
validations:
84+
required: true

‎.github/workflows/release-staging.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,15 +134,16 @@ jobs:
134134
https://api.github.com/repos/firebase/firebase-js-sdk/dispatches
135135
- name: Check for changes requiring a reference doc publish
136136
id: docs-check
137+
# If a diff is found (length of DIFF_CONTENTS > 0) it will write DOCS_NEEDED=true
137138
run: |
138139
LAST_PUBLISHED_VERSION=$(npm info firebase version)
139-
git diff --exit-code firebase@$LAST_PUBLISHED_VERSION HEAD docs-devsite
140-
- name: No diff, docs not needed
141-
if: ${{ success() }}
142-
run: echo "DOCS_NEEDED=false" >> $GITHUB_STATE
143-
- name: Diff returned something, docs are needed
144-
if: ${{ failure() }}
145-
run: echo "DOCS_NEEDED=true" >> $GITHUB_STATE
140+
DIFF_CONTENTS=$(git diff firebase@$LAST_PUBLISHED_VERSION HEAD docs-devsite)
141+
if [ -n "$DIFF_CONTENTS" ]
142+
then
143+
echo "DOCS_NEEDED=true" >> $GITHUB_OUTPUT
144+
else
145+
echo "DOCS_NEEDED=false" >> $GITHUB_OUTPUT
146+
fi
146147
- name: Log to release tracker
147148
# Sends release information to cloud functions endpoint of release tracker.
148149
if: ${{ always() }}

‎.vscode/settings.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010
"**/node_modules": true
1111
},
1212
"typescript.tsdk": "node_modules/typescript/lib",
13-
"files.associations": { "*.json": "jsonc" }
13+
"files.associations": { "*.json": "jsonc" },
14+
"eslint.workingDirectories": [{ "mode": "auto" }]
1415
}

‎README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ https://yarnpkg.com/en/docs/install
4545

4646
This repo currently supports building with yarn `1.x`. For instance, after installating yarn, run
4747
```bash
48-
$ yarn set version 1.22.11`
48+
$ yarn set version 1.22.11
4949
```
5050

5151
#### Java

‎common/api-review/firestore.api.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,11 @@ export function endBefore(snapshot: DocumentSnapshot<unknown>): QueryEndAtConstr
184184
// @public
185185
export function endBefore(...fieldValues: unknown[]): QueryEndAtConstraint;
186186

187+
// @public
188+
export interface ExperimentalLongPollingOptions {
189+
timeoutSeconds?: number;
190+
}
191+
187192
// @public
188193
export class FieldPath {
189194
constructor(...fieldNames: string[]);
@@ -227,6 +232,7 @@ export interface FirestoreSettings {
227232
cacheSizeBytes?: number;
228233
experimentalAutoDetectLongPolling?: boolean;
229234
experimentalForceLongPolling?: boolean;
235+
experimentalLongPollingOptions?: ExperimentalLongPollingOptions;
230236
host?: string;
231237
ignoreUndefinedProperties?: boolean;
232238
localCache?: FirestoreLocalCache;

0 commit comments

Comments
 (0)