Skip to content

Commit 33444c5

Browse files
Minor fixes in the custom signals storage API
1 parent 2bd7dc0 commit 33444c5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/remote-config/src/storage/storage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,15 +198,15 @@ export class Storage {
198198
reject(toFirebaseError(event, ErrorCode.STORAGE_GET));
199199
};
200200
storedSignalsRequest.onsuccess = event => {
201-
const storedSignals = (event.target as IDBRequest).result.value;
201+
const storedSignals = (event.target as IDBRequest).result?.value || {};
202202
const combinedSignals = {
203203
...storedSignals,
204204
...customSignals
205205
};
206206
// Filter out key-value assignments with null values since they are signals being unset
207207
const signalsToUpdate = Object.fromEntries(Object.entries(combinedSignals).filter(([_, v]) => v !== null));
208208
if (signalsToUpdate) {
209-
const setSignalsRequest = objectStore.put({compositeKey, signalsToUpdate});
209+
const setSignalsRequest = objectStore.put({compositeKey, value: signalsToUpdate});
210210
setSignalsRequest.onerror = event => {
211211
reject(toFirebaseError(event, ErrorCode.STORAGE_SET));
212212
};

0 commit comments

Comments
 (0)