Skip to content

Commit 338f970

Browse files
committed
Addressed comments'
1 parent 4c45262 commit 338f970

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

packages/data-connect/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@
3232
"build:deps": "lerna run --scope @firebase/'{app,data-connect}' --include-dependencies build",
3333
"dev": "rollup -c -w",
3434
"test": "run-p --npm-path npm lint test:emulator",
35-
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:emulator",
36-
"test:browser:unit": "karma start --unit",
35+
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
3736
"test:all": "run-p --npm-path npm lint test:browser test:node",
3837
"test:browser": "karma start",
3938
"test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",

scripts/ci-test/testConfig.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ export const testConfig: {
5454
'firebase-namespace-integration-test',
5555
'firebase-compat-typings-test',
5656
'@firebase/rules-unit-testing',
57-
'@firebase/data-connect',
5857
'@firebase/auth',
5958
'@firebase/auth-compat',
6059
'firebase'

scripts/run_tests_in_ci.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ const crossBrowserPackages = {
2727
'packages/auth': 'test:browser:unit',
2828
'packages/auth-compat': 'test:browser:unit',
2929
'packages/firestore': 'test:browser:unit',
30-
'packages/firestore-compat': 'test:browser',
31-
'packages/data-connect': 'test:browser:unit'
30+
'packages/firestore-compat': 'test:browser'
3231
};
3332

3433
function writeLogs(status, name, logText) {

0 commit comments

Comments
 (0)