Implementing new stages Sample, Union, Unnest, Replace

Author: MarkDuckworth

packages/firestore/src/api/pipeline.ts

@@ -41,8 +41,7 @@ export class Pipeline extends LitePipeline {
     db: Firestore,
     userDataReader: UserDataReader,
     userDataWriter: AbstractUserDataWriter,
-    stages: Stage[],
-    converter: unknown = {}
+    stages: Stage[]
   ): Pipeline {
     return new Pipeline(db, userDataReader, userDataWriter, stages);
   }

packages/firestore/src/lite-api/expressions.ts

@@ -2105,6 +2105,7 @@ export abstract class Expr implements ProtoSerializable<ProtoValue>, UserData {
  */
 export abstract class Selectable extends Expr {
   selectable: true = true;
+  abstract readonly alias: string;
 }
 
 /**
@@ -2245,32 +2246,28 @@ export class Field extends Selectable {
    */
   static of(name: string): Field;
   static of(path: FieldPath): Field;
-  static of(
-    pipelineOrName: Pipeline | string | FieldPath,
-    name?: string
-  ): Field {
-    if (typeof pipelineOrName === 'string') {
-      if (DOCUMENT_KEY_NAME === pipelineOrName) {
+  static of(nameOrPath: string | FieldPath): Field {
+    if (typeof nameOrPath === 'string') {
+      if (DOCUMENT_KEY_NAME === nameOrPath) {
         return new Field(documentId()._internalPath);
       }
-      return new Field(fieldPathFromArgument('of', pipelineOrName));
-    } else if (pipelineOrName instanceof FieldPath) {
-      if (documentId().isEqual(pipelineOrName)) {
+      return new Field(fieldPathFromArgument('of', nameOrPath));
+    } else {
+      if (documentId().isEqual(nameOrPath)) {
         return new Field(documentId()._internalPath);
       }
-      return new Field(pipelineOrName._internalPath);
-    } else {
-      return new Field(
-        fieldPathFromArgument('of', name!),
-        pipelineOrName as Pipeline
-      );
+      return new Field(nameOrPath._internalPath);
     }
   }
 
   fieldName(): string {
     return this.fieldPath.canonicalString();
   }
 
+  get alias(): string {
+    return this.fieldPath.canonicalString();
+  }
+
   /**
    * @private
    * @internal