Apply suggestions from code review

hsubox76 · dlarocque · web-flow · commit 34094c8748d2 · 2025-09-03T12:09:10.000-07:00
Co-authored-by: Daniel La Rocque &lt;dlarocque@google.com&gt;
diff --git a/packages/ai/src/requests/hybrid-helpers.ts b/packages/ai/src/requests/hybrid-helpers.ts
@@ -59,7 +59,7 @@ export async function callCloudOrDevice<Response>(
       }
       throw new AIError(
         AIErrorCode.UNSUPPORTED,
-        'On-device model is not available.'
+        'Inference mode is ONLY_ON_DEVICE, but an on-device model is not available.'
       );
     case InferenceMode.ONLY_IN_CLOUD:
       return inCloudCall();
@@ -72,10 +72,12 @@ export async function callCloudOrDevice<Response>(
         }
         throw e;
       }
-    default: // PREFER_ON_DEVICE
+    case InferenceMode.PREFER_ON_DEVICE:
       if (await chromeAdapter.isAvailable(request)) {
         return onDeviceCall();
       }
       return inCloudCall();
+    default:
+      throw new AIError(AIErrorCode.Error, `Unexpected infererence mode: ${(chromeAdapter as ChromeAdapterImpl).mode}`);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export async function callCloudOrDevice<Response>(`
`59`	`59`	`}`
`60`	`60`	`throw new AIError(`
`61`	`61`	`AIErrorCode.UNSUPPORTED,`
`62`		`- 'On-device model is not available.'`
	`62`	`+ 'Inference mode is ONLY_ON_DEVICE, but an on-device model is not available.'`
`63`	`63`	`);`
`64`	`64`	`case InferenceMode.ONLY_IN_CLOUD:`
`65`	`65`	`return inCloudCall();`
`@@ -72,10 +72,12 @@ export async function callCloudOrDevice<Response>(`
`72`	`72`	`}`
`73`	`73`	`throw e;`
`74`	`74`	`}`
`75`		`- default: // PREFER_ON_DEVICE`
	`75`	`+ case InferenceMode.PREFER_ON_DEVICE:`
`76`	`76`	`if (await chromeAdapter.isAvailable(request)) {`
`77`	`77`	`return onDeviceCall();`
`78`	`78`	`}`
`79`	`79`	`return inCloudCall();`
	`80`	`+ default:`
	`81`	+ throw new AIError(AIErrorCode.Error, `Unexpected infererence mode: ${(chromeAdapter as ChromeAdapterImpl).mode}`);
`80`	`82`	`}`
`81`	`83`	`}`