Skip to content

Commit 3a64510

Browse files
committed
Address comments
1 parent f485cbf commit 3a64510

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

packages/auth/src/core/auth/firebase_internal.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ describe('core/auth/firebase_internal - Regional Firebase Auth', () => {
328328
});
329329

330330
context('getUid', () => {
331-
it('returns null if currentUser is undefined', () => {
331+
it('throws an error if regionalAuth is initialized', () => {
332332
expect(() => regionalAuthInternal.getUid()).to.throw(
333333
FirebaseError,
334334
'auth/operation-not-allowed'

packages/auth/src/core/auth/firebase_internal.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export class AuthInterop implements FirebaseAuthInternal {
3636

3737
getUid(): string | null {
3838
this.assertAuthConfigured();
39+
// getUid() is not available for regional Auth. Returns `OPERATION_NOT_ALLOWED` exception for RegionalAuth.
3940
this.assertRegionalAuthConfigured();
4041
return this.auth.currentUser?.uid || null;
4142
}

0 commit comments

Comments
 (0)