change all targets to es2020

hsubox76 · hsubox76 · commit 3ab57aafc4be · 2025-06-17T12:34:00.000-07:00
diff --git a/config/tsconfig.base.json b/config/tsconfig.base.json
@@ -6,15 +6,15 @@
     "strict": true,
     "lib": [
       "dom",
-      "es2017",
+      "es2020",
       "esnext.WeakRef",
     ],
     "module": "ES2015",
     "moduleResolution": "node",
     "resolveJsonModule": true,
     "esModuleInterop": true,
     "sourceMap": true,
-    "target": "es2017",
+    "target": "es2020",
     "typeRoots": [
       "../node_modules/@types"
     ],
diff --git a/config/webpack.test.js b/config/webpack.test.js
@@ -44,7 +44,7 @@ module.exports = {
           options: {
             compilerOptions: {
               module: 'commonjs',
-              target: 'es2017',
+              target: 'es2020',
               downlevelIteration: true,
               resolveJsonModule: true
             }
@@ -56,15 +56,6 @@ module.exports = {
         use: 'source-map-loader',
         enforce: 'pre'
       },
-      {
-        test: /\.tsx?$/,
-        use: {
-          loader: 'istanbul-instrumenter-loader',
-          options: { esModules: true }
-        },
-        enforce: 'post',
-        exclude: [/\.test\.ts$/, /\btest(ing)?\//]
-      },
       {
         test: /\.js$/,
         include: [/node_modules\/chai-as-promised/],
diff --git a/integration/compat-interop/tsconfig.json b/integration/compat-interop/tsconfig.json
@@ -8,7 +8,7 @@
     "moduleResolution": "node",
     "noImplicitAny": true,
     "outDir": "dist",
-    "target": "es2017",
+    "target": "es2020",
     "sourceMap": true,
     "esModuleInterop": true
   },
diff --git a/package.json b/package.json
@@ -111,7 +111,6 @@
     "http-server": "14.1.1",
     "indexeddbshim": "10.1.0",
     "inquirer": "8.2.6",
-    "istanbul-instrumenter-loader": "3.0.1",
     "js-yaml": "4.1.0",
     "karma": "6.4.4",
     "karma-chrome-launcher": "3.2.0",
diff --git a/packages/ai/rollup.config.js b/packages/ai/rollup.config.js
@@ -39,7 +39,7 @@ const buildPlugins = [
         'integration'
       ],
       compilerOptions: {
-        target: 'es2017'
+        target: 'es2020'
       }
     }
   }),
diff --git a/packages/app/src/heartbeatService.test.ts b/packages/app/src/heartbeatService.test.ts
@@ -149,8 +149,10 @@ describe('HeartbeatServiceImpl', () => {
       expect(emptyHeaders).to.equal('');
     });
     it(`triggerHeartbeat() doesn't throw even if code errors`, async () => {
-      //@ts-expect-error Ensure this doesn't match
-      heartbeatService._heartbeatsCache?.lastSentHeartbeatDate = 50;
+      if (heartbeatService._heartbeatsCache) {
+        //@ts-expect-error Ensure this doesn't match
+        heartbeatService._heartbeatsCache.lastSentHeartbeatDate = 50;
+      }
       //@ts-expect-error Ensure you can't .push() to this
       heartbeatService._heartbeatsCache.heartbeats = 50;
       const warnStub = stub(console, 'warn');
diff --git a/packages/auth/demo/rollup.config.js b/packages/auth/demo/rollup.config.js
@@ -31,11 +31,11 @@ const workerPlugins = [
     tsconfigOverride: {
       compilerOptions: {
         declaration: false,
-        target: 'es2017',
+        target: 'es2020',
         lib: [
           // TODO: remove this
           'dom',
-          'es2017',
+          'es2020',
           'webworker'
         ]
       }
diff --git a/packages/auth/demo/src/worker/tsconfig.json b/packages/auth/demo/src/worker/tsconfig.json
@@ -2,9 +2,9 @@
   "extends": "../../../config/tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
-    "target": "es2017",
+    "target": "es2020",
     "lib": [
-      "es2017",
+      "es2020",
       "webworker"
     ]
   },
diff --git a/packages/auth/rollup.config.js b/packages/auth/rollup.config.js
@@ -200,7 +200,7 @@ const webWorkerBuild = {
         lib: [
           // Remove dom after we figure out why navigator stuff doesn't exist
           'dom',
-          'es2017',
+          'es2020',
           'webworker'
         ]
       }
diff --git a/packages/firestore-compat/rollup.config.js b/packages/firestore-compat/rollup.config.js
@@ -25,12 +25,12 @@ const util = require('../firestore/rollup.shared');
 
 const deps = Object.keys({ ...pkg.peerDependencies, ...pkg.dependencies });
 
-const es2017Plugins = [
+const es2020Plugins = [
   typescriptPlugin({
     typescript,
     tsconfigOverride: {
       compilerOptions: {
-        target: 'es2017'
+        target: 'es2020'
       }
     },
     transformers: [util.removeAssertTransformer]
@@ -46,7 +46,7 @@ const browserBuilds = [
       format: 'es',
       sourcemap: true
     },
-    plugins: es2017Plugins,
+    plugins: es2020Plugins,
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
   },
   {
@@ -58,7 +58,7 @@ const browserBuilds = [
         sourcemap: true
       }
     ],
-    plugins: es2017Plugins,
+    plugins: es2020Plugins,
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
   }
 ];
@@ -71,7 +71,7 @@ const nodeBuilds = [
       format: 'cjs',
       sourcemap: true
     },
-    plugins: es2017Plugins,
+    plugins: es2020Plugins,
     external: deps
   },
   {
@@ -81,7 +81,7 @@ const nodeBuilds = [
       format: 'es',
       sourcemap: true
     },
-    plugins: [...es2017Plugins, emitModulePackageFile()],
+    plugins: [...es2020Plugins, emitModulePackageFile()],
     external: deps
   }
 ];
@@ -94,7 +94,7 @@ const rnBuilds = [
       format: 'es',
       sourcemap: true
     },
-    plugins: es2017Plugins,
+    plugins: es2020Plugins,
     external: deps
   }
 ];
diff --git a/packages/firestore/rollup.config.debug.js b/packages/firestore/rollup.config.debug.js
@@ -35,7 +35,7 @@ const browserPlugins = function () {
       typescript,
       tsconfigOverride: {
         compilerOptions: {
-          target: 'es2017'
+          target: 'es2020'
         }
       },
       cacheDir: tmp.dirSync(),
diff --git a/packages/firestore/rollup.config.js b/packages/firestore/rollup.config.js
@@ -97,7 +97,7 @@ const allBuilds = [
         cacheDir: tmp.dirSync()
       }),
       sourcemaps(),
-      replace(generateBuildTargetReplaceConfig('cjs', 2017))
+      replace(generateBuildTargetReplaceConfig('cjs', 2020))
     ],
     external: util.resolveNodeExterns,
     treeshake: {
@@ -114,7 +114,7 @@ const allBuilds = [
     },
     plugins: [
       sourcemaps(),
-      replace(generateBuildTargetReplaceConfig('esm', 2017))
+      replace(generateBuildTargetReplaceConfig('esm', 2020))
     ],
     external: util.resolveNodeExterns,
     treeshake: {
@@ -137,7 +137,7 @@ const allBuilds = [
       moduleSideEffects: false
     }
   },
-  // Convert es2017 build to cjs
+  // Convert es2020 build to cjs
   {
     input: pkg['browser'],
     output: [
@@ -149,14 +149,14 @@ const allBuilds = [
     ],
     plugins: [
       sourcemaps(),
-      replace(generateBuildTargetReplaceConfig('cjs', 2017))
+      replace(generateBuildTargetReplaceConfig('cjs', 2020))
     ],
     external: util.resolveBrowserExterns,
     treeshake: {
       moduleSideEffects: false
     }
   },
-  // es2017 build with build target reporting
+  // es2020 build with build target reporting
   {
     input: pkg['browser'],
     output: [
@@ -168,7 +168,7 @@ const allBuilds = [
     ],
     plugins: [
       sourcemaps(),
-      replace(generateBuildTargetReplaceConfig('esm', 2017))
+      replace(generateBuildTargetReplaceConfig('esm', 2020))
     ],
     external: util.resolveBrowserExterns,
     treeshake: {
@@ -186,7 +186,7 @@ const allBuilds = [
     plugins: [
       alias(util.generateAliasConfig('rn')),
       ...browserPlugins,
-      replace(generateBuildTargetReplaceConfig('esm', 2017))
+      replace(generateBuildTargetReplaceConfig('esm', 2020))
     ],
     external: util.resolveBrowserExterns,
     treeshake: {
diff --git a/packages/firestore/rollup.config.lite.js b/packages/firestore/rollup.config.lite.js
@@ -140,7 +140,7 @@ const allBuilds = [
       moduleSideEffects: false
     }
   },
-  // Convert es2017 build to CJS
+  // Convert es2020 build to CJS
   {
     input: path.resolve('./lite', pkg.browser),
     output: [
@@ -159,7 +159,7 @@ const allBuilds = [
       moduleSideEffects: false
     }
   },
-  // Browser es2017 build
+  // Browser es2020 build
   {
     input: path.resolve('./lite', pkg.browser),
     output: [
diff --git a/packages/firestore/rollup.shared.js b/packages/firestore/rollup.shared.js
@@ -33,8 +33,8 @@ const pkg = require('./package.json');
 // This file contains shared utilities for Firestore's rollup builds.
 
 // Firestore is released in a number of different build configurations:
-// - Browser builds that support persistence in ES2017 CJS and ESM formats.
-// - In-memory Browser builds that support persistence in ES2017 CJS and ESM
+// - Browser builds that support persistence in ES2020 CJS and ESM formats.
+// - In-memory Browser builds that support persistence in ES2020 CJS and ESM
 //   formats.
 // - A NodeJS build that supports persistence (to be used with an IndexedDb
 //   shim)
@@ -46,7 +46,7 @@ const pkg = require('./package.json');
 // We use two different rollup pipelines to take advantage of tree shaking,
 // as Rollup does not support tree shaking for TypeScript classes transpiled
 // down to ES5 (see https://bit.ly/340P23U). The build pipeline in this file
-// produces tree-shaken ES2017 builds that are consumed by the ES5 builds in
+// produces tree-shaken ES2020 builds that are consumed by the ES5 builds in
 // `rollup.config.es.js`.
 //
 // All browser builds rely on Terser's property name mangling to reduce code
@@ -240,7 +240,7 @@ exports.applyPrebuilt = function (name = 'prebuilt.js') {
   });
 };
 
-exports.es2017Plugins = function (platform, mangled = false) {
+exports.es2020Plugins = function (platform, mangled = false) {
   if (mangled) {
     return [
       alias(generateAliasConfig(platform)),
@@ -265,7 +265,7 @@ exports.es2017Plugins = function (platform, mangled = false) {
   }
 };
 
-exports.es2017PluginsCompat = function (
+exports.es2020PluginsCompat = function (
   platform,
   pathTransformer,
   mangled = false
diff --git a/packages/firestore/scripts/build-bundle.js b/packages/firestore/scripts/build-bundle.js
diff --git a/packages/firestore/scripts/build-bundle.ts b/packages/firestore/scripts/build-bundle.ts
@@ -54,7 +54,7 @@ async function buildBundle(input: string, output: string): Promise<void> {
       typescriptPlugin({
         tsconfigOverride: {
           compilerOptions: {
-            target: 'es2017'
+            target: 'es2020'
           }
         },
         transformers: [util.removeAssertTransformer]
diff --git a/packages/messaging-compat/tsconfig.json b/packages/messaging-compat/tsconfig.json
@@ -3,7 +3,7 @@
   "compilerOptions": {
     "outDir": "dist",
     "noUnusedLocals": true,
-    "lib": ["dom", "es2017"],
+    "lib": ["dom", "es2020"],
     "downlevelIteration": true
   },
   "exclude": ["dist/**/*"]
diff --git a/packages/messaging/tsconfig.json b/packages/messaging/tsconfig.json
@@ -3,7 +3,7 @@
   "compilerOptions": {
     "outDir": "dist",
     "noUnusedLocals": true,
-    "lib": ["dom", "es2017"],
+    "lib": ["dom", "es2020"],
     "downlevelIteration": true
   },
   "exclude": ["dist/**/*"]
diff --git a/packages/performance-compat/rollup.config.js b/packages/performance-compat/rollup.config.js
@@ -30,7 +30,7 @@ const buildPlugins = [
     typescript,
     tsconfigOverride: {
       compilerOptions: {
-        target: 'es2017'
+        target: 'es2020'
       }
     }
   }),
diff --git a/packages/remote-config-compat/rollup.config.js b/packages/remote-config-compat/rollup.config.js
@@ -30,7 +30,7 @@ const buildPlugins = [
     typescript,
     tsconfigOverride: {
       compilerOptions: {
-        target: 'es2017'
+        target: 'es2020'
       }
     }
   }),
diff --git a/packages/storage-compat/rollup.config.js b/packages/storage-compat/rollup.config.js
@@ -31,7 +31,7 @@ const buildPlugins = [
     abortOnError: false,
     tsconfigOverride: {
       compilerOptions: {
-        target: 'es2017'
+        target: 'es2020'
       }
     }
   }),
diff --git a/packages/webchannel-wrapper/rollup.config.js b/packages/webchannel-wrapper/rollup.config.js
@@ -39,7 +39,7 @@ const buildPlugins = [
     typescript,
     tsconfigOverride: {
       compilerOptions: {
-        target: 'es2017'
+        target: 'es2020'
       }
     }
   }),
diff --git a/repo-scripts/changelog-generator/tsconfig.json b/repo-scripts/changelog-generator/tsconfig.json
@@ -9,6 +9,6 @@
     "moduleResolution": "node",
     "esModuleInterop": true,
     "resolveJsonModule": true,
-    "target": "es2017"
+    "target": "es2020"
   }
 }
diff --git a/repo-scripts/prune-dts/tsconfig.json b/repo-scripts/prune-dts/tsconfig.json
@@ -5,7 +5,7 @@
     "module": "commonjs",
     "moduleResolution": "node",
     "resolveJsonModule": true,
-    "target": "es2017",
+    "target": "es2020",
     "esModuleInterop": true,
     "declaration": true,
     "strict": true,
diff --git a/scripts/tsconfig.json b/scripts/tsconfig.json
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ const buildPlugins = [`
`39`	`39`	`'integration'`
`40`	`40`	`],`
`41`	`41`	`compilerOptions: {`
`42`		`- target: 'es2017'`
	`42`	`+ target: 'es2020'`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`	`}),`
Original file line number	Diff line number	Diff line change
`@@ -31,11 +31,11 @@ const workerPlugins = [`
`31`	`31`	`tsconfigOverride: {`
`32`	`32`	`compilerOptions: {`
`33`	`33`	`declaration: false,`
`34`		`- target: 'es2017',`
	`34`	`+ target: 'es2020',`
`35`	`35`	`lib: [`
`36`	`36`	`// TODO: remove this`
`37`	`37`	`'dom',`
`38`		`- 'es2017',`
	`38`	`+ 'es2020',`
`39`	`39`	`'webworker'`
`40`	`40`	`]`
`41`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ const webWorkerBuild = {`
`200`	`200`	`lib: [`
`201`	`201`	`// Remove dom after we figure out why navigator stuff doesn't exist`
`202`	`202`	`'dom',`
`203`		`- 'es2017',`
	`203`	`+ 'es2020',`
`204`	`204`	`'webworker'`
`205`	`205`	`]`
`206`	`206`	`}`