Skip to content

Commit 3bcf31e

Browse files
committed
Remove createTime & readTime from DocumentSnapshot
These were added to the API before I knew they could have been queried internally.
1 parent ffff490 commit 3bcf31e

File tree

3 files changed

+0
-16
lines changed

3 files changed

+0
-16
lines changed

common/api-review/firestore-lite.api.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,14 +146,10 @@ export class DocumentReference<AppModelType = DocumentData, DbModelType extends
146146
// @public
147147
export class DocumentSnapshot<AppModelType = DocumentData, DbModelType extends DocumentData = DocumentData> {
148148
protected constructor();
149-
// (undocumented)
150-
get createTime(): Timestamp | undefined;
151149
data(): AppModelType | undefined;
152150
exists(): this is QueryDocumentSnapshot<AppModelType, DbModelType>;
153151
get(fieldPath: string | FieldPath): any;
154152
get id(): string;
155-
// (undocumented)
156-
get readTime(): Timestamp | undefined;
157153
get ref(): DocumentReference<AppModelType, DbModelType>;
158154
}
159155

common/api-review/firestore.api.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,15 +172,11 @@ export class DocumentReference<AppModelType = DocumentData, DbModelType extends
172172
// @public
173173
export class DocumentSnapshot<AppModelType = DocumentData, DbModelType extends DocumentData = DocumentData> {
174174
protected constructor();
175-
// (undocumented)
176-
get createTime(): Timestamp;
177175
data(options?: SnapshotOptions): AppModelType | undefined;
178176
exists(): this is QueryDocumentSnapshot<AppModelType, DbModelType>;
179177
get(fieldPath: string | FieldPath, options?: SnapshotOptions): any;
180178
get id(): string;
181179
readonly metadata: SnapshotMetadata;
182-
// (undocumented)
183-
get readTime(): Timestamp;
184180
get ref(): DocumentReference<AppModelType, DbModelType>;
185181
// (undocumented)
186182
toJSON(): object;

packages/firestore/src/lite-api/snapshot.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -330,14 +330,6 @@ export class DocumentSnapshot<
330330
);
331331
}
332332

333-
get createTime(): Timestamp | undefined {
334-
return this._document?.createTime.toTimestamp();
335-
}
336-
337-
get readTime(): Timestamp | undefined {
338-
return this._document?.readTime.toTimestamp();
339-
}
340-
341333
/**
342334
* Signals whether or not the document at the snapshot's location exists.
343335
*

0 commit comments

Comments
 (0)