minor changes

Author: Samruddhi90

packages/remote-config/src/client/eventEmitter.ts

@@ -17,6 +17,7 @@
 
 import { assert } from '@firebase/util';
 
+// TODO: Consolidate the Visibility monitoring API code into a shared utility function in firebase/util to be used by both packages/database and packages/remote-config.
 /**
  * Base class to be used if you want to emit events. Call the constructor with
  * the set of allowed event names.
@@ -65,6 +66,7 @@ export abstract class EventEmitter {
 
     const eventData = this.getInitialEvent(eventType);
     if (eventData) {
+      //@ts-ignore
       callback.apply(context, eventData);
     }
   }
@@ -92,4 +94,3 @@ export abstract class EventEmitter {
     );
   }
 }
-

packages/remote-config/src/client/realtime_handler.ts

@@ -323,23 +323,13 @@ export class RealtimeHandler {
     await this.beginRealtime();
   }
 
-  private abortRealtimeConnection(): void {
-    if (this.controller) {
-       this.controller.abort();
-       this.controller = undefined;
-       this.isConnectionActive = false;
-    }
-  }
-
-  private onVisibilityChange(visible: unknown) {
-    const wasInBackground = this.isInBackground;
+  private async onVisibilityChange(visible: unknown) {
     this.isInBackground = !visible;
-    if (wasInBackground !== this.isInBackground) {
-      if (this.isInBackground) {
-        this.abortRealtimeConnection();
-      } else {
-        this.beginRealtime();
-      }
+    if (!visible && this.controller) {
+      this.controller.abort();
+      this.controller = undefined;
+    } else if(visible) {
+      await this.beginRealtime();
     }
   }
 }

packages/remote-config/src/client/visibility_monitor.ts

@@ -21,6 +21,7 @@ import { EventEmitter } from './eventEmitter';
 
 declare const document: Document;
 
+// TODO: Consolidate the Visibility monitoring API code into a shared utility function in firebase/util to be used by both packages/database and packages/remote-config.
 export class VisibilityMonitor extends EventEmitter {
   private visible_: boolean;
 
@@ -40,13 +41,16 @@ export class VisibilityMonitor extends EventEmitter {
         // Opera 12.10 and Firefox 18 and later support
         visibilityChange = 'visibilitychange';
         hidden = 'hidden';
-      } else if (typeof document['mozHidden'] !== 'undefined') {
+      } //@ts-ignore
+      else if (typeof document['mozHidden'] !== 'undefined') {
         visibilityChange = 'mozvisibilitychange';
         hidden = 'mozHidden';
-      } else if (typeof document['msHidden'] !== 'undefined') {
+      } //@ts-ignore
+      else if (typeof document['msHidden'] !== 'undefined') {
         visibilityChange = 'msvisibilitychange';
         hidden = 'msHidden';
-      } else if (typeof document['webkitHidden'] !== 'undefined') {
+      } //@ts-ignore
+      else if (typeof document['webkitHidden'] !== 'undefined') {
         visibilityChange = 'webkitvisibilitychange';
         hidden = 'webkitHidden';
       }
@@ -58,10 +62,12 @@ export class VisibilityMonitor extends EventEmitter {
     // reconnects
     this.visible_ = true;
 
+    //@ts-ignore
     if (visibilityChange) {
       document.addEventListener(
         visibilityChange,
         () => {
+          //@ts-ignore
           const visible = !document[hidden];
           if (visible !== this.visible_) {
             this.visible_ = visible;
@@ -78,4 +84,3 @@ export class VisibilityMonitor extends EventEmitter {
     return [this.visible_];
   }
 }
-

packages/remote-config/tsconfig.json

@@ -2,8 +2,7 @@
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
-    "resolveJsonModule": true,
-    "strict": false
+    "resolveJsonModule": true
   },
   "exclude": ["dist/**/*"]
 }