revert firestore changes but upgrade to v4 of artifact

Author: dlarocque

.github/workflows/test-changed-firestore.yml

@@ -37,23 +37,17 @@ jobs:
         with:
           # This makes Actions fetch all Git history so run-changed script can diff properly.
           fetch-depth: 0
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: .nvmrc
       - name: install Chrome stable
         run: |
           sudo apt-get update
           sudo apt-get install google-chrome-stable
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
-          cache: yarn
-          cache-dependency-path: yarn.lock
-      - name: Restore cached node_modules
-        uses: actions/cache@v4
-        id: node_modules
-        with:
-          path: "**/node_modules"
-          key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
-      - run: yarn install --frozen-lockfile
-      - run: cp config/ci.config.json config/project.json
+      - name: Test setup and yarn install
+        run: |
+          cp config/ci.config.json config/project.json
+          yarn
       - name: build
         id: build
         run: |
@@ -70,12 +64,17 @@ jobs:
         if: steps.check-changed.outcome != 'success'
         id: set-output
         run: echo "CHANGED=true" >> "$GITHUB_OUTPUT";
+      - name: Archive build
+        if: ${{ !cancelled() && steps.build.outcome == 'success' && steps.check-changed.outcome != 'success' }}
+        run: |
+          tar -cf build.tar --exclude=.git .
+          gzip build.tar
       - name: Upload build archive
         if: ${{ !cancelled() && steps.build.outcome == 'success' && steps.check-changed.outcome != 'success' }}
         uses: actions/upload-artifact@v4
         with:
-          name: build-changed-firestore-${{ github.sha }}
-          path: .
+          name: build-${{ github.sha }}
+          path: build.tar.gz
           retention-days: ${{ env.artifactRetentionDays }}
 
   compat-test-chrome:
@@ -84,18 +83,21 @@ jobs:
     needs: build
     if: ${{ needs.build.outputs.changed == 'true'}}
     steps:
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: .nvmrc
       - name: install Chrome stable
         run: |
           sudo apt-get update
           sudo apt-get install google-chrome-stable
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
       - name: Download build archive
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
-          name: build-changed-firestore-${{ github.sha }}
+          name: build-${{ github.sha }}
+      - name: Unzip build artifact
+        run: tar xf build.tar.gz
+      - name: Test setup and yarn install
+        run: cp config/ci.config.json config/project.json
       - name: Run compat tests
         run: cd packages/firestore-compat && yarn run test:ci
 
@@ -108,18 +110,21 @@ jobs:
     needs: build
     if: ${{ needs.build.outputs.changed == 'true'}}
     steps:
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: .nvmrc
       - name: install Chrome stable
         run: |
           sudo apt-get update
           sudo apt-get install google-chrome-stable
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
       - name: Download build archive
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
-          name: build-changed-firestore-${{ github.sha }}
+          name: build-${{ github.sha }}
+      - name: Unzip build artifact
+        run: tar xf build.tar.gz
+      - name: Test setup and yarn install
+        run: cp config/ci.config.json config/project.json
       - name: Run tests
         run: cd packages/firestore && yarn run ${{ matrix.test-name }}
         env:
@@ -134,18 +139,19 @@ jobs:
     needs: build
     if: ${{ github.event_name != 'pull_request' }}
     steps:
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: .nvmrc
       - name: install Chrome stable
         run: |
           sudo apt-get update
           sudo apt-get install google-chrome-stable
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
       - name: Download build archive
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
-          name: build-changed-firestore-${{ github.sha }}
+          name: build-${{ github.sha }}
+      - name: Unzip build artifact
+        run: tar xf build.tar.gz
       - name: Test setup against nightly Firestore
         env:
           INTEG_TESTS_GOOGLE_SERVICES: ${{ secrets.FIRESTORE_SDK_NIGHTLY_PROJECT_JSON }}
@@ -170,14 +176,17 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install firefox
-      - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version-file: '.nvmrc'
+          node-version-file: .nvmrc
       - name: Download build archive
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
-          name: build-changed-firestore-${{ github.sha }}
+          name: build-${{ github.sha }}
+      - name: Unzip build artifact
+        run: tar xf build.tar.gz
+      - name: Test setup and yarn install
+        run: cp config/ci.config.json config/project.json
       - name: Run compat tests
         run: cd packages/firestore-compat && xvfb-run yarn run test:ci
         env:
@@ -200,12 +209,16 @@ jobs:
           sudo apt-get update
           sudo apt-get install firefox
       - name: Download build archive
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
-          name: build-changed-firestore-${{ github.sha }}
+          name: build-${{ github.sha }}
+      - name: Unzip build artifact
+        run: tar xf build.tar.gz
       - uses: actions/setup-node@v4
         with:
-          node-version-file: '.nvmrc'
+          node-version-file: .nvmrc
+      - name: Test setup and yarn install
+        run: cp config/ci.config.json config/project.json
       - name: Run tests
         run: cd packages/firestore && xvfb-run yarn run ${{ matrix.test-name }}
         env:
@@ -220,12 +233,17 @@ jobs:
     steps:
       - uses: actions/setup-node@v4
         with:
-          node-version-file: '.nvmrc'
+          node-version-file: .nvmrc
       - name: Download build archive
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
-          name: build-changed-firestore-${{ github.sha }}
-      - run: npx playwright install webkit
+          name: build-${{ github.sha }}
+      - name: Unzip build artifact
+        run: tar xf build.tar.gz
+      - name: Test setup
+        run: |
+          cp config/ci.config.json config/project.json
+          npx playwright install webkit
       - name: Run compat tests
         run: cd packages/firestore-compat && yarn run test:ci
         env:
@@ -243,16 +261,19 @@ jobs:
     needs: build
     if: ${{ needs.build.outputs.changed == 'true'}}
     steps:
-      - uses: actions/checkout@v4
       - name: Download build archive
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
-          name: build-changed-firestore-${{ github.sha }}
+          name: build-${{ github.sha }}
+      - name: Unzip build artifact
+        run: tar xf build.tar.gz
       - uses: actions/setup-node@v4
         with:
-          node-version-file: '.nvmrc'
-      - run: cp config/ci.config.json config/project.json
-      - run: npx playwright install webkit
+          node-version-file: .nvmrc
+      - name: Test setup
+        run: |
+          cp config/ci.config.json config/project.json
+          npx playwright install webkit
       - name: Run tests
         run: cd packages/firestore && yarn run ${{ matrix.test-name }}
         env: