PR feedback - error? to Error | undefined

MarkDuckworth · MarkDuckworth · commit 4714c7a3772b · 2025-08-18T12:58:58.000-06:00
diff --git a/packages/firestore/src/core/transaction_runner.ts b/packages/firestore/src/core/transaction_runner.ts
@@ -112,7 +112,7 @@ export class TransactionRunner<T> {
     }
   }
 
-  private isRetryableTransactionError(error?: Error): boolean {
+  private isRetryableTransactionError(error: Error | undefined): boolean {
     if (error?.name === 'FirebaseError') {
       // In transactions, the backend will fail outdated reads with FAILED_PRECONDITION and
       // non-matching document versions with ABORTED. These errors should be retried.

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ export class TransactionRunner<T> {`
`112`	`112`	`}`
`113`	`113`	`}`
`114`	`114`
`115`		`- private isRetryableTransactionError(error?: Error): boolean {`
	`115`	`+ private isRetryableTransactionError(error: Error \| undefined): boolean {`
`116`	`116`	`if (error?.name === 'FirebaseError') {`
`117`	`117`	`// In transactions, the backend will fail outdated reads with FAILED_PRECONDITION and`
`118`	`118`	`// non-matching document versions with ABORTED. These errors should be retried.`