local store tests PASS

Author: wu-hui

packages/firestore/src/core/pipeline_run.ts

@@ -234,7 +234,7 @@ function evaluateDocuments(
   return input.filter(input => {
     return (
       input.isFoundDocument() &&
-      stage.docPaths.includes(input.key.path.canonicalString())
+      stage.docPaths.includes(input.key.path.toStringWithLeadingSlash())
     );
   });
 }

packages/firestore/src/local/local_store_impl.ts

@@ -952,24 +952,6 @@ export function localStoreAllocateTarget(
   target: Target | Pipeline
 ): Promise<TargetData> {
   const localStoreImpl = debugCast(localStore, LocalStoreImpl);
-  if (targetIsPipelineTarget(target)) {
-    return localStoreImpl.persistence.runTransaction(
-      'Allocate pipeline target',
-      'readwrite',
-      txn => {
-        return localStoreImpl.targetCache
-          .allocateTargetId(txn)
-          .next(targetId => {
-            return new TargetData(
-              target,
-              targetId,
-              TargetPurpose.Listen,
-              txn.currentSequenceNumber
-            );
-          });
-      }
-    );
-  }
 
   return localStoreImpl.persistence
     .runTransaction('Allocate target', 'readwrite', txn => {

packages/firestore/src/local/memory_persistence.ts

@@ -298,7 +298,7 @@ export class MemoryEagerDelegate implements MemoryReferenceDelegate {
     const changeBuffer = cache.newChangeBuffer();
     return PersistencePromise.forEach(
       this.orphanedDocuments,
-      (path: string) => {
+      (path: string): PersistencePromise<void> => {
         const key = DocumentKey.fromPath(path);
         return this.isReferenced(txn, key).next(isReferenced => {
           if (!isReferenced) {

packages/firestore/src/model/path.ts

@@ -217,6 +217,10 @@ export class ResourcePath extends BasePath<ResourcePath> {
     return this.canonicalString();
   }
 
+  toStringWithLeadingSlash(): string {
+    return `/${this.canonicalString()}`;
+  }
+
   /**
    * Returns a string representation of this path
    * where each path segment has been encoded with