Formatting and minor fixes

Author: dlarocque

packages/auth/rollup.config.js

@@ -181,8 +181,8 @@ const webWorkerBuild = {
   input: 'index.webworker.ts',
   output: {
     file: pkg.webworker,
-    format: 'es', 
-    sourcemap: true 
+    format: 'es',
+    sourcemap: true
   },
   plugins: [
     json(),

packages/firestore/rollup.config.js

@@ -67,7 +67,7 @@ const allBuilds = [
       format: 'es',
       sourcemap: true
     },
-    plugins: [alias(util.generateAliasConfig('node')), ...nodePlugins()],
+    plugins: [alias(util.generateAliasConfig('node')), ...nodePlugins],
     external: util.resolveNodeExterns,
     treeshake: {
       moduleSideEffects: false
@@ -128,7 +128,7 @@ const allBuilds = [
       format: 'es',
       sourcemap: true
     },
-    plugins: [alias(util.generateAliasConfig('browser')), ...browserPlugins()],
+    plugins: [alias(util.generateAliasConfig('browser')), ...browserPlugins],
     external: util.resolveBrowserExterns,
     treeshake: {
       moduleSideEffects: false
@@ -182,7 +182,7 @@ const allBuilds = [
     },
     plugins: [
       alias(util.generateAliasConfig('rn')),
-      ...browserPlugins(),
+      ...browserPlugins,
       replace(generateBuildTargetReplaceConfig('esm', 2017))
     ],
     external: util.resolveBrowserExterns,

packages/messaging-compat/rollup.config.js

@@ -32,18 +32,16 @@ const buildPlugins = [
   json({ preferConst: true })
 ];
 
-const esmBuild = [
-  {
-    input: 'src/index.ts',
-    output: {
-      file: pkg.browser,
-      format: 'es',
-      sourcemap: true
-    },
-    plugins: [...buildPlugins, emitModulePackageFile()],
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
-  }
-];
+const esmBuild = {
+  input: 'src/index.ts',
+  output: {
+    file: pkg.browser,
+    format: 'es',
+    sourcemap: true
+  },
+  plugins: [...buildPlugins, emitModulePackageFile()],
+  external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
+}
 
 const cjsBuild = {
   input: 'src/index.ts',

packages/messaging/rollup.config.js

@@ -70,7 +70,10 @@ const cjsBuilds = [
       format: 'cjs',
       sourcemap: true
     },
-    plugins: [...build, replace(generateBuildTargetReplaceConfig('cjs', 2017))],
+    plugins: [
+      ...buildPlugins,
+      replace(generateBuildTargetReplaceConfig('cjs', 2017))
+    ],
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
   },
   // sw build

packages/performance/rollup.config.js

@@ -45,20 +45,18 @@ const esmBuild = {
   ]
 };
 
-const cjsBuilds = [
-  {
-    input: 'src/index.ts',
-    output: {
-      file: pkg.main,
-      format: 'cjs',
-      sourcemap: true
-    },
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
-    plugins: [
-      ...buildPlugins,
-      replace(generateBuildTargetReplaceConfig('cjs', 5))
-    ]
-  }
-];
+const cjsBuild = {
+  input: 'src/index.ts',
+  output: {
+    file: pkg.main,
+    format: 'cjs',
+    sourcemap: true
+  },
+  external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
+  plugins: [
+    ...buildPlugins,
+    replace(generateBuildTargetReplaceConfig('cjs', 5))
+  ]
+}
 
 export default [esmBuild, cjsBuild];

packages/remote-config-compat/rollup.config.js

@@ -39,30 +39,26 @@ const buildPlugins = [
   })
 ];
 
-const esmBuild = [
-  {
-    input: 'src/index.ts',
-    output: {
-      file: pkg.browser,
-      format: 'es',
-      sourcemap: true
-    },
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
-    plugins: [...buildPlugins, emitModulePackageFile()]
-  }
-];
+const esmBuild = {
+  input: 'src/index.ts',
+  output: {
+    file: pkg.browser,
+    format: 'es',
+    sourcemap: true
+  },
+  external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
+  plugins: [...buildPlugins, emitModulePackageFile()]
+}
 
-const cjsBuild = [
-  {
-    input: 'src/index.ts',
-    output: {
-      file: pkg.main,
-      format: 'cjs',
-      sourcemap: true
-    },
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
-    plugins: buildPlugins
-  }
-];
+const cjsBuild = {
+  input: 'src/index.ts',
+  output: {
+    file: pkg.main,
+    format: 'cjs',
+    sourcemap: true
+  },
+  external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
+  plugins: buildPlugins
+}
 
 export default [esmBuild, cjsBuild];

packages/storage-compat/rollup.config.js

@@ -38,30 +38,26 @@ const buildPlugins = [
   json({ preferConst: true })
 ];
 
-const esmBuild = [
-  {
-    input: './src/index.ts',
-    output: {
-      file: pkg.browser,
-      format: 'es',
-      sourcemap: true
-    },
-    plugins: [...buildPlugins, emitModulePackageFile()],
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
-  }
-];
+const esmBuild = {
+  input: './src/index.ts',
+  output: {
+    file: pkg.browser,
+    format: 'es',
+    sourcemap: true
+  },
+  plugins: [...buildPlugins, emitModulePackageFile()],
+  external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
+}
 
-const cjsBuild = [
-  {
-    input: './src/index.ts',
-    output: {
-      file: pkg.main,
-      format: 'cjs',
-      sourcemap: true
-    },
-    plugins: buildPlugins,
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
-  }
-];
+const cjsBuild = {
+  input: './src/index.ts',
+  output: {
+    file: pkg.main,
+    format: 'cjs',
+    sourcemap: true
+  },
+  plugins: buildPlugins,
+  external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
+}
 
 export default [esmBuild, cjsBuild];

scripts/size_report/report_binary_size.ts

@@ -120,7 +120,7 @@ async function collectBinarySize(pkg: string): Promise<Report[]> {
     'browser',
     'react-native',
     'cordova',
-    'lite',
+    'lite'
   ];
   const json = require(pkg);
   for (const field of fields) {