Address review comments

Author: Athira M

packages/remote-config/src/abt/experiment.ts

@@ -18,10 +18,12 @@ import { Storage } from '../storage/storage';
 import { FirebaseExperimentDescription } from '../public_types';
 import { Provider } from '@firebase/component';
 import { FirebaseAnalyticsInternalName } from '@firebase/analytics-interop-types';
+import { Logger } from '@firebase/logger';
 
 export class Experiment {
   constructor(
     private readonly storage: Storage,
+    private readonly logger: Logger,
     private readonly analyticsProvider: Provider<FirebaseAnalyticsInternalName>
   ) {}
 
@@ -76,10 +78,14 @@ export class Experiment {
     customProperty: Record<string, string | null>
   ): Promise<void> {
     try {
-      const analytics = await this.analyticsProvider.get();
-      analytics.setUserProperties({ properties: customProperty });
+      const analytics = this.analyticsProvider.getImmediate({ optional: true });
+      if (analytics) {
+        analytics.setUserProperties({ properties: customProperty });
+      } else {
+        this.logger.warn(`Analytics is not imported correctly`);
+      }
     } catch (error) {
-      console.error(`Failed to add experiment to analytics :`, error);
+      this.logger.error(`Failed to add experiment to analytics : ${error}`);
       return;
     }
   }

packages/remote-config/src/api.ts

@@ -111,7 +111,11 @@ export async function activate(remoteConfig: RemoteConfig): Promise<boolean> {
     // config.
     return false;
   }
-  const experiment = new Experiment(rc._storage, rc._analyticsProvider);
+  const experiment = new Experiment(
+    rc._storage,
+    rc._logger,
+    rc._analyticsProvider
+  );
   const updateActiveExperiments = lastSuccessfulFetchResponse.experiments
     ? experiment.updateActiveExperiments(
         lastSuccessfulFetchResponse.experiments

packages/remote-config/test/abt/experiment.test.ts

@@ -22,11 +22,13 @@ import { FirebaseExperimentDescription } from '../../src/public_types';
 import { Storage } from '../../src/storage/storage';
 import { Provider } from '@firebase/component';
 import { FirebaseAnalyticsInternalName } from '@firebase/analytics-interop-types';
+import { Logger } from '@firebase/logger';
 
 describe('Experiment', () => {
   const storage = {} as Storage;
   const analyticsProvider = {} as Provider<FirebaseAnalyticsInternalName>;
-  const experiment = new Experiment(storage, analyticsProvider);
+  const logger = {} as Logger;
+  const experiment = new Experiment(storage, logger, analyticsProvider);
 
   describe('updateActiveExperiments', () => {
     beforeEach(() => {