resolving the spacing problem

Author: Samruddhi90

packages/remote-config/src/client/eventEmitter.ts

@@ -48,7 +48,7 @@ export abstract class EventEmitter {
   /**
    * To be called by derived classes to trigger events.
    */
-  protected trigger(eventType: string, ...varArgs: unknown[]) {
+  protected trigger(eventType: string, ...varArgs: unknown[]): void {
     if (Array.isArray(this.listeners_[eventType])) {
       // Clone the list, since callbacks could add/remove listeners.
       const listeners = [...this.listeners_[eventType]];
@@ -59,7 +59,11 @@ export abstract class EventEmitter {
     }
   }
 
-  on(eventType: string, callback: (a: unknown) => void, context: unknown) {
+  on(
+    eventType: string,
+    callback: (a: unknown) => void,
+    context: unknown
+  ): void {
     this.validateEventType_(eventType);
     this.listeners_[eventType] = this.listeners_[eventType] || [];
     this.listeners_[eventType].push({ callback, context });
@@ -71,7 +75,11 @@ export abstract class EventEmitter {
     }
   }
 
-  off(eventType: string, callback: (a: unknown) => void, context: unknown) {
+  off(
+    eventType: string,
+    callback: (a: unknown) => void,
+    context: unknown
+  ): void {
     this.validateEventType_(eventType);
     const listeners = this.listeners_[eventType] || [];
     for (let i = 0; i < listeners.length; i++) {
@@ -85,7 +93,7 @@ export abstract class EventEmitter {
     }
   }
 
-  private validateEventType_(eventType: string) {
+  private validateEventType_(eventType: string): void {
     assert(
       this.allowedEvents_.find(et => {
         return et === eventType;

packages/remote-config/src/client/realtime_handler.ts

@@ -41,7 +41,11 @@ export class RealtimeHandler {
     private readonly logger: Logger
   ) {
     void this.setRetriesRemaining();
-    VisibilityMonitor.getInstance().on('visible', this.onVisibilityChange, this);
+    void VisibilityMonitor.getInstance().on(
+      'visible',
+      this.onVisibilityChange,
+      this
+    );
   }
 
   private observers: Set<ConfigUpdateObserver> =
@@ -106,8 +110,8 @@ export class RealtimeHandler {
    */
   private closeRealtimeHttpConnection(): void {
     if (this.controller && !this.isInBackground) {
-       this.controller.abort();
-       this.controller = undefined;
+      this.controller.abort();
+      this.controller = undefined;
     }
 
     if (this.reader) {
@@ -269,11 +273,11 @@ export class RealtimeHandler {
         // this as a success, even if we haven't read a 200 response code yet.
         this.resetRetryCount();
       } else {
-      //there might have been a transient error so the client will retry the connection.
-      this.logger.error(
-        'Exception connecting to real-time RC backend. Retrying the connection...:',
-        error
-      );
+        //there might have been a transient error so the client will retry the connection.
+        this.logger.debug(
+          'Exception connecting to real-time RC backend. Retrying the connection...:',
+          error
+        );
       }
     } finally {
       // Close HTTP connection and associated streams.
@@ -315,9 +319,14 @@ export class RealtimeHandler {
     const isNotDisabled = !this.isRealtimeDisabled;
     const isNoConnectionActive = !this.isConnectionActive;
     const inForeground = !this.isInBackground;
-    return hasActiveListeners && isNotDisabled && isNoConnectionActive && inForeground;
+    return (
+      hasActiveListeners &&
+      isNotDisabled &&
+      isNoConnectionActive &&
+      inForeground
+    );
   }
-  
+
   private async makeRealtimeHttpConnection(delayMillis: number): Promise<void> {
     if (!this.canEstablishStreamConnection()) {
       return;
@@ -328,7 +337,10 @@ export class RealtimeHandler {
         await this.beginRealtimeHttpStream();
       }, delayMillis);
     } else if (!this.isInBackground) {
-      const error = ERROR_FACTORY.create(ErrorCode.CONFIG_UPDATE_STREAM_ERROR, { originalErrorMessage: 'Unable to connect to the server. Check your connection and try again.' });
+      const error = ERROR_FACTORY.create(ErrorCode.CONFIG_UPDATE_STREAM_ERROR, {
+        originalErrorMessage:
+          'Unable to connect to the server. Check your connection and try again.'
+      });
       this.propagateError(error);
     }
   }
@@ -358,12 +370,12 @@ export class RealtimeHandler {
     }
   }
 
-  private async onVisibilityChange(visible: unknown) {
+  private async onVisibilityChange(visible: unknown): Promise<void> {
     this.isInBackground = !visible;
     if (!visible && this.controller) {
       this.controller.abort();
       this.controller = undefined;
-    } else if(visible) {
+    } else if (visible) {
       await this.beginRealtime();
     }
   }

packages/remote-config/src/client/visibility_monitor.ts

@@ -25,7 +25,7 @@ declare const document: Document;
 export class VisibilityMonitor extends EventEmitter {
   private visible_: boolean;
 
-  static getInstance() {
+  static getInstance(): VisibilityMonitor {
     return new VisibilityMonitor();
   }
 
@@ -41,15 +41,15 @@ export class VisibilityMonitor extends EventEmitter {
         // Opera 12.10 and Firefox 18 and later support
         visibilityChange = 'visibilitychange';
         hidden = 'hidden';
-      } //@ts-ignore
+      } // @ts-ignore
       else if (typeof document['mozHidden'] !== 'undefined') {
         visibilityChange = 'mozvisibilitychange';
         hidden = 'mozHidden';
-      } //@ts-ignore
+      } // @ts-ignore
       else if (typeof document['msHidden'] !== 'undefined') {
         visibilityChange = 'msvisibilitychange';
         hidden = 'msHidden';
-      } //@ts-ignore
+      } // @ts-ignore
       else if (typeof document['webkitHidden'] !== 'undefined') {
         visibilityChange = 'webkitvisibilitychange';
         hidden = 'webkitHidden';
@@ -62,12 +62,12 @@ export class VisibilityMonitor extends EventEmitter {
     // reconnects
     this.visible_ = true;
 
-    //@ts-ignore
+    // @ts-ignore
     if (visibilityChange) {
       document.addEventListener(
         visibilityChange,
         () => {
-          //@ts-ignore
+          // @ts-ignore
           const visible = !document[hidden];
           if (visible !== this.visible_) {
             this.visible_ = visible;