Skip to content

Commit 629d70b

Browse files
committed
Removed repo-scripts changes
1 parent 64eff34 commit 629d70b

File tree

16 files changed

+65
-42
lines changed

16 files changed

+65
-42
lines changed

repo-scripts/api-documenter/src/documenters/IConfigFile.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
// See LICENSE in the project root for license information.
2020

2121
/**
22-
* TypeScript interface describing the config schema for toc.yml file format.
22+
* Typescript interface describing the config schema for toc.yml file format.
2323
*/
2424
export interface IConfigTableOfContents {
2525
/**

repo-scripts/changelog-generator/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"@changesets/types": "3.3.0",
2121
"@changesets/get-github-info": "0.5.2",
2222
"@types/node": "20.8.10",
23-
"undici": "6.19.7"
23+
"undici": "5.28.4"
2424
},
2525
"license": "Apache-2.0",
2626
"devDependencies": {

repo-scripts/prune-dts/extract-public-api.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const baseApiExtractorConfigFile: string = path.resolve(
3838
const reportFolder = path.resolve(__dirname, '../../common/api-review');
3939
const tmpDir = tmp.dirSync().name;
4040

41-
function writeTypeScriptConfig(packageRoot: string): void {
41+
function writeTypescriptConfig(packageRoot: string): void {
4242
const tsConfigJson = {
4343
extends: path.resolve(packageRoot, './tsconfig.json'),
4444
include: [path.resolve(packageRoot, './src')],
@@ -125,7 +125,7 @@ function loadApiExtractorConfig(
125125
* @param packageName - The name of the Firebase package (e.g. "database" or
126126
* "firestore-lite")
127127
* @param packageRoot - The root path of the package
128-
* @param typescriptDtsPath - The .d.ts file generated by the TypeScript
128+
* @param typescriptDtsPath - The .d.ts file generated by the Typescript
129129
* compiler as we transpile our sources
130130
* @param rollupDtsPath - A "bundled" version of our d.ts files that includes
131131
* all public and private types
@@ -144,7 +144,7 @@ export async function generateApi(
144144
publicDtsPath: string
145145
): Promise<void> {
146146
console.log(`Configuring API Extractor for ${packageName}`);
147-
writeTypeScriptConfig(packageRoot);
147+
writeTypescriptConfig(packageRoot);
148148
writePackageJson(packageName);
149149

150150
let extractorConfig = loadApiExtractorConfig(
@@ -156,9 +156,7 @@ export async function generateApi(
156156
/* apiReportEnabled= */ false
157157
);
158158
Extractor.invoke(extractorConfig, {
159-
localBuild: true,
160-
showDiagnostics: true,
161-
showVerboseMessages: true
159+
localBuild: true
162160
});
163161

164162
console.log('Generated rollup DTS');
@@ -198,7 +196,7 @@ const argv = yargs
198196
typescriptDts: {
199197
type: 'string',
200198
desc:
201-
'The .d.ts file generated by the TypeScript compiler as we transpile ' +
199+
'The .d.ts file generated by the Typescript compiler as we transpile ' +
202200
'our sources',
203201
require: true
204202
},

repo-scripts/prune-dts/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
},
1414
"license": "Apache-2.0",
1515
"dependencies": {
16-
"eslint": "8.56.0",
17-
"eslint-plugin-unused-imports": "3.2.0",
16+
"eslint": "7.32.0",
17+
"eslint-plugin-unused-imports": "2.0.0",
1818
"prettier": "2.8.7"
1919
},
2020
"repository": {

repo-scripts/prune-dts/prune-dts.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export async function removeUnusedImports(
108108

109109
/** Determines whether the provided identifier should be hidden. */
110110
function hasPrivatePrefix(name: ts.Identifier): boolean {
111-
// Identifiers that are prefixed with an underscore are not included in
111+
// Identifiers that are prefixed with an underscore are not not included in
112112
// the public API.
113113
return !!name.escapedText?.toString().startsWith('_');
114114
}
@@ -123,11 +123,11 @@ function isExported(
123123
typeChecker.getSymbolAtLocation(name)?.declarations ?? [];
124124

125125
// Check is this is a public symbol (e.g. part of the DOM library)
126-
const isTypeScriptType = declarations.find(
126+
const isTypescriptType = declarations.find(
127127
d => d.getSourceFile().fileName.indexOf('typescript/lib') != -1
128128
);
129129
const isImported = declarations.find(d => ts.isImportSpecifier(d));
130-
if (isTypeScriptType || isImported) {
130+
if (isTypescriptType || isImported) {
131131
return true;
132132
}
133133

@@ -141,8 +141,8 @@ function isExported(
141141
/**
142142
* Replaces an existing constructor implementation if the constructor is marked
143143
* with the JSDod tag `@hideconstructor`. The replaced constructor can either
144-
* have `private` visibility` or `protected`. To generate a protected
145-
* constructor, specify `@hideconstructor protected`.
144+
* have `private` visibility` or `proctected`. To generate a protected
145+
* constructor, specify `@hideconstructor proctected`.
146146
*
147147
* Returns either the modified constructor or the existing constructor if no
148148
* modification was needed.

repo-scripts/prune-dts/tests/firestore.input.d.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ export declare function collection(
464464

465465
/**
466466
* Gets a `CollectionReference` instance that refers to a subcollection of
467-
* `reference` at the specified relative path.
467+
* `reference` at the the specified relative path.
468468
*
469469
* @param reference - A reference to a collection.
470470
* @param path - A slash-separated path to a collection.
@@ -482,7 +482,7 @@ export declare function collection(
482482

483483
/**
484484
* Gets a `CollectionReference` instance that refers to a subcollection of
485-
* `reference` at the specified relative path.
485+
* `reference` at the the specified relative path.
486486
*
487487
* @param reference - A reference to a Firestore document.
488488
* @param path - A slash-separated path to a collection.
@@ -794,7 +794,7 @@ export declare function disableNetwork(
794794

795795
/**
796796
* Gets a `DocumentReference` instance that refers to the document at the
797-
* specified absolute path.
797+
* specified abosulute path.
798798
*
799799
* @param firestore - A reference to the root Firestore instance.
800800
* @param path - A slash-separated path to a document.
@@ -818,7 +818,7 @@ export declare function doc(
818818
*
819819
* @param reference - A reference to a collection.
820820
* @param path - A slash-separated path to a document. Has to be omitted to use
821-
* auto-generated IDs.
821+
* auto-genrated IDs.
822822
* @param pathSegments - Additional path segments that will be applied relative
823823
* to the first argument.
824824
* @throws If the final path has an odd number of segments and does not point to
@@ -1643,14 +1643,14 @@ export declare interface FirestoreDataConverter<T>
16431643
declare interface FirestoreDataConverter_2<T> {
16441644
/**
16451645
* Called by the Firestore SDK to convert a custom model object of type `T`
1646-
* into a plain JavaScript object (suitable for writing directly to the
1646+
* into a plain Javascript object (suitable for writing directly to the
16471647
* Firestore database). Used with {@link setData}, {@link WriteBatch#set}
16481648
* and {@link Transaction#set}.
16491649
*/
16501650
toFirestore(modelObject: T): DocumentData;
16511651
/**
16521652
* Called by the Firestore SDK to convert a custom model object of type `T`
1653-
* into a plain JavaScript object (suitable for writing directly to the
1653+
* into a plain Javascript object (suitable for writing directly to the
16541654
* Firestore database). Used with {@link setData}, {@link WriteBatch#set}
16551655
* and {@link Transaction#set} with `merge:true` or `mergeFields`.
16561656
*/

repo-scripts/prune-dts/tests/firestore.output.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ export declare function collection(
154154
): CollectionReference<DocumentData>;
155155
/**
156156
* Gets a `CollectionReference` instance that refers to a subcollection of
157-
* `reference` at the specified relative path.
157+
* `reference` at the the specified relative path.
158158
*
159159
* @param reference - A reference to a collection.
160160
* @param path - A slash-separated path to a collection.
@@ -171,7 +171,7 @@ export declare function collection(
171171
): CollectionReference<DocumentData>;
172172
/**
173173
* Gets a `CollectionReference` instance that refers to a subcollection of
174-
* `reference` at the specified relative path.
174+
* `reference` at the the specified relative path.
175175
*
176176
* @param reference - A reference to a Firestore document.
177177
* @param path - A slash-separated path to a collection.
@@ -262,7 +262,7 @@ export declare function disableNetwork(
262262
): Promise<void>;
263263
/**
264264
* Gets a `DocumentReference` instance that refers to the document at the
265-
* specified absolute path.
265+
* specified abosulute path.
266266
*
267267
* @param firestore - A reference to the root Firestore instance.
268268
* @param path - A slash-separated path to a document.
@@ -285,7 +285,7 @@ export declare function doc(
285285
*
286286
* @param reference - A reference to a collection.
287287
* @param path - A slash-separated path to a document. Has to be omitted to use
288-
* auto-generated IDs.
288+
* auto-genrated IDs.
289289
* @param pathSegments - Additional path segments that will be applied relative
290290
* to the first argument.
291291
* @throws If the final path has an odd number of segments and does not point to
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
/**
2+
* @license
3+
* Copyright 2020 Google LLC
4+
*
5+
* Licensed under the Apache License, Version 2.0 (the "License");
6+
* you may not use this file except in compliance with the License.
7+
* You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
18+
declare class A<T> {
19+
a: T;
20+
}
21+
export class B<T> extends A<string> {
22+
b: T;
23+
}
24+
export class C<T> extends A<T> {}
25+
export {};

repo-scripts/size-analysis/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ $firebase-js-sdk/repo-scripts/size-analysis `ts-node-script cli.ts -o <path to
2828
$firebase-js-sdk/repo-scripts/size-analysis `ts-node-script cli.ts --if <path to dts file> --ib <path to bundle file> -o <path to output FILE>`
2929

3030

31-
### Use the Tool Programmatically
31+
### Use the Tool Programatically
3232
### `async generateReportForModule(moduleLocation: string): Promise<Report>`
3333
#### This function generates size analysis report for the given module specified by the `moduleLocation` argument.
3434
#### `@param moduleLocation: an absolute path to location of a firebase module`
3535
```
3636
try {
37-
const moduleLocation: string = "absolute/path/to/firebase/module";
37+
const moduleLocation: string = "absoulte/path/to/firebase/module";
3838
const report: Report = await generateReportForModule(moduleLocation);
3939
console.log(report);
4040

repo-scripts/size-analysis/bundle-analysis.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export async function run({
102102
function loadBundleDefinitions(path: string): BundleDefinition[] {
103103
if (!existsSync(path)) {
104104
throw new Error(
105-
`${path} doesn't exist. Please provide a valid path to the bundle definition file.`
105+
`${path} doesn't exist. Please provide a valid path to the bundle defintion file.`
106106
);
107107
}
108108

0 commit comments

Comments
 (0)