Skip to content

Commit 638f890

Browse files
committed
Format
1 parent 519e9da commit 638f890

File tree

3 files changed

+23
-10
lines changed

3 files changed

+23
-10
lines changed

packages/telemetry/src/api.test.ts

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,10 @@ import {
3535
import { Component, ComponentType } from '@firebase/component';
3636
import { FirebaseAppCheckInternal } from '@firebase/app-check-interop-types';
3737
import { captureError, flush, getTelemetry } from './api';
38-
import { LOG_ENTRY_ATTRIBUTE_KEYS, TELEMETRY_SESSION_ID_KEY } from './constants';
38+
import {
39+
LOG_ENTRY_ATTRIBUTE_KEYS,
40+
TELEMETRY_SESSION_ID_KEY
41+
} from './constants';
3942
import { TelemetryService } from './service';
4043
import { registerTelemetry } from './register';
4144
import { _FirebaseInstallationsInternal } from '@firebase/installations';
@@ -296,16 +299,16 @@ describe('Top level API', () => {
296299

297300
expect(emittedLogs.length).to.equal(1);
298301
const log = emittedLogs[0];
299-
expect(log.attributes![LOG_ENTRY_ATTRIBUTE_KEYS.SESSION_ID]).to.equal('new-session-id');
300-
expect(storage[TELEMETRY_SESSION_ID_KEY]).to.equal(
302+
expect(log.attributes![LOG_ENTRY_ATTRIBUTE_KEYS.SESSION_ID]).to.equal(
301303
'new-session-id'
302304
);
305+
expect(storage[TELEMETRY_SESSION_ID_KEY]).to.equal('new-session-id');
303306
});
304307

305308
it('should retrieve existing session ID from sessionStorage', () => {
306309
const sessionStorageMock = {
307310
getItem: () => 'existing-session-id',
308-
setItem: () => { }
311+
setItem: () => {}
309312
};
310313
const cryptoMock = {
311314
randomUUID: () => 'new-session-id'
@@ -324,15 +327,17 @@ describe('Top level API', () => {
324327

325328
expect(emittedLogs.length).to.equal(1);
326329
const log = emittedLogs[0];
327-
expect(log.attributes![LOG_ENTRY_ATTRIBUTE_KEYS.SESSION_ID]).to.equal('existing-session-id');
330+
expect(log.attributes![LOG_ENTRY_ATTRIBUTE_KEYS.SESSION_ID]).to.equal(
331+
'existing-session-id'
332+
);
328333
});
329334

330335
it('should handle errors when accessing sessionStorage', () => {
331336
const sessionStorageMock = {
332337
getItem: () => {
333338
throw new Error('SecurityError');
334339
},
335-
setItem: () => { }
340+
setItem: () => {}
336341
};
337342

338343
Object.defineProperty(global, 'sessionStorage', {
@@ -344,7 +349,8 @@ describe('Top level API', () => {
344349

345350
expect(emittedLogs.length).to.equal(1);
346351
const log = emittedLogs[0];
347-
expect(log.attributes![LOG_ENTRY_ATTRIBUTE_KEYS.SESSION_ID]).to.be.undefined;
352+
expect(log.attributes![LOG_ENTRY_ATTRIBUTE_KEYS.SESSION_ID]).to.be
353+
.undefined;
348354
});
349355
});
350356
});

packages/telemetry/src/api.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@
1616
*/
1717

1818
import { _getProvider, FirebaseApp, getApp } from '@firebase/app';
19-
import { LOG_ENTRY_ATTRIBUTE_KEYS, TELEMETRY_SESSION_ID_KEY, TELEMETRY_TYPE } from './constants';
19+
import {
20+
LOG_ENTRY_ATTRIBUTE_KEYS,
21+
TELEMETRY_SESSION_ID_KEY,
22+
TELEMETRY_TYPE
23+
} from './constants';
2024
import { Telemetry, TelemetryOptions } from './public-types';
2125
import { Provider } from '@firebase/component';
2226
import { AnyValueMap, SeverityNumber } from '@opentelemetry/api-logs';
@@ -101,7 +105,10 @@ export function captureError(
101105
customAttributes[LOG_ENTRY_ATTRIBUTE_KEYS.APP_VERSION] = appVersion;
102106

103107
// Add session ID metadata
104-
if (typeof sessionStorage !== 'undefined' && typeof crypto?.randomUUID === 'function') {
108+
if (
109+
typeof sessionStorage !== 'undefined' &&
110+
typeof crypto?.randomUUID === 'function'
111+
) {
105112
try {
106113
let sessionId = sessionStorage.getItem(TELEMETRY_SESSION_ID_KEY);
107114
if (!sessionId) {

packages/telemetry/src/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@ export const TELEMETRY_SESSION_ID_KEY = 'firebasetelemetry.sessionid';
2525
export const LOG_ENTRY_ATTRIBUTE_KEYS = {
2626
USER_ID: 'user.id',
2727
SESSION_ID: 'session.id',
28-
APP_VERSION: 'app.version',
28+
APP_VERSION: 'app.version'
2929
};

0 commit comments

Comments
 (0)