Skip to content

Commit 6d14604

Browse files
author
Kevin Elko
committed
split out storage impls
1 parent 5b9bff1 commit 6d14604

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

packages/remote-config/src/api.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,19 @@
1616
*/
1717

1818
import { _getProvider, FirebaseApp, getApp } from '@firebase/app';
19-
import { deepEqual } from '@firebase/util';
19+
import { deepEqual , getModularInstance } from '@firebase/util';
2020
import {
2121
LogLevel as RemoteConfigLogLevel,
2222
RemoteConfig,
2323
Value,
2424
RemoteConfigOptions
2525
} from './public_types';
26-
import { RemoteConfigAbortSignal, FetchResponse } from './client/remote_config_fetch_client';
26+
import { RemoteConfigAbortSignal } from './client/remote_config_fetch_client';
2727
import { RC_COMPONENT_NAME } from './constants';
2828
import { ERROR_FACTORY, ErrorCode, hasErrorCode } from './errors';
2929
import { RemoteConfig as RemoteConfigImpl } from './remote_config';
3030
import { Value as ValueImpl } from './value';
3131
import { LogLevel as FirebaseLogLevel } from '@firebase/logger';
32-
import { getModularInstance } from '@firebase/util';
3332

3433
/**
3534
*

packages/remote-config/src/register.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import {
2424
Component,
2525
ComponentType,
2626
ComponentContainer,
27-
InstanceFactoryOptions
2827
} from '@firebase/component';
2928
import { Logger, LogLevel as FirebaseLogLevel } from '@firebase/logger';
3029
import { RemoteConfig, RemoteConfigOptions } from './public_types';
@@ -36,7 +35,7 @@ import { RetryingClient } from './client/retrying_client';
3635
import { RC_COMPONENT_NAME } from './constants';
3736
import { ErrorCode, ERROR_FACTORY } from './errors';
3837
import { RemoteConfig as RemoteConfigImpl } from './remote_config';
39-
import { IndexedDbStorage, InMemoryStorage, Storage } from './storage/storage';
38+
import { IndexedDbStorage, InMemoryStorage } from './storage/storage';
4039
import { StorageCache } from './storage/storage_cache';
4140
// This needs to be in the same file that calls `getProvider()` on the component
4241
// or it will get tree-shaken out.
@@ -80,7 +79,9 @@ export function registerRemoteConfig(): void {
8079
}
8180
const namespace = options?.templateId || 'firebase';
8281

83-
const storage = isIndexedDBAvailable() ? new IndexedDbStorage(appId, app.name, namespace) : new InMemoryStorage();
82+
const storage = isIndexedDBAvailable() ?
83+
new IndexedDbStorage(appId, app.name, namespace) :
84+
new InMemoryStorage();
8485
const storageCache = new StorageCache(storage);
8586

8687
const logger = new Logger(packageName);

packages/remote-config/src/storage/storage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ export class IndexedDbStorage extends Storage {
276276
}
277277

278278
export class InMemoryStorage extends Storage {
279-
private db: { [key: string]: any } = {}
279+
private db: { [key: string]: unknown } = {};
280280

281281
async get<T>(key: ProjectNamespaceKeyFieldValue): Promise<T> {
282282
return Promise.resolve(this.db[key] as T);

0 commit comments

Comments
 (0)