Send app ID if automaticDataCollectionEnabled is falsy.

Author: dlarocque

packages/vertexai/src/requests/request.test.ts

@@ -126,10 +126,6 @@ describe('request methods', () => {
       const headers = await getHeaders(fakeUrl);
       expect(headers.get('x-goog-api-key')).to.equal('key');
     });
-    it('adds app id if automatedDataCollectionEnabled is undefined', async () => {
-      const headers = await getHeaders(fakeUrl);
-      expect(headers.get('X-Firebase-AppId')).to.equal('my-appid');
-    });
     it('adds app id if automatedDataCollectionEnabled is true', async () => {
       const fakeApiSettings: ApiSettings = {
         apiKey: 'key',
@@ -148,7 +144,11 @@ describe('request methods', () => {
         {}
       );
       const headers = await getHeaders(fakeUrl);
-      expect(headers.get('X-Firebase-AppId')).to.equal('my-appid');
+      expect(headers.get('X-Firebase-Appid')).to.equal('my-appid');
+    });
+    it('does not add app id if automatedDataCollectionEnabled is undefined', async () => {
+      const headers = await getHeaders(fakeUrl);
+      expect(headers.get('X-Firebase-Appid')).to.be.null;
     });
     it('does not add app id if automatedDataCollectionEnabled is false', async () => {
       const fakeApiSettings: ApiSettings = {
@@ -168,7 +168,7 @@ describe('request methods', () => {
         {}
       );
       const headers = await getHeaders(fakeUrl);
-      expect(headers.get('X-Firebase-AppId')).to.be.null;
+      expect(headers.get('X-Firebase-Appid')).to.be.null;
     });
     it('adds app check token if it exists', async () => {
       const headers = await getHeaders(fakeUrl);

packages/vertexai/src/requests/request.ts

@@ -84,8 +84,8 @@ export async function getHeaders(url: RequestUrl): Promise<Headers> {
   headers.append('Content-Type', 'application/json');
   headers.append('x-goog-api-client', getClientHeaders());
   headers.append('x-goog-api-key', url.apiSettings.apiKey);
-  if (url.apiSettings.automaticDataCollectionEnabled !== false) {
-    headers.append('X-Firebase-AppId', url.apiSettings.appId);
+  if (url.apiSettings.automaticDataCollectionEnabled) {
+    headers.append('X-Firebase-Appid', url.apiSettings.appId);
   }
   if (url.apiSettings.getAppCheckToken) {
     const appCheckToken = await url.apiSettings.getAppCheckToken();