Address lint errors + add/fix few tests

Author: ashish-kothari

common/api-review/remote-config.api.md

@@ -9,10 +9,11 @@ import { FirebaseApp } from '@firebase/app';
 // @public
 export function activate(remoteConfig: RemoteConfig): Promise<boolean>;
 
-// @alpha
-export type CustomSignals = {
+// @public
+export interface CustomSignals {
+    // (undocumented)
     [key: string]: string | number;
-};
+}
 
 // @public
 export function ensureInitialized(remoteConfig: RemoteConfig): Promise<void>;
@@ -67,9 +68,7 @@ export interface RemoteConfigSettings {
     minimumFetchIntervalMillis: number;
 }
 
-// Warning: (ae-incompatible-release-tags) The symbol "setCustomSignals" is marked as @public, but its signature references "CustomSignals" which is marked as @alpha
-//
-// @public (undocumented)
+// @public
 export function setCustomSignals(remoteConfig: RemoteConfig, customSignals: CustomSignals): Promise<void>;
 
 // @public

packages/remote-config-compat/src/remoteConfig.test.ts

@@ -157,4 +157,16 @@ describe('Remote Config Compat', () => {
       'debug'
     );
   });
+
+  it('setCustomSignals() calls modular setCustomSignals()', async () => {
+    const modularSetCustomSignalsStub = stub(modularApi, 'setCustomSignals').callsFake(() =>
+      Promise.resolve()
+    );
+    await remoteConfig.setCustomSignals({'customSignal': 'value'});
+
+    expect(modularSetCustomSignalsStub).to.have.been.calledWithExactly(
+      fakeModularRemoteConfig,
+      {'customSignal': 'value'}
+    );
+  });
 });

packages/remote-config-types/index.d.ts

@@ -187,8 +187,6 @@ export type LogLevel = 'debug' | 'error' | 'silent';
  *   <li><code>string</code>
  *   <li><code>number</code>
  * </ul>
- *
- * @alpha
  */
 export type CustomSignals = {[key: string]: string | number};
 

packages/remote-config/src/api.ts

@@ -109,7 +109,6 @@ export async function fetchConfig(remoteConfig: RemoteConfig): Promise<void> {
   // * it applies to all retries (like curl's max-time arg)
   // * it is consistent with the Fetch API's signal input
   const abortSignal = new RemoteConfigAbortSignal();
-  const customSignals = rc._storageCache.getCustomSignals();
 
   setTimeout(async () => {
     // Note a very low delay, eg < 10ms, can elapse before listeners are initialized.
@@ -262,6 +261,14 @@ function getAllKeys(obj1: {} = {}, obj2: {} = {}): string[] {
   return Object.keys({ ...obj1, ...obj2 });
 }
 
+/**
+ * Sets the custom signals for the app instance.
+ * 
+ * @param remoteConfig - The {@link RemoteConfig} instance.
+ * @param customSignals - Map (key, value) of the custom signals to be set for the app instance.
+ * 
+ * @public
+ */
 export async function setCustomSignals(
   remoteConfig: RemoteConfig, customSignals: CustomSignals): Promise<void> {
   const rc = getModularInstance(remoteConfig) as RemoteConfigImpl;

packages/remote-config/src/public_types.ts

@@ -143,10 +143,10 @@ export type LogLevel = 'debug' | 'error' | 'silent';
  *   <li><code>string</code>
  *   <li><code>number</code>
  * </ul>
- *
- * @alpha
+ * 
+ * @public
  */
-export type CustomSignals = {[key: string]: string | number};
+export interface CustomSignals {[key: string]: string | number};
 
 declare module '@firebase/component' {
   interface NameServiceMapping {