Skip to content

Commit 8c74eff

Browse files
committed
PR feedback.
1 parent d5449f5 commit 8c74eff

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

packages/firestore/test/integration/api/database.test.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ import {
6565
SnapshotOptions,
6666
newTestApp,
6767
QuerySnapshot,
68-
vector
68+
vector,
69+
getDocsFromServer
6970
} from '../util/firebase_export';
7071
import {
7172
apiDescribe,
@@ -710,9 +711,9 @@ apiDescribe('Database', persistence => {
710711

711712
return withTestCollection(persistence, docs, async randomCol => {
712713
// We validate that the SDK orders the vector field the same way as the backend
713-
// by comparing the sort order of vector fields from a Query.get() and
714-
// Query.onSnapshot(). Query.onSnapshot() will return sort order of the SDK,
715-
// and Query.get() will return sort order of the backend.
714+
// by comparing the sort order of vector fields from getDocsFromServer and
715+
// onSnapshot. onSnapshot will return sort order of the SDK,
716+
// and getDocsFromServer will return sort order of the backend.
716717

717718
const orderedQuery = query(randomCol, orderBy('embedding'));
718719
const gotInitialSnapshot = new Deferred<QuerySnapshot>();
@@ -730,7 +731,7 @@ apiDescribe('Database', persistence => {
730731
const watchSnapshot = await gotInitialSnapshot.promise;
731732
unsubscribe();
732733

733-
const getSnapshot = await getDocs(orderedQuery);
734+
const getSnapshot = await getDocsFromServer(orderedQuery);
734735

735736
// Compare the snapshot (including sort order) of a snapshot
736737
// from Query.onSnapshot() to an actual snapshot from Query.get()

0 commit comments

Comments
 (0)