Fixing lint on packages/firestore (#5270)

Author: Brian Chen

.changeset/witty-gorillas-punch.md

@@ -0,0 +1,2 @@
+---
+---

packages/firestore/rollup.shared.js

@@ -143,7 +143,8 @@ const removeAssertAndPrefixInternalTransformer = service => ({
   ],
   after: []
 });
-exports.removeAssertAndPrefixInternalTransformer = removeAssertAndPrefixInternalTransformer;
+exports.removeAssertAndPrefixInternalTransformer =
+  removeAssertAndPrefixInternalTransformer;
 
 /**
  * Terser options that mangle all properties prefixed with __PRIVATE_.

packages/firestore/src/core/component_provider.ts

@@ -102,7 +102,8 @@ export interface OfflineComponentProvider {
  * Uses EagerGC garbage collection.
  */
 export class MemoryOfflineComponentProvider
-  implements OfflineComponentProvider {
+  implements OfflineComponentProvider
+{
   persistence!: Persistence;
   sharedClientState!: SharedClientState;
   localStore!: LocalStore;
@@ -195,8 +196,8 @@ export class IndexedDbOfflineComponentProvider extends MemoryOfflineComponentPro
   createGarbageCollectionScheduler(
     cfg: ComponentConfiguration
   ): GarbageCollectionScheduler | null {
-    const garbageCollector = this.persistence.referenceDelegate
-      .garbageCollector;
+    const garbageCollector =
+      this.persistence.referenceDelegate.garbageCollector;
     return new LruScheduler(garbageCollector, cfg.asyncQueue);
   }
 
@@ -261,10 +262,8 @@ export class MultiTabOfflineComponentProvider extends IndexedDbOfflineComponentP
           syncEngine
         ),
         getActiveClients: syncEngineGetActiveClients.bind(null, syncEngine),
-        synchronizeWithChangedDocuments: syncEngineSynchronizeWithChangedDocuments.bind(
-          null,
-          syncEngine
-        )
+        synchronizeWithChangedDocuments:
+          syncEngineSynchronizeWithChangedDocuments.bind(null, syncEngine)
       };
       await this.sharedClientState.start();
     }
@@ -347,10 +346,8 @@ export class OnlineComponentProvider {
         OnlineStateSource.SharedClientState
       );
 
-    this.remoteStore.remoteSyncer.handleCredentialChange = syncEngineHandleCredentialChange.bind(
-      null,
-      this.syncEngine
-    );
+    this.remoteStore.remoteSyncer.handleCredentialChange =
+      syncEngineHandleCredentialChange.bind(null, this.syncEngine);
 
     await remoteStoreApplyPrimaryState(
       this.remoteStore,

packages/firestore/src/core/sync_engine_impl.ts

@@ -356,10 +356,11 @@ async function initializeViewAndComputeSnapshot(
   );
   const view = new View(query, queryResult.remoteKeys);
   const viewDocChanges = view.computeDocChanges(queryResult.documents);
-  const synthesizedTargetChange = TargetChange.createSynthesizedTargetChangeForCurrentChange(
-    targetId,
-    current && syncEngineImpl.onlineState !== OnlineState.Offline
-  );
+  const synthesizedTargetChange =
+    TargetChange.createSynthesizedTargetChangeForCurrentChange(
+      targetId,
+      current && syncEngineImpl.onlineState !== OnlineState.Offline
+    );
   const viewChange = view.applyChanges(
     viewDocChanges,
     /* updateLimboDocuments= */ syncEngineImpl.isPrimaryClient,
@@ -413,9 +414,8 @@ export async function syncEngineUnlisten(
     // We need to remove the local query target first to allow us to verify
     // whether any other client is still interested in this target.
     syncEngineImpl.sharedClientState.removeLocalQueryTarget(queryView.targetId);
-    const targetRemainsActive = syncEngineImpl.sharedClientState.isActiveQueryTarget(
-      queryView.targetId
-    );
+    const targetRemainsActive =
+      syncEngineImpl.sharedClientState.isActiveQueryTarget(queryView.targetId);
 
     if (!targetRemainsActive) {
       await localStoreReleaseTarget(
@@ -495,9 +495,8 @@ export async function syncEngineApplyRemoteEvent(
     );
     // Update `receivedDocument` as appropriate for any limbo targets.
     remoteEvent.targetChanges.forEach((targetChange, targetId) => {
-      const limboResolution = syncEngineImpl.activeLimboResolutionsByTarget.get(
-        targetId
-      );
+      const limboResolution =
+        syncEngineImpl.activeLimboResolutionsByTarget.get(targetId);
       if (limboResolution) {
         // Since this is a limbo resolution lookup, it's for a single document
         // and it could be added, modified, or removed, but not a combination.
@@ -606,9 +605,8 @@ export async function syncEngineRejectListen(
   // PORTING NOTE: Multi-tab only.
   syncEngineImpl.sharedClientState.updateQueryState(targetId, 'rejected', err);
 
-  const limboResolution = syncEngineImpl.activeLimboResolutionsByTarget.get(
-    targetId
-  );
+  const limboResolution =
+    syncEngineImpl.activeLimboResolutionsByTarget.get(targetId);
   const limboKey = limboResolution && limboResolution.key;
   if (limboKey) {
     // TODO(klimt): We really only should do the following on permission
@@ -641,9 +639,8 @@ export async function syncEngineRejectListen(
     // RemoteEvent. If `applyRemoteEvent()` throws, we want to re-listen to
     // this query when the RemoteStore restarts the Watch stream, which should
     // re-trigger the target failure.
-    syncEngineImpl.activeLimboTargetsByKey = syncEngineImpl.activeLimboTargetsByKey.remove(
-      limboKey
-    );
+    syncEngineImpl.activeLimboTargetsByKey =
+      syncEngineImpl.activeLimboTargetsByKey.remove(limboKey);
     syncEngineImpl.activeLimboResolutionsByTarget.delete(targetId);
     pumpEnqueuedLimboResolutions(syncEngineImpl);
   } else {
@@ -800,9 +797,8 @@ function addMutationCallback(
     newCallbacks = new SortedMap<BatchId, Deferred<void>>(primitiveComparator);
   }
   newCallbacks = newCallbacks.insert(batchId, callback);
-  syncEngineImpl.mutationUserCallbacks[
-    syncEngineImpl.currentUser.toKey()
-  ] = newCallbacks;
+  syncEngineImpl.mutationUserCallbacks[syncEngineImpl.currentUser.toKey()] =
+    newCallbacks;
 }
 
 /**
@@ -834,9 +830,8 @@ function processUserCallback(
       }
       newCallbacks = newCallbacks.remove(batchId);
     }
-    syncEngineImpl.mutationUserCallbacks[
-      syncEngineImpl.currentUser.toKey()
-    ] = newCallbacks;
+    syncEngineImpl.mutationUserCallbacks[syncEngineImpl.currentUser.toKey()] =
+      newCallbacks;
   }
 }
 
@@ -863,13 +858,11 @@ function removeAndCleanupTarget(
   syncEngineImpl.queriesByTarget.delete(targetId);
 
   if (syncEngineImpl.isPrimaryClient) {
-    const limboKeys = syncEngineImpl.limboDocumentRefs.removeReferencesForId(
-      targetId
-    );
+    const limboKeys =
+      syncEngineImpl.limboDocumentRefs.removeReferencesForId(targetId);
     limboKeys.forEach(limboKey => {
-      const isReferenced = syncEngineImpl.limboDocumentRefs.containsKey(
-        limboKey
-      );
+      const isReferenced =
+        syncEngineImpl.limboDocumentRefs.containsKey(limboKey);
       if (!isReferenced) {
         // We removed the last reference for this key
         removeLimboTarget(syncEngineImpl, limboKey);
@@ -893,9 +886,8 @@ function removeLimboTarget(
   }
 
   remoteStoreUnlisten(syncEngineImpl.remoteStore, limboTargetId);
-  syncEngineImpl.activeLimboTargetsByKey = syncEngineImpl.activeLimboTargetsByKey.remove(
-    key
-  );
+  syncEngineImpl.activeLimboTargetsByKey =
+    syncEngineImpl.activeLimboTargetsByKey.remove(key);
   syncEngineImpl.activeLimboResolutionsByTarget.delete(limboTargetId);
   pumpEnqueuedLimboResolutions(syncEngineImpl);
 }
@@ -958,19 +950,18 @@ function pumpEnqueuedLimboResolutions(syncEngineImpl: SyncEngineImpl): void {
     syncEngineImpl.activeLimboTargetsByKey.size <
       syncEngineImpl.maxConcurrentLimboResolutions
   ) {
-    const keyString = syncEngineImpl.enqueuedLimboResolutions.values().next()
-      .value;
+    const keyString = syncEngineImpl.enqueuedLimboResolutions
+      .values()
+      .next().value;
     syncEngineImpl.enqueuedLimboResolutions.delete(keyString);
     const key = new DocumentKey(ResourcePath.fromString(keyString));
     const limboTargetId = syncEngineImpl.limboTargetIdGenerator.next();
     syncEngineImpl.activeLimboResolutionsByTarget.set(
       limboTargetId,
       new LimboResolution(key)
     );
-    syncEngineImpl.activeLimboTargetsByKey = syncEngineImpl.activeLimboTargetsByKey.insert(
-      key,
-      limboTargetId
-    );
+    syncEngineImpl.activeLimboTargetsByKey =
+      syncEngineImpl.activeLimboTargetsByKey.insert(key, limboTargetId);
     remoteStoreListen(
       syncEngineImpl.remoteStore,
       new TargetData(
@@ -1123,9 +1114,8 @@ export function syncEngineGetRemoteKeysForTarget(
   targetId: TargetId
 ): DocumentKeySet {
   const syncEngineImpl = debugCast(syncEngine, SyncEngineImpl);
-  const limboResolution = syncEngineImpl.activeLimboResolutionsByTarget.get(
-    targetId
-  );
+  const limboResolution =
+    syncEngineImpl.activeLimboResolutionsByTarget.get(targetId);
   if (limboResolution && limboResolution.receivedDocument) {
     return documentKeySet().add(limboResolution.key);
   } else {
@@ -1160,9 +1150,8 @@ async function synchronizeViewAndComputeSnapshot(
     queryView.query,
     /* usePreviousResults= */ true
   );
-  const viewSnapshot = queryView.view.synchronizeWithPersistedState(
-    queryResult
-  );
+  const viewSnapshot =
+    queryView.view.synchronizeWithPersistedState(queryResult);
   if (syncEngineImpl.isPrimaryClient) {
     updateTrackedLimbos(
       syncEngineImpl,
@@ -1183,10 +1172,9 @@ export async function syncEngineSynchronizeWithChangedDocuments(
 ): Promise<void> {
   const syncEngineImpl = debugCast(syncEngine, SyncEngineImpl);
 
-  return localStoreGetNewDocumentChanges(
-    syncEngineImpl.localStore
-  ).then(changes =>
-    syncEngineEmitNewSnapsAndNotifyLocalStore(syncEngineImpl, changes)
+  return localStoreGetNewDocumentChanges(syncEngineImpl.localStore).then(
+    changes =>
+      syncEngineEmitNewSnapsAndNotifyLocalStore(syncEngineImpl, changes)
   );
 }
 
@@ -1253,7 +1241,8 @@ export async function syncEngineApplyPrimaryState(
     // server considers to be in the target). So when a secondary becomes
     // primary, we need to need to make sure that all views for all targets
     // match the state on disk.
-    const activeTargets = syncEngineImpl.sharedClientState.getAllActiveQueryTargets();
+    const activeTargets =
+      syncEngineImpl.sharedClientState.getAllActiveQueryTargets();
     const activeQueries = await synchronizeQueryViewsAndRaiseSnapshots(
       syncEngineImpl,
       activeTargets.toArray(),
@@ -1447,10 +1436,11 @@ export async function syncEngineApplyTargetState(
         const changes = await localStoreGetNewDocumentChanges(
           syncEngineImpl.localStore
         );
-        const synthesizedRemoteEvent = RemoteEvent.createSynthesizedRemoteEventForCurrentChange(
-          targetId,
-          state === 'current'
-        );
+        const synthesizedRemoteEvent =
+          RemoteEvent.createSynthesizedRemoteEventForCurrentChange(
+            targetId,
+            state === 'current'
+          );
         await syncEngineEmitNewSnapsAndNotifyLocalStore(
           syncEngineImpl,
           changes,
@@ -1532,41 +1522,27 @@ export async function syncEngineApplyActiveTargetsChange(
 
 function ensureWatchCallbacks(syncEngine: SyncEngine): SyncEngineImpl {
   const syncEngineImpl = debugCast(syncEngine, SyncEngineImpl);
-  syncEngineImpl.remoteStore.remoteSyncer.applyRemoteEvent = syncEngineApplyRemoteEvent.bind(
-    null,
-    syncEngineImpl
-  );
-  syncEngineImpl.remoteStore.remoteSyncer.getRemoteKeysForTarget = syncEngineGetRemoteKeysForTarget.bind(
-    null,
-    syncEngineImpl
-  );
-  syncEngineImpl.remoteStore.remoteSyncer.rejectListen = syncEngineRejectListen.bind(
-    null,
-    syncEngineImpl
-  );
-  syncEngineImpl.syncEngineListener.onWatchChange = eventManagerOnWatchChange.bind(
-    null,
-    syncEngineImpl.eventManager
-  );
-  syncEngineImpl.syncEngineListener.onWatchError = eventManagerOnWatchError.bind(
-    null,
-    syncEngineImpl.eventManager
-  );
+  syncEngineImpl.remoteStore.remoteSyncer.applyRemoteEvent =
+    syncEngineApplyRemoteEvent.bind(null, syncEngineImpl);
+  syncEngineImpl.remoteStore.remoteSyncer.getRemoteKeysForTarget =
+    syncEngineGetRemoteKeysForTarget.bind(null, syncEngineImpl);
+  syncEngineImpl.remoteStore.remoteSyncer.rejectListen =
+    syncEngineRejectListen.bind(null, syncEngineImpl);
+  syncEngineImpl.syncEngineListener.onWatchChange =
+    eventManagerOnWatchChange.bind(null, syncEngineImpl.eventManager);
+  syncEngineImpl.syncEngineListener.onWatchError =
+    eventManagerOnWatchError.bind(null, syncEngineImpl.eventManager);
   return syncEngineImpl;
 }
 
 export function syncEngineEnsureWriteCallbacks(
   syncEngine: SyncEngine
 ): SyncEngineImpl {
   const syncEngineImpl = debugCast(syncEngine, SyncEngineImpl);
-  syncEngineImpl.remoteStore.remoteSyncer.applySuccessfulWrite = syncEngineApplySuccessfulWrite.bind(
-    null,
-    syncEngineImpl
-  );
-  syncEngineImpl.remoteStore.remoteSyncer.rejectFailedWrite = syncEngineRejectFailedWrite.bind(
-    null,
-    syncEngineImpl
-  );
+  syncEngineImpl.remoteStore.remoteSyncer.applySuccessfulWrite =
+    syncEngineApplySuccessfulWrite.bind(null, syncEngineImpl);
+  syncEngineImpl.remoteStore.remoteSyncer.rejectFailedWrite =
+    syncEngineRejectFailedWrite.bind(null, syncEngineImpl);
   return syncEngineImpl;
 }
 

packages/firestore/src/local/indexeddb_schema_converter.ts

@@ -220,11 +220,9 @@ export class SchemaConverter implements SimpleDbSchemaConverter {
                 );
                 const batch = fromDbMutationBatch(this.serializer, dbBatch);
 
-                return removeMutationBatch(
-                  txn,
-                  queue.userId,
-                  batch
-                ).next(() => {});
+                return removeMutationBatch(txn, queue.userId, batch).next(
+                  () => {}
+                );
               }
             );
           });

packages/firestore/src/local/indexeddb_target_cache.ts

@@ -101,7 +101,8 @@ export class IndexedDbTargetCache implements TargetCache {
     return this.retrieveMetadata(transaction).next(metadata => {
       metadata.highestListenSequenceNumber = highestListenSequenceNumber;
       if (lastRemoteSnapshotVersion) {
-        metadata.lastRemoteSnapshotVersion = lastRemoteSnapshotVersion.toTimestamp();
+        metadata.lastRemoteSnapshotVersion =
+          lastRemoteSnapshotVersion.toTimestamp();
       }
       if (highestListenSequenceNumber > metadata.highestListenSequenceNumber) {
         metadata.highestListenSequenceNumber = highestListenSequenceNumber;

packages/firestore/src/local/local_documents_view.ts

@@ -288,9 +288,8 @@ export class LocalDocumentsView {
           mutation instanceof PatchMutation &&
           existingDocuments.get(mutation.key) === null
         ) {
-          missingBaseDocEntriesForPatching = missingBaseDocEntriesForPatching.add(
-            mutation.key
-          );
+          missingBaseDocEntriesForPatching =
+            missingBaseDocEntriesForPatching.add(mutation.key);
         }
       }
     }

packages/firestore/src/local/local_serializer.ts

@@ -209,7 +209,8 @@ export function fromDbMutationBatch(
         'TransformMutation should be preceded by a patch or set mutation'
       );
       const transformMutation = dbBatch.mutations[i + 1];
-      currentMutation.updateTransforms = transformMutation.transform!.fieldTransforms;
+      currentMutation.updateTransforms =
+        transformMutation.transform!.fieldTransforms;
       dbBatch.mutations.splice(i + 1, 1);
       ++i;
     }