cleanup

Author: dlarocque

.github/workflows/check-pkg-paths.yml

@@ -14,8 +14,7 @@
 
 name: Test Package Paths
 
-on:
-  pull_request:
+on: pull_request
 
 jobs:
   test:

.github/workflows/prerelease-manual-deploy.yml

@@ -45,6 +45,7 @@ jobs:
           with:
             path: "**/node_modules"
             key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+        - run: yarn install --frozen-lockfile
         - name: Deploy prerelease
           run: yarn release custom -p ${{ github.event.inputs.prereleaseName }} -t ${{ github.event.inputs.npmTag }}
           env:

.github/workflows/release-log.yml

@@ -28,8 +28,7 @@ jobs:
       - name: Checkout Repo
         uses: actions/checkout@v4
 
-      - name: Setup Node.js 20.x
-        uses: actions/setup-node@master
+      - uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
 

.github/workflows/release-prod.yml

@@ -32,18 +32,18 @@ jobs:
       contents: write
 
     steps:
-    - uses: actions/setup-node@v4
-      with:
-        node-version-file: '.nvmrc'
-        cache: yarn
-        cache-dependency-path: yarn.lock
     - name: Checkout release branch (with history)
       uses: actions/checkout@v4
       with:
         # Release script requires git history and tags.
         fetch-depth: 0
         ref: ${{ github.event.inputs.release-branch }}
         token: ${{ secrets.OSS_BOT_GITHUB_TOKEN }}
+    - uses: actions/setup-node@v4
+      with:
+        node-version-file: '.nvmrc'
+        cache: yarn
+        cache-dependency-path: yarn.lock
     - run: yarn install --frozen-lockfile
     - name: Publish to NPM
       # --skipTests No need to run tests

.github/workflows/release-staging.yml

@@ -46,11 +46,6 @@ jobs:
     # Block this workflow if run on a non-release branch.
     if: github.event.inputs.release-branch == 'release' || endsWith(github.event.inputs.release-branch, '-releasebranch')
     steps:
-    - uses: actions/setup-node@v4
-      with:
-        node-version-file: '.nvmrc'
-        cache: yarn
-        cache-dependency-path: yarn.lock
     - name: Merge main into release
       uses: actions/github-script@v6
       with:
@@ -69,6 +64,11 @@ jobs:
         # Release script requires git history and tags.
         fetch-depth: 0
         ref: ${{ github.event.inputs.release-branch }}
+    - uses: actions/setup-node@v4
+      with:
+        node-version-file: '.nvmrc'
+        cache: yarn
+        cache-dependency-path: yarn.lock
     - run: yarn install --frozen-lockfile
     - name: Publish to NPM
       # --skipTests No need to run tests

.github/workflows/release-tweet.yml

@@ -34,8 +34,7 @@ jobs:
     steps:
       - name: Checkout Repo
         uses: actions/checkout@v4
-      - name: Setup Node.js 20.x
-        uses: actions/setup-node@master
+      - uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
       - name: Poll release notes page on devsite

.github/workflows/test-all.yml

@@ -14,8 +14,7 @@
 
 name: Test All Packages
 
-on: 
-  pull_request:
+on: pull_request
 
 env:
   # make chromedriver detect installed Chrome version and download the corresponding driver
@@ -90,8 +89,7 @@ jobs:
         path: "**/node_modules"
         key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
     - run: yarn install --frozen-lockfile
-    - name: Test setup
-      run: cp config/ci.config.json config/project.json
+    - run: cp config/ci.config.json config/project.json
     - name: Set start timestamp env var
       run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
     - name: Run unit tests
@@ -127,7 +125,7 @@ jobs:
         echo "::warning ::Previously validated version: ${CHROME_VALIDATED_VERSION} vs. Installed version: $chromeVersionString"
         echo "CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE" >> "$GITHUB_ENV"
         fi
-    - name: Test Evn TEMP
+    - name: Test Env TEMP
       run: |
         echo $CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE
     - name: Download build archive
@@ -146,8 +144,7 @@ jobs:
         path: "**/node_modules"
         key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
     - run: yarn install --frozen-lockfile
-    - name: Test setup
-      run: cp config/ci.config.json config/project.json
+    - run: cp config/ci.config.json config/project.json
     - name: Set start timestamp env var
       run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
     - name: Run unit tests
@@ -191,8 +188,7 @@ jobs:
         path: "**/node_modules"
         key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
     - run: yarn install --frozen-lockfile
-    - name: Test setup
-      run: cp config/ci.config.json config/project.json
+    - run: cp config/ci.config.json config/project.json
     - name: Set start timestamp env var
       run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
     - name: Run unit tests