Got tests to work

Author: maneesht

packages/auth/src/api/index.test.ts

@@ -41,7 +41,7 @@ import {
 import { ServerError } from './errors';
 import { SDK_VERSION } from '@firebase/app';
 import { _getBrowserName } from '../core/util/browser';
-import { FetchProvider } from '../../internal';
+import { connectAuthEmulator, FetchProvider } from '../../internal';
 
 use(sinonChai);
 use(chaiAsPromised);
@@ -65,23 +65,30 @@ describe('api/_performApiRequest', () => {
 
   afterEach(() => {
     sinon.restore();
-  })
+  });
 
   context.only('with regular requests', () => {
-    
     beforeEach(() => {
       mockFetch.setUp();
       fetchSpy = sinon.spy(FetchProvider.fetch());
-    })
+    });
     afterEach(mockFetch.tearDown);
 
     it.only('should set the correct request, method and HTTP Headers', async () => {
       const mock = mockEndpoint(Endpoint.SIGN_UP, serverResponse);
+      auth.emulatorConfig = {
+        host: 'https://something.cloudworkstations.dev',
+        protocol: '',
+        port: 8,
+        options: {
+          disableWarnings: false
+        }
+      };
       const response = await _performApiRequest<
         typeof request,
         typeof serverResponse
       >(auth, HttpMethod.POST, Endpoint.SIGN_UP, request);
-      expect(fetchSpy).to.have.been.called;
+      expect(mock.calls[0].fullRequest?.credentials).to.eq('include');
     });
 
     it('should set the device language if available', async () => {

packages/auth/src/core/auth/emulator.test.ts

@@ -43,7 +43,6 @@ describe.only('core/auth/emulator', () => {
 
   beforeEach(async () => {
     auth = await testAuth();
-    spy = sinon.spy(FetchProvider.fetch());
     user = testUser(_castAuth(auth), 'uid', 'email', true);
     fetch.setUp();
     normalEndpoint = mockEndpoint(Endpoint.DELETE_ACCOUNT, {});
@@ -96,16 +95,6 @@ describe.only('core/auth/emulator', () => {
         'auth/emulator-config-failed'
       );
     });
-    it.only('sends the proper value', async () => {
-      expect(() => connectAuthEmulator(auth, 'http://127.0.0.1:2020')).to.not
-        .throw;
-      await user.delete();
-      expect(spy).to.have.been.called;
-      expect(() => connectAuthEmulator(auth, 'http://127.0.0.1:2021')).to.throw(
-        FirebaseError,
-        'auth/emulator-config-failed'
-      );
-    });
 
     it('subsequent calls update the endpoint appropriately', async () => {
       connectAuthEmulator(auth, 'http://127.0.0.1:2021');
@@ -124,7 +113,7 @@ describe.only('core/auth/emulator', () => {
       });
     });
 
-  it('subsequent calls update the endpoint appropriately', async () => {
+    it('subsequent calls update the endpoint appropriately', async () => {
       connectAuthEmulator(auth, 'http://127.0.0.1:2021');
       expect(auth.emulatorConfig).to.eql({
         protocol: 'http',

packages/auth/test/helpers/mock_fetch.ts

@@ -22,6 +22,7 @@ export interface Call {
   request?: object | string;
   method?: string;
   headers: Headers;
+  fullRequest?: RequestInit;
 }
 
 export interface Route {
@@ -59,7 +60,8 @@ const fakeFetch: typeof fetch = (
   calls.push({
     request: requestBody,
     method: request?.method,
-    headers
+    headers,
+    fullRequest: request
   });
 
   return Promise.resolve(