Implementing features from API audit and node backport (#9284)

Author: MarkDuckworth

common/api-review/firestore-lite-pipelines.api.md

@@ -50,6 +50,8 @@ export type {
 
 export { PipelineSource } from '../../src/lite-api/pipeline-source';
 
+export { OneOf } from '../../src/util/types';
+
 export {
   PipelineResult,
   PipelineSnapshot
@@ -60,94 +62,86 @@ export { Pipeline } from '../../src/lite-api/pipeline';
 export { execute } from '../../src/lite-api/pipeline_impl';
 
 export {
-  Stage,
-  FindNearestOptions,
-  AddFields,
-  Aggregate,
-  Distinct,
-  CollectionSource,
-  CollectionGroupSource,
-  DatabaseSource,
-  DocumentsSource,
-  Where,
-  FindNearest,
-  Limit,
-  Offset,
-  Select,
-  Sort,
-  GenericStage
-} from '../../src/lite-api/stage';
+  StageOptions,
+  CollectionStageOptions,
+  CollectionGroupStageOptions,
+  DatabaseStageOptions,
+  DocumentsStageOptions,
+  AddFieldsStageOptions,
+  RemoveFieldsStageOptions,
+  SelectStageOptions,
+  WhereStageOptions,
+  OffsetStageOptions,
+  LimitStageOptions,
+  DistinctStageOptions,
+  AggregateStageOptions,
+  FindNearestStageOptions,
+  ReplaceWithStageOptions,
+  SampleStageOptions,
+  UnionStageOptions,
+  UnnestStageOptions,
+  SortStageOptions
+} from '../../src/lite-api/stage_options';
 
 export {
-  Expr,
+  Expression,
   field,
   and,
   array,
-  arrayOffset,
   constant,
   add,
   subtract,
   multiply,
-  avg,
-  bitAnd,
-  substr,
-  constantVector,
-  bitLeftShift,
-  bitNot,
+  average,
+  substring,
   count,
   mapMerge,
   mapRemove,
-  bitOr,
   ifError,
   isAbsent,
   isError,
   or,
-  rand,
-  bitRightShift,
-  bitXor,
   divide,
   isNotNan,
   map,
   isNotNull,
   isNull,
   mod,
   documentId,
-  eq,
-  neq,
-  lt,
+  equal,
+  notEqual,
+  lessThan,
   countIf,
-  lte,
-  gt,
-  gte,
+  lessThanOrEqual,
+  greaterThan,
+  greaterThanOrEqual,
   arrayConcat,
   arrayContains,
   arrayContainsAny,
   arrayContainsAll,
   arrayLength,
-  eqAny,
-  notEqAny,
+  equalAny,
+  notEqualAny,
   xor,
-  cond,
+  conditional,
   not,
   logicalMaximum,
   logicalMinimum,
   exists,
   isNan,
   reverse,
-  replaceFirst,
-  replaceAll,
   byteLength,
   charLength,
   like,
   regexContains,
   regexMatch,
-  strContains,
+  stringContains,
   startsWith,
   endsWith,
   toLower,
   toUpper,
   trim,
-  strConcat,
+  stringConcat,
   mapGet,
   countAll,
   minimum,
@@ -163,17 +157,17 @@ export {
   unixSecondsToTimestamp,
   timestampToUnixSeconds,
   timestampAdd,
-  timestampSub,
+  timestampSubtract,
   ascending,
   descending,
-  ExprWithAlias,
+  AliasedExpression,
   Field,
   Constant,
-  FunctionExpr,
+  FunctionExpression,
   Ordering,
-  ExprType,
-  AggregateWithAlias,
+  ExpressionType,
+  AliasedAggregate,
   Selectable,
-  BooleanExpr,
+  BooleanExpression,
   AggregateFunction
 } from '../../src/lite-api/expressions';

common/api-review/firestore-pipelines.api.md

@@ -8,6 +8,7 @@
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "scripts": {
     "bundle": "rollup -c",
+    "compile": "tsc --emitDeclarationOnly --declaration -p tsconfig.json",
     "prebuild": "tsc --emitDeclarationOnly --declaration -p tsconfig.json; yarn api-report",
     "build": "run-p --npm-path npm build:lite build:main",
     "build:release": "yarn build && yarn typings:public",
@@ -95,37 +96,41 @@
         "require": "./dist/lite/pipelines.node.cjs.js",
         "import": "./dist/lite/pipelines.node.mjs"
       },
-      "react-native": "./dist/lite/pipelines.rn.esm2017.js",
+      "react-native": "./dist/lite/pipelines.rn.esm.js",
       "browser": {
         "require": "./dist/lite/pipelines.browser.cjs.js",
-        "import": "./dist/lite/pipelines.browser.esm2017.js"
+        "import": "./dist/lite/pipelines.browser.esm.js"
       },
-      "default": "./dist/lite/pipelines.browser.esm2017.js"
+      "default": "./dist/lite/pipelines.browser.esm.js"
     },
     "./pipelines": {
       "types": "./pipelines/pipelines.d.ts",
       "node": {
         "require": "./dist/pipelines.node.cjs.js",
         "import": "./dist/pipelines.node.mjs"
       },
-      "react-native": "./dist/index.rn.esm2017.js",
+      "react-native": "./dist/index.rn.esm.js",
       "browser": {
         "require": "./dist/pipelines.cjs.js",
-        "import": "./dist/pipelines.esm2017.js"
+        "import": "./dist/pipelines.esm.js"
       },
-      "default": "./dist/pipelines.esm2017.js"
+      "default": "./dist/pipelines.esm.js"
     },
     "./package.json": "./package.json"
   },
-  "main": "dist/node-cjs/index.node.cjs.js",
-  "main-esm": "dist/node-esm/index.node.mjs",
+  "main": "dist/index.node.cjs.js",
+  "main-esm": "dist/index.node.mjs",
   "react-native": "dist/index.rn.js",
   "browser": "dist/index.esm.js",
   "module": "dist/index.esm.js",
   "license": "Apache-2.0",
   "files": [
     "dist",
-    "lite/package.json"
+    "lite/package.json",
+    "pipelines/package.json",
+    "pipelines/pipelines.d.ts",
+    "lite/pipelines/package.json",
+    "lite/pipelines/pipelines.d.ts"
   ],
   "dependencies": {
     "@firebase/component": "0.7.0",
@@ -168,7 +173,7 @@
   "bugs": {
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
-  "types": "dist/index.d.ts",
+  "types": "dist/firestore/src/index.d.ts",
   "nyc": {
     "extension": [
       ".ts"

packages/firestore/lite/pipelines/pipelines.ts

@@ -178,8 +178,8 @@ const allBuilds = [
     output: [
       {
         dir: 'dist/',
-        entryFileNames: '[name].esm2017.js',
-        chunkFileNames: 'common-[hash].esm2017.js',
+        entryFileNames: '[name].esm.js',
+        chunkFileNames: 'common-[hash].esm.js',
         format: 'es',
         sourcemap: true
       }

packages/firestore/package.json

@@ -187,8 +187,8 @@ const allBuilds = [
     output: [
       {
         dir: 'dist/lite/',
-        entryFileNames: '[name].esm2017.js',
-        chunkFileNames: 'common-[hash].esm2017.js',
+        entryFileNames: '[name].esm.js',
+        chunkFileNames: 'common-[hash].esm.js',
         format: 'es',
         sourcemap: true
       }
@@ -207,8 +207,8 @@ const allBuilds = [
     input: ['./lite/index.ts', './lite/pipelines/pipelines.ts'],
     output: {
       dir: 'dist/lite/',
-      entryFileNames: '[name].rn.esm2017.js',
-      chunkFileNames: 'common-[hash].rn.esm2017.js',
+      entryFileNames: '[name].rn.esm.js',
+      chunkFileNames: 'common-[hash].rn.esm.js',
       format: 'es',
       sourcemap: true
     },