Added back port usage

Author: maneesht

common/api-review/data-connect.api.md

@@ -259,6 +259,8 @@ export interface TransportOptions {
     // (undocumented)
     host: string;
     // (undocumented)
+    port?: number;
+    // (undocumented)
     sslEnabled?: boolean;
 }
 

packages/data-connect/src/api/DataConnect.ts

@@ -57,6 +57,7 @@ export interface ConnectorConfig {
  */
 export interface TransportOptions {
   host: string;
+  port?: number;
   sslEnabled?: boolean;
 }
 
@@ -185,6 +186,7 @@ export class DataConnect {
     if (this._transportOptions) {
       this._transport.useEmulator(
         this._transportOptions.host,
+        this._transportOptions.port,
         this._transportOptions.sslEnabled
       );
     }

packages/data-connect/src/network/transport/index.ts

@@ -51,7 +51,7 @@ export interface DataConnectTransport {
     queryName: string,
     body?: U
   ): Promise<{ data: T; errors: Error[] }>;
-  useEmulator(host: string, sslEnabled?: boolean): void;
+  useEmulator(host: string, port: number, sslEnabled?: boolean): void;
   onTokenChanged: (token: string | null) => void;
   _setCallerSdkType(callerSdkType: CallerSdkType): void;
 }

packages/data-connect/src/network/transport/rest.ts

@@ -27,6 +27,7 @@ import { CallerSdkType, CallerSdkTypeEnum, DataConnectTransport } from '.';
 
 export class RESTTransport implements DataConnectTransport {
   private _host = '';
+  private _port: number | undefined;
   private _location = 'l';
   private _connectorName = '';
   private _secure = true;
@@ -46,6 +47,9 @@ export class RESTTransport implements DataConnectTransport {
     private _callerSdkType: CallerSdkType = CallerSdkTypeEnum.Base
   ) {
     if (transportOptions) {
+      if (typeof transportOptions.port === 'number') {
+        this._port = transportOptions.port;
+      }
       if (typeof transportOptions.sslEnabled !== 'undefined') {
         this._secure = transportOptions.sslEnabled;
       }
@@ -84,11 +88,14 @@ export class RESTTransport implements DataConnectTransport {
         projectId: this._project,
         service: this._serviceName
       },
-      { host: this._host, sslEnabled: this._secure }
+      { host: this._host, sslEnabled: this._secure, port: this._port }
     );
   }
-  useEmulator(host: string, isSecure?: boolean): void {
+  useEmulator(host: string, port?: number, isSecure?: boolean): void {
     this._host = host;
+    if (typeof port === 'number') {
+      this._port = port;
+    }
     if (typeof isSecure !== 'undefined') {
       this._secure = isSecure;
     }

packages/data-connect/test/unit/dataconnect.test.ts

@@ -82,4 +82,3 @@ describe('Data Connect Test', () => {
     expect(parsedHost.sslEnabled).to.be.false;
   });
 });
-