Skip to content

Commit d3792b5

Browse files
committed
First.
1 parent 604133f commit d3792b5

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

packages/auth/src/api/index.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,9 @@ export async function _performSignInRequest<T, V extends IdTokenResponse>(
241241
request?: T,
242242
customErrorMap: Partial<ServerErrorMap<ServerError>> = {}
243243
): Promise<V> {
244+
// TODO(jamedaniels) if auth persistence is cookie, proxy through the server endpoint
245+
// Q, do we want to allow signIn/Out to work normally on the server if cookie
246+
// persistence is set and FirebaseServerApp authIdToken is not?
244247
const serverResponse = await _performApiRequest<T, V | IdTokenMfaResponse>(
245248
auth,
246249
method,

packages/auth/src/core/user/user_credential_impl.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ export class UserCredentialImpl
4444
this.operationType = params.operationType;
4545
}
4646

47+
// TODO(jamesdaniels) fetch the user credential from the cookie and response returned from the
48+
// proxy endpoint
4749
static async _fromIdTokenResponse(
4850
auth: AuthInternal,
4951
operationType: OperationType,

packages/auth/src/model/user.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ export interface UserInternal extends User {
6262

6363
auth: AuthInternal;
6464
providerId: ProviderId.FIREBASE;
65+
// TODO(jamesdaniels): refreshToken should either be optional or a sentinel value for COOKIE
66+
// persistence, if refresh token has an identifier maybe that?
6567
refreshToken: string;
6668
emailVerified: boolean;
6769
tenantId: string | null;

0 commit comments

Comments
 (0)