Minor fixes

Author: Samruddhi90

packages/remote-config/test/api.test.ts

@@ -49,6 +49,12 @@ const fakeFirebaseConfig = {
   appId: '1:111:web:a1234'
 };
 
+const mockObserver = {
+  next: sinon.stub(),
+  error: sinon.stub(),
+  complete: sinon.stub()
+};
+
 async function clearDatabase(): Promise<void> {
   const db = await openDatabase();
   db.transaction([APP_NAMESPACE_STORE], 'readwrite')
@@ -184,48 +190,25 @@ describe('Remote Config API', () => {
     });
 
     it('should call addObserver on the internal realtimeHandler', async () => {
-      const mockObserver = {
-        next: sinon.stub(),
-        error: sinon.stub(),
-        complete: sinon.stub()
-      };
       await onConfigUpdate(rc, mockObserver);
-
       expect(addObserverStub).to.have.been.calledOnce;
       expect(addObserverStub).to.have.been.calledWith(mockObserver);
     });
 
     it('should return an unsubscribe function', async () => {
-      const mockObserver = {
-        next: sinon.stub(),
-        error: sinon.stub(),
-        complete: sinon.stub()
-      };
       const unsubscribe = await onConfigUpdate(rc, mockObserver);
-
       expect(unsubscribe).to.be.a('function');
     });
 
     it('returned unsubscribe function should call removeObserver', async () => {
-      const mockObserver = {
-        next: sinon.stub(),
-        error: sinon.stub(),
-        complete: sinon.stub()
-      };
       const unsubscribe = await onConfigUpdate(rc, mockObserver);
 
       unsubscribe();
-
       expect(removeObserverStub).to.have.been.calledOnce;
       expect(removeObserverStub).to.have.been.calledWith(mockObserver);
     });
 
     it('observer.next should be called when realtimeHandler propagates an update', async () => {
-      const mockObserver = {
-        next: sinon.stub(),
-        error: sinon.stub(),
-        complete: sinon.stub()
-      };
       await onConfigUpdate(rc, mockObserver);
 
       if (capturedObserver && capturedObserver.next) {
@@ -245,11 +228,6 @@ describe('Remote Config API', () => {
     });
 
     it('observer.error should be called when realtimeHandler propagates an error', async () => {
-      const mockObserver = {
-        next: sinon.stub(),
-        error: sinon.stub(),
-        complete: sinon.stub()
-      };
       await onConfigUpdate(rc, mockObserver);
 
       if (capturedObserver && capturedObserver.error) {
@@ -275,7 +253,7 @@ describe('Remote Config API', () => {
         'customData.originalErrorMessage',
         'Realtime stream error'
       );
-      expect((receivedError as any).code).to.equal('remoteconfig/stream-error'); // Updated to expect the full prefixed code
+      expect((receivedError as any).code).to.equal('remoteconfig/stream-error');
     });
   });
 });

packages/remote-config/test/client/realtime_handler.test.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { expect, use } from 'chai'; // FIX: Import 'use' from Chai.
+import { expect, use } from 'chai';
 import * as sinon from 'sinon';
 import sinonChai from 'sinon-chai';
 import { RealtimeHandler } from '../../src/client/realtime_handler';
@@ -154,9 +154,8 @@ describe('RealtimeHandler', () => {
     });
 
     it('should set retries remaining from storage if available', async () => {
-      sinon.restore(); // Restore to allow new constructor call
       mockStorage.getRealtimeBackoffMetadata.resolves({
-        backoffEndTimeMillis: new Date(FAKE_NOW - 1000), // In the past, so no immediate backoff
+        backoffEndTimeMillis: new Date(FAKE_NOW - 1000), // In the past, so no backoff
         numFailedStreams: 3
       });
 
@@ -175,7 +174,7 @@ describe('RealtimeHandler', () => {
       await clock.runAllAsync();
       expect((realtime as any).httpRetriesRemaining).to.equal(
         ORIGINAL_RETRIES - 3
-      ); // 8 - 3 = 5
+      );
     });
   });
 
@@ -211,6 +210,7 @@ describe('RealtimeHandler', () => {
     });
 
     it('should return false for non-retryable status codes', () => {
+      // This is a sample of non-retryable codes for testing purposes.
       const nonRetryableCodes = [200, 304, 400, 401, 403];
       nonRetryableCodes.forEach(code => {
         expect((realtime as any).isStatusCodeRetryable(code)).to.be.false;
@@ -286,7 +286,8 @@ describe('RealtimeHandler', () => {
       expect(mockLogger.debug).to.have.been.calledWith(
         'Failed to cancel the reader, connection was lost.'
       );
-      expect((realtime as any).reader).to.be.undefined; // Should still clear reader
+      // Should still clear reader
+      expect((realtime as any).reader).to.be.undefined;
     });
 
     it('should handle being called when reader is already undefined', async () => {
@@ -372,7 +373,8 @@ describe('RealtimeHandler', () => {
 
     it('should call makeRealtimeHttpConnection with calculated delay if backoff metadata exists', async () => {
       mockStorage.getRealtimeBackoffMetadata.resolves({
-        backoffEndTimeMillis: new Date(FAKE_NOW + 5000), // 5 seconds in the future
+        // 5 seconds in the future
+        backoffEndTimeMillis: new Date(FAKE_NOW + 5000),
         numFailedStreams: 1
       });
       await (realtime as any).retryHttpConnectionWhenBackoffEnds();