cleanup: remove documentReferenceFactory

Author: MarkDuckworth

packages/firestore/src/api/pipeline.ts

@@ -36,21 +36,18 @@ export class Pipeline<
    * @param db
    * @param userDataReader
    * @param userDataWriter
-   * @param documentReferenceFactory
    * @param stages
    */
   constructor(
     db: Firestore,
     userDataReader: UserDataReader,
     userDataWriter: AbstractUserDataWriter,
-    documentReferenceFactory: (id: DocumentKey) => DocumentReference,
     stages: Stage[]
   ) {
     super(
       db,
       userDataReader,
       userDataWriter,
-      documentReferenceFactory,
       stages
     );
   }
@@ -61,7 +58,6 @@ export class Pipeline<
    * @param db
    * @param userDataReader
    * @param userDataWriter
-   * @param documentReferenceFactory
    * @param stages
    * @param converter
    * @protected
@@ -70,15 +66,13 @@ export class Pipeline<
     db: Firestore,
     userDataReader: UserDataReader,
     userDataWriter: AbstractUserDataWriter,
-    documentReferenceFactory: (id: DocumentKey) => DocumentReference,
     stages: Stage[],
     converter: unknown = {}
   ): Pipeline {
     return new Pipeline(
       db,
       userDataReader,
       userDataWriter,
-      documentReferenceFactory,
       stages
     );
   }
@@ -127,7 +121,7 @@ export class Pipeline<
             new PipelineResult(
               this._userDataWriter,
               element.key?.path
-                ? this._documentReferenceFactory(element.key)
+                ? new DocumentReference(firestore, null, element.key)
                 : undefined,
               element.fields,
               element.executionTime?.toTimestamp(),

packages/firestore/src/api/pipeline_impl.ts

@@ -57,9 +57,6 @@ export function pipeline(
         firestore,
         newUserDataReader(firestore),
         new ExpUserDataWriter(firestore),
-        (key: DocumentKey) => {
-          return new DocumentReference(firestore, null, key);
-        },
         stages);
     });
   } else {

packages/firestore/src/lite-api/pipeline.ts

@@ -69,6 +69,7 @@ import {ensureFirestoreConfigured} from "../api/database";
 import {firestoreClientExecutePipeline} from "../core/firestore_client";
 import {getDatastore} from "./components";
 import {invokeExecutePipeline} from "../remote/datastore";
+import {firestore} from "../../test/util/api_helpers";
 
 interface ReadableUserData {
   _readUserData(dataReader: UserDataReader): void;
@@ -133,7 +134,6 @@ export class Pipeline
    * @param _db
    * @param userDataReader
    * @param _userDataWriter
-   * @param _documentReferenceFactory
    * @param stages
    */
   constructor(
@@ -148,11 +148,6 @@ export class Pipeline
      * @private
      */
     public _userDataWriter: AbstractUserDataWriter,
-    /**
-     * @internal
-     * @private
-     */
-    public _documentReferenceFactory: (id: DocumentKey) => DocumentReference,
     private stages: Stage[]
   ) {}
 
@@ -193,7 +188,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -238,7 +232,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -296,23 +289,20 @@ export class Pipeline
    * @param db
    * @param userDataReader
    * @param userDataWriter
-   * @param documentReferenceFactory
    * @param stages
    * @protected
    */
   protected newPipeline(
     db: Firestore,
     userDataReader: UserDataReader,
     userDataWriter: AbstractUserDataWriter,
-    documentReferenceFactory: (id: DocumentKey) => DocumentReference,
     stages: Stage[],
     converter: unknown = {}
   ): Pipeline {
     return new Pipeline(
       db,
       userDataReader,
       userDataWriter,
-      documentReferenceFactory,
       stages
     );
   }
@@ -356,7 +346,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -388,7 +377,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -425,7 +413,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -469,7 +456,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -581,7 +567,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -607,7 +592,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -668,7 +652,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -705,7 +688,6 @@ export class Pipeline
       this._db,
       this.userDataReader,
       this._userDataWriter,
-      this._documentReferenceFactory,
       copy
     );
   }
@@ -753,7 +735,7 @@ export class Pipeline
             new PipelineResult(
               this._userDataWriter,
               element.key?.path
-                ? this._documentReferenceFactory(element.key)
+                ? new DocumentReference(this._db, null,element.key)
                 : undefined,
               element.fields,
               element.executionTime?.toTimestamp(),

packages/firestore/src/lite-api/pipeline_impl.ts

@@ -75,9 +75,6 @@ export function pipeline(
         db,
         userDataReader,
         userDataWriter,
-        (key: DocumentKey) => {
-          return new DocumentReference(db, null, key);
-        },
         stages);
     });
   } else {