Skip to content

Commit d71baaf

Browse files
committed
add build job dependency
1 parent dc62065 commit d71baaf

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

.github/workflows/test-all.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ jobs:
6666
# Auth and Firestore are built and executed in their own jobs in an attempt to reduce flakiness.
6767
test-the-rest:
6868
name: (bulk) Node.js and Browser (Chrome) Tests
69+
needs: build
6970
runs-on: ubuntu-latest
7071
steps:
7172
# install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo
@@ -110,6 +111,7 @@ jobs:
110111

111112
test-auth:
112113
name: (Auth) Node.js and Browser (Chrome) Tests
114+
needs: build
113115
runs-on: ubuntu-latest
114116
steps:
115117
# install Chrome first, so the correct version of webdriver can be installed by chromedriver
@@ -163,6 +165,7 @@ jobs:
163165

164166
test-firestore:
165167
name: (Firestore) Node.js and Browser (Chrome) Tests
168+
needs: build
166169
runs-on: ubuntu-latest
167170
steps:
168171
# install Chrome so the correct version of webdriver can be installed by chromedriver when setting up the repo
@@ -211,6 +214,7 @@ jobs:
211214
matrix:
212215
persistence: ['memory', 'persistence']
213216
name: Firestore Integration Tests (${{ matrix.persistence }})
217+
needs: build
214218
runs-on: ubuntu-latest
215219
steps:
216220
# install Chrome so the correct version of webdriver can be installed by chromedriver when setting up the repo

.github/workflows/test-changed-auth.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ jobs:
8080

8181
test-chrome:
8282
name: Test Auth on Chrome and Node If Changed
83+
needs: build
8384
runs-on: ubuntu-latest
8485
steps:
8586
- name: Checkout Repo
@@ -109,6 +110,7 @@ jobs:
109110

110111
test-firefox:
111112
name: Test Auth on Firefox If Changed
113+
needs: build
112114
# Whatever version of Firefox comes with 22.04 is causing Firefox
113115
# startup to hang when launched by karma. Need to look further into
114116
# why.
@@ -151,6 +153,7 @@ jobs:
151153

152154
test-webkit:
153155
name: Test Auth on Webkit if Changed
156+
needs: build
154157
runs-on: macos-latest
155158

156159
steps:

.github/workflows/test-changed.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ jobs:
5858

5959
test-chrome:
6060
name: Test Packages With Changed Files in Chrome and Node
61+
needs: build
6162
runs-on: ubuntu-latest
6263

6364
steps:
@@ -92,6 +93,7 @@ jobs:
9293

9394
test-firefox:
9495
name: Test Packages With Changed Files in Firefox
96+
needs: build
9597
# Whatever version of Firefox comes with 22.04 is causing Firefox
9698
# startup to hang when launched by karma. Need to look further into
9799
# why.
@@ -132,6 +134,7 @@ jobs:
132134

133135
test-webkit:
134136
name: Test Packages With Changed Files in Webkit
137+
needs: build
135138
runs-on: macos-latest
136139

137140
steps:

0 commit comments

Comments
 (0)