Merge branch 'main' into dl/optimize-ci

Author: dlarocque

.changeset/fluffy-rules-pretend.md

@@ -0,0 +1,6 @@
+---
+'@firebase/app-check': patch
+'@firebase/util': patch
+---
+
+Generate UUIDs with `crypto.randomUUID()` instead of custom uuidv4 function that uses `Math.random()`.

.changeset/tame-tigers-approve.md

@@ -0,0 +1,6 @@
+---
+"@firebase/data-connect": minor
+"firebase": minor
+---
+
+Updated to include promise instead of promiselike

.github/CODEOWNERS

@@ -37,10 +37,10 @@ packages/messaging-interop-types @zwu52 @firebase/jssdk-global-approvers
 integration/messaging @zwu52 @firebase/jssdk-global-approvers
 
 # Auth Code
-packages/auth @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
-packages/auth-compat @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
-packages/auth-types @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
-packages/auth-interop-types @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
+packages/auth @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
+packages/auth-compat @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
+packages/auth-types @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
+packages/auth-interop-types @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
 
 # Testing Code
 packages/rules-unit-testing  @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers

common/api-review/data-connect.api.md

@@ -11,14 +11,6 @@ import { FirebaseError } from '@firebase/util';
 import { LogLevelString } from '@firebase/logger';
 import { Provider } from '@firebase/component';
 
-// @public (undocumented)
-export interface CancellableOperation<T> extends PromiseLike<{
-    data: T;
-}> {
-    // (undocumented)
-    cancel: () => void;
-}
-
 // @public
 export function connectDataConnectEmulator(dc: DataConnect, host: string, port?: number, sslEnabled?: boolean): void;
 
@@ -88,7 +80,7 @@ export function getDataConnect(app: FirebaseApp, options: ConnectorConfig): Data
 export const MUTATION_STR = "mutation";
 
 // @public
-export interface MutationPromise<Data, Variables> extends PromiseLike<MutationResult<Data, Variables>> {
+export interface MutationPromise<Data, Variables> extends Promise<MutationResult<Data, Variables>> {
 }
 
 // @public (undocumented)
@@ -144,7 +136,7 @@ export interface OpResult<Data> {
 export const QUERY_STR = "query";
 
 // @public
-export interface QueryPromise<Data, Variables> extends PromiseLike<QueryResult<Data, Variables>> {
+export interface QueryPromise<Data, Variables> extends Promise<QueryResult<Data, Variables>> {
 }
 
 // @public

common/api-review/util.api.md

@@ -476,9 +476,6 @@ export interface Subscribe<T> {
 // @public (undocumented)
 export type Unsubscribe = () => void;
 
-// @public
-export const uuidv4: () => string;
-
 // Warning: (ae-missing-release-tag) "validateArgCount" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
 //
 // @public

packages/app-check/src/storage.ts

@@ -16,7 +16,7 @@
  */
 
 import { FirebaseApp } from '@firebase/app';
-import { isIndexedDBAvailable, uuidv4 } from '@firebase/util';
+import { isIndexedDBAvailable } from '@firebase/util';
 import {
   readDebugTokenFromIndexedDB,
   readTokenFromIndexedDB,
@@ -77,7 +77,8 @@ export async function readOrCreateDebugTokenFromStorage(): Promise<string> {
 
   if (!existingDebugToken) {
     // create a new debug token
-    const newToken = uuidv4();
+    // This function is only available in secure contexts. See https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts
+    const newToken = crypto.randomUUID();
     // We don't need to block on writing to indexeddb
     // In case persistence failed, a new debug token will be generated every time the page is refreshed.
     // It renders the debug token useless because you have to manually register(whitelist) the new token in the firebase console again and again.

packages/data-connect/src/api/Mutation.ts

@@ -76,7 +76,7 @@ export function mutationRef<Data, Variables>(
  * @internal
  */
 export class MutationManager {
-  private _inflight: Array<PromiseLike<unknown>> = [];
+  private _inflight: Array<Promise<unknown>> = [];
   constructor(private _transport: DataConnectTransport) {}
   executeMutation<Data, Variables>(
     mutationRef: MutationRef<Data, Variables>
@@ -95,7 +95,7 @@ export class MutationManager {
       return obj;
     });
     this._inflight.push(result);
-    const removePromise = (): Array<PromiseLike<unknown>> =>
+    const removePromise = (): Array<Promise<unknown>> =>
       (this._inflight = this._inflight.filter(promise => promise !== result));
     result.then(removePromise, removePromise);
     return withRefPromise;
@@ -113,7 +113,7 @@ export interface MutationResult<Data, Variables>
  * Mutation return value from `executeMutation`
  */
 export interface MutationPromise<Data, Variables>
-  extends PromiseLike<MutationResult<Data, Variables>> {
+  extends Promise<MutationResult<Data, Variables>> {
   // reserved for special actions like cancellation
 }
 

packages/data-connect/src/api/query.ts

@@ -67,7 +67,7 @@ export interface QueryResult<Data, Variables>
  * Promise returned from `executeQuery`
  */
 export interface QueryPromise<Data, Variables>
-  extends PromiseLike<QueryResult<Data, Variables>> {
+  extends Promise<QueryResult<Data, Variables>> {
   // reserved for special actions like cancellation
 }
 
@@ -124,7 +124,7 @@ export function queryRef<Data, Variables>(
     dataConnect: dcInstance,
     refType: QUERY_STR,
     name: queryName,
-    variables: variables as Variables
+    variables: variables
   };
 }
 /**

packages/data-connect/src/network/fetch.ts

@@ -30,9 +30,14 @@ function getGoogApiClientValue(_isUsingGen: boolean): string {
   }
   return str;
 }
+export interface DataConnectFetchBody<T> {
+  name: string;
+  operationName: string;
+  variables: T;
+}
 export function dcFetch<T, U>(
   url: string,
-  body: U,
+  body: DataConnectFetchBody<U>,
   { signal }: AbortController,
   appId: string | null,
   accessToken: string | null,
@@ -95,7 +100,7 @@ export function dcFetch<T, U>(
         logError('DataConnect error while performing request: ' + stringified);
         throw new DataConnectError(Code.OTHER, stringified);
       }
-      return res as { data: T; errors: Error[] };
+      return res;
     });
 }
 interface MessageObject {

packages/data-connect/src/network/transport/index.ts

@@ -26,19 +26,15 @@ export interface DataConnectTransport {
   invokeQuery<T, U>(
     queryName: string,
     body?: U
-  ): PromiseLike<{ data: T; errors: Error[] }>;
+  ): Promise<{ data: T; errors: Error[] }>;
   invokeMutation<T, U>(
     queryName: string,
     body?: U
-  ): PromiseLike<{ data: T; errors: Error[] }>;
+  ): Promise<{ data: T; errors: Error[] }>;
   useEmulator(host: string, port?: number, sslEnabled?: boolean): void;
   onTokenChanged: (token: string | null) => void;
 }
 
-export interface CancellableOperation<T> extends PromiseLike<{ data: T }> {
-  cancel: () => void;
-}
-
 /**
  * @internal
  */