Fixed tests

Author: maneesht

packages/data-connect/package.json

@@ -35,7 +35,7 @@
     "dev": "rollup -c -w",
     "test": "run-p --npm-path npm test:emulator",
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:emulator",
-    "test:all": "npm run test:node",
+    "test:all": "npm run test:unit",
     "test:browser": "karma start --single-run",
     "test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",
     "test:unit": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/unit/**/*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",
@@ -57,7 +57,7 @@
     "tslib": "^2.1.0"
   },
   "devDependencies": {
-    "@firebase/app": "0.10.7",
+    "@firebase/app": "0.10.10",
     "rollup": "2.79.1",
     "rollup-plugin-typescript2": "0.31.2",
     "typescript": "4.7.4"

packages/data-connect/src/index.ts

@@ -22,7 +22,6 @@
  */
 import { DataConnect } from './api/DataConnect';
 import { registerDataConnect } from './register';
-// import CryptoJS from 'crypto-js/hmac-sha512';
 
 export * from './api';
 export * from './api.browser';

packages/data-connect/src/network/transport/rest.ts

@@ -73,7 +73,6 @@ export class RESTTransport implements DataConnectTransport {
       this._accessToken = token;
     });
     this.appCheckProvider?.addTokenChangeListener(result => {
-      console.log('getting token');
       const { token } = result;
       logDebug(`New App Check Token Available: ${token}`);
       this._appCheckToken = token;
@@ -108,7 +107,7 @@ export class RESTTransport implements DataConnectTransport {
       resolve(this._accessToken)
     );
     if (this.appCheckProvider) {
-      this._appCheckToken = (await this.appCheckProvider.getToken()).token;
+      this._appCheckToken = (await this.appCheckProvider.getToken())?.token;
     }
     if (this.authProvider) {
       starterPromise = this.authProvider

packages/data-connect/test/unit/userAgent.test.ts

@@ -22,6 +22,7 @@ import sinonChai from 'sinon-chai';
 import { DataConnect, executeQuery, getDataConnect, queryRef } from '../../src';
 import { SDK_VERSION } from '../../src/core/version';
 import { initializeFetch } from '../../src/network/fetch';
+import { deleteApp, initializeApp, FirebaseApp } from '@firebase/app';
 
 use(sinonChai);
 const json = {
@@ -38,12 +39,15 @@ const fakeFetchImpl = sinon.stub().returns(
 
 describe('User Agent Tests', () => {
   let dc: DataConnect;
+  let app: FirebaseApp;
   beforeEach(() => {
     initializeFetch(fakeFetchImpl);
-    dc = getDataConnect({ connector: 'c', location: 'l', service: 's' });
+    app = initializeApp({projectId: 'p'}, 'abc'); // TODO(mtewani): Replace with util function
+    dc = getDataConnect(app, { connector: 'c', location: 'l', service: 's' });
   });
   afterEach(async () => {
     await dc._delete();
+    await deleteApp(app);
   });
   it('should send a request with the corresponding user agent if using the generated SDK', async () => {
     dc._useGeneratedSdk();
@@ -58,7 +62,7 @@ describe('User Agent Tests', () => {
       }
     );
   });
-  it('should send a request with the corresponding user agent if using the generated SDK', async () => {
+  it('should send a request with the corresponding user agent if not using the generated SDK', async () => {
     // @ts-ignore
     await executeQuery(queryRef(dc, '')).catch(() => {});
     expect(fakeFetchImpl).to.be.calledWithMatch(

yarn.lock

@@ -1639,17 +1639,6 @@
   resolved "https://registry.npmjs.org/@eslint/js/-/js-8.56.0.tgz#ef20350fec605a7f7035a01764731b2de0f3782b"
   integrity sha512-gMsVel9D7f2HLkBma9VbtzZRehRogVRfbr++f06nL2vnCGCNlzOD+/MUov/F4p8myyAHspEhVobgjpX64q5m6A==
 
-"@firebase/[email protected]":
-  version "0.10.7"
-  resolved "https://registry.npmjs.org/@firebase/app/-/app-0.10.7.tgz#31cba1486c21b5a0cadc0036bfc0cec68ff53c8e"
-  integrity sha512-7OCd53B+wnk/onbMLn/vM10pDjw97zzWUD8m3swtLYKJIrL+gDZ7HZ4xcbBLw7OB8ikzu8k1ORNjRe2itgAy4g==
-  dependencies:
-    "@firebase/component" "0.6.8"
-    "@firebase/logger" "0.4.2"
-    "@firebase/util" "1.9.7"
-    idb "7.1.1"
-    tslib "^2.1.0"
-
 "@gar/promisify@^1.0.1":
   version "1.1.2"
   resolved "https://registry.npmjs.org/@gar/promisify/-/promisify-1.1.2.tgz"