Add timestamp functions support

Author: wu-hui

packages/firestore/src/api/pipeline_impl.ts

@@ -16,24 +16,26 @@
  */
 
 import { Pipeline } from '../api/pipeline';
-import { firestoreClientExecutePipeline } from '../core/firestore_client';
+import {
+  firestoreClientExecutePipeline,
+  firestoreClientListen
+} from '../core/firestore_client';
+import { toCorePipeline } from '../core/pipeline-util';
+import { ViewSnapshot } from '../core/view_snapshot';
 import { Pipeline as LitePipeline } from '../lite-api/pipeline';
 import { PipelineResult, PipelineSnapshot } from '../lite-api/pipeline-result';
 import { PipelineSource } from '../lite-api/pipeline-source';
-import { Sort, Stage } from '../lite-api/stage';
+import { Stage } from '../lite-api/stage';
 import { newUserDataReader } from '../lite-api/user_data_reader';
+import { FirestoreError } from '../util/error';
 import { cast } from '../util/input_validation';
 
 import { ensureFirestoreConfigured, Firestore } from './database';
+import { RealtimePipeline } from './realtime_pipeline';
 import { DocumentReference } from './reference';
-import { ExpUserDataWriter } from './user_data_writer';
-import { RealtimePipelineSnapshot } from './snapshot';
-import { FirestoreError } from '../util/error';
 import { Unsubscribe } from './reference_impl';
-import { firestoreClientListen } from '../core/firestore_client';
-import { ViewSnapshot } from '../core/view_snapshot';
-import { toCorePipeline } from '../core/pipeline-util';
-import { RealtimePipeline } from './realtime_pipeline';
+import { RealtimePipelineSnapshot } from './snapshot';
+import { ExpUserDataWriter } from './user_data_writer';
 
 declare module './database' {
   interface Firestore {
@@ -149,8 +151,8 @@ export function _onRealtimePipelineSnapshot(
     next: (snapshot: ViewSnapshot) => {
       next(new RealtimePipelineSnapshot(pipeline, snapshot));
     },
-    error: error,
-    complete: complete
+    error,
+    complete
   };
   // TODO(pipeline) hook up options
   return firestoreClientListen(client, toCorePipeline(pipeline), {}, observer);

packages/firestore/src/api/realtime_pipeline.ts

@@ -1,26 +1,14 @@
-import {
-  getEncodedDatabaseId,
-  JsonProtoSerializer,
-  ProtoSerializable
-} from '../remote/serializer';
-import {
-  ExecutePipelineRequest,
-  Stage as ProtoStage,
-  StructuredPipeline
-} from '../protos/firestore_proto_api';
 import { Firestore } from '../lite-api/database';
+import { BooleanExpr, Ordering } from '../lite-api/expressions';
+import { isReadableUserData, ReadableUserData } from '../lite-api/pipeline';
+import { Limit, Sort, Stage, Where } from '../lite-api/stage';
 import { UserDataReader } from '../lite-api/user_data_reader';
 import { AbstractUserDataWriter } from '../lite-api/user_data_writer';
-import { Limit, Sort, Stage, Where } from '../lite-api/stage';
 import {
-  Expr,
-  ExprWithAlias,
-  Field,
-  BooleanExpr,
-  Ordering,
-  Selectable
-} from '../lite-api/expressions';
-import { isReadableUserData, ReadableUserData } from '../lite-api/pipeline';
+  Stage as ProtoStage,
+  StructuredPipeline
+} from '../protos/firestore_proto_api';
+import { JsonProtoSerializer } from '../remote/serializer';
 
 /**
  * Base-class implementation

packages/firestore/src/api/reference_impl.ts

@@ -34,7 +34,8 @@ import {
   firestoreClientListen,
   firestoreClientWrite
 } from '../core/firestore_client';
-import { newQueryForPath, Query as InternalQuery } from '../core/query';
+import { QueryOrPipeline, toCorePipeline } from '../core/pipeline-util';
+import { newQueryForPath } from '../core/query';
 import { ViewSnapshot } from '../core/view_snapshot';
 import { FieldPath } from '../lite-api/field_path';
 import { validateHasExplicitOrderByForLimitToLast } from '../lite-api/query';
@@ -63,15 +64,14 @@ import { FirestoreError } from '../util/error';
 import { cast } from '../util/input_validation';
 
 import { ensureFirestoreConfigured, Firestore } from './database';
+import { RealtimePipeline } from './realtime_pipeline';
 import {
   DocumentSnapshot,
   QuerySnapshot,
   RealtimePipelineSnapshot,
   SnapshotMetadata
 } from './snapshot';
 import { ExpUserDataWriter } from './user_data_writer';
-import { RealtimePipeline } from './realtime_pipeline';
-import { QueryOrPipeline, toCorePipeline } from '../core/pipeline-util';
 
 /**
  * An options object that can be passed to {@link (onSnapshot:1)} and {@link

packages/firestore/src/api/snapshot.ts

@@ -15,9 +15,12 @@
  * limitations under the License.
  */
 
+import { isPipeline } from '../core/pipeline-util';
+import { CorePipeline, newPipelineComparator } from '../core/pipeline_run';
 import { newQueryComparator } from '../core/query';
 import { ChangeType, ViewSnapshot } from '../core/view_snapshot';
 import { FieldPath } from '../lite-api/field_path';
+import { PipelineResult, toPipelineResult } from '../lite-api/pipeline-result';
 import {
   DocumentData,
   DocumentReference,
@@ -40,12 +43,8 @@ import { debugAssert, fail } from '../util/assert';
 import { Code, FirestoreError } from '../util/error';
 
 import { Firestore } from './database';
-import { SnapshotListenOptions } from './reference_impl';
-import { Pipeline } from '../lite-api/pipeline';
-import { PipelineResult, toPipelineResult } from '../lite-api/pipeline-result';
-import { isPipeline, toCorePipeline } from '../core/pipeline-util';
-import { CorePipeline, newPipelineComparator } from '../core/pipeline_run';
 import { RealtimePipeline } from './realtime_pipeline';
+import { SnapshotListenOptions } from './reference_impl';
 
 /**
  * Converter used by `withConverter()` to transform user objects of type
@@ -822,7 +821,7 @@ export interface ResultChange {
 export function resultChangesFromSnapshot(
   querySnapshot: RealtimePipelineSnapshot,
   includeMetadataChanges: boolean
-): Array<ResultChange> {
+): ResultChange[] {
   if (querySnapshot._snapshot.oldDocs.isEmpty()) {
     // Special case the first snapshot because index calculation is easy and
     // fast
@@ -913,7 +912,7 @@ export class RealtimePipelineSnapshot {
    */
   readonly metadata: SnapshotMetadata;
 
-  private _cachedChanges?: Array<ResultChange>;
+  private _cachedChanges?: ResultChange[];
   private _cachedChangesIncludeMetadataChanges?: boolean;
 
   /** @hideconstructor */
@@ -926,8 +925,8 @@ export class RealtimePipelineSnapshot {
   }
 
   /** An array of all the documents in the `QuerySnapshot`. */
-  get results(): Array<PipelineResult> {
-    const result: Array<PipelineResult> = [];
+  get results(): PipelineResult[] {
+    const result: PipelineResult[] = [];
     this._snapshot.docs.forEach(doc =>
       result.push(toPipelineResult(doc, this.pipeline))
     );
@@ -938,7 +937,7 @@ export class RealtimePipelineSnapshot {
     return this._snapshot.docs.size;
   }
 
-  resultChanges(options: SnapshotListenOptions = {}): Array<ResultChange> {
+  resultChanges(options: SnapshotListenOptions = {}): ResultChange[] {
     const includeMetadataChanges = !!options.includeMetadataChanges;
 
     if (includeMetadataChanges && this._snapshot.excludesMetadataChanges) {

packages/firestore/src/core/event_manager.ts

@@ -21,16 +21,16 @@ import { Code, FirestoreError } from '../util/error';
 import { EventHandler } from '../util/misc';
 import { ObjectMap } from '../util/obj_map';
 
-import { Query, stringifyQuery } from './query';
-import { OnlineState } from './types';
-import { ChangeType, DocumentViewChange, ViewSnapshot } from './view_snapshot';
 import {
   canonifyPipeline,
   canonifyQueryOrPipeline,
   isPipeline,
   QueryOrPipeline,
   queryOrPipelineEqual
 } from './pipeline-util';
+import { Query, stringifyQuery } from './query';
+import { OnlineState } from './types';
+import { ChangeType, DocumentViewChange, ViewSnapshot } from './view_snapshot';
 
 /**
  * Holds the listeners and the last received ViewSnapshot for a query being