From c20267b68d6fc4a7516626293d36dde042a493c2 Mon Sep 17 00:00:00 2001 From: Alexander <74536256+alexander-at-t@users.noreply.github.com> Date: Thu, 23 Jan 2025 16:04:01 +0200 Subject: [PATCH 1/3] Fix negative offset of reconnect delay (#8718) --- packages/database/src/core/PersistentConnection.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/database/src/core/PersistentConnection.ts b/packages/database/src/core/PersistentConnection.ts index 4e12b37088b..4070c4fea98 100644 --- a/packages/database/src/core/PersistentConnection.ts +++ b/packages/database/src/core/PersistentConnection.ts @@ -797,8 +797,10 @@ export class PersistentConnection extends ServerActions { this.lastConnectionEstablishedTime_ = null; } - const timeSinceLastConnectAttempt = - new Date().getTime() - this.lastConnectionAttemptTime_; + const timeSinceLastConnectAttempt = Math.max( + 0, + new Date().getTime() - this.lastConnectionAttemptTime_ + ); let reconnectDelay = Math.max( 0, this.reconnectDelay_ - timeSinceLastConnectAttempt From c03dfa0ba7caefdf40c69129d5de76404d5876fe Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Mon, 27 Jan 2025 10:35:52 -0500 Subject: [PATCH 2/3] Create Changset --- .changeset/chilled-clocks-remember.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/chilled-clocks-remember.md diff --git a/.changeset/chilled-clocks-remember.md b/.changeset/chilled-clocks-remember.md new file mode 100644 index 00000000000..a76214a2f56 --- /dev/null +++ b/.changeset/chilled-clocks-remember.md @@ -0,0 +1,5 @@ +--- +"@firebase/database": patch +--- + +Fix a potential for a negative offset when calculating last reconnect times. This could cause lengthy reconnect delays in some scenarios. Fixes #8718. From c06bdd7dee1cca464b7add27e3b173fa5a9806eb Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Tue, 28 Jan 2025 14:58:09 -0500 Subject: [PATCH 3/3] added 'firebase' to changeset --- .changeset/chilled-clocks-remember.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.changeset/chilled-clocks-remember.md b/.changeset/chilled-clocks-remember.md index a76214a2f56..cbc0ec71a1f 100644 --- a/.changeset/chilled-clocks-remember.md +++ b/.changeset/chilled-clocks-remember.md @@ -1,5 +1,6 @@ --- "@firebase/database": patch +'firebase': patch --- Fix a potential for a negative offset when calculating last reconnect times. This could cause lengthy reconnect delays in some scenarios. Fixes #8718.