Skip to content

Commit 01936f7

Browse files
authored
Use unordered comparison for firebase.json in test:frameworks (#6809)
* use unordered comparison for firebase.json in tests * prettier
1 parent 9b0a71d commit 01936f7

File tree

3 files changed

+67
-2
lines changed

3 files changed

+67
-2
lines changed

npm-shrinkwrap.json

Lines changed: 58 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@
110110
"cross-env": "^5.1.3",
111111
"cross-spawn": "^7.0.3",
112112
"csv-parse": "^5.0.4",
113+
"deep-equal-in-any-order": "^2.0.6",
113114
"exegesis": "^4.1.0",
114115
"exegesis-express": "^4.0.0",
115116
"express": "^4.16.4",
@@ -170,6 +171,7 @@
170171
"@types/configstore": "^4.0.0",
171172
"@types/cors": "^2.8.10",
172173
"@types/cross-spawn": "^6.0.1",
174+
"@types/deep-equal-in-any-order": "^1.0.3",
173175
"@types/express": "^4.17.0",
174176
"@types/express-serve-static-core": "^4.17.8",
175177
"@types/fs-extra": "^9.0.13",

scripts/webframeworks-deploy-tests/tests.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1-
import { expect } from "chai";
1+
import { expect, use } from "chai";
22
import * as glob from "glob";
33
import { join, normalize, relative } from "path";
44
import { readFileSync } from "fs";
55
import fetch from "node-fetch";
66
import type { NextConfig } from "next";
7+
import * as deepEqualUnordered from "deep-equal-in-any-order";
8+
use(deepEqualUnordered);
79

810
import { getBuildId } from "../../src/frameworks/next/utils";
911
import { fileExistsSync } from "../../src/fsutils";
@@ -57,7 +59,10 @@ describe("webframeworks", function (this) {
5759
.at(-1)
5860
?.split(new RegExp(`(\\[\\S+\\] )?\\[${new Date().getFullYear()}`))[0]
5961
?.trim();
60-
expect(effectiveFirebaseJSON && JSON.parse(effectiveFirebaseJSON), "firebase.json").to.eql({
62+
expect(
63+
effectiveFirebaseJSON && JSON.parse(effectiveFirebaseJSON),
64+
"firebase.json",
65+
).to.deep.equalInAnyOrder({
6166
hosting: [
6267
{
6368
target: "nextjs",

0 commit comments

Comments
 (0)