Skip to content

Commit 0c00909

Browse files
authored
[FDC] firebase init dataconnect:sdk don't need confirmation to update connector.yaml (#8947)
1 parent f73defc commit 0c00909

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

src/init/features/dataconnect/sdk.spec.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,11 @@ describe("init dataconnect:sdk", () => {
1818
let generateStub: sinon.SinonStub;
1919
let fsStub: sinon.SinonStub;
2020
let emptyConfig: Config;
21-
let askProjectWriteFileStub: sinon.SinonStub;
2221

2322
beforeEach(() => {
2423
fsStub = sandbox.stub(fs, "writeFileSync");
2524
generateStub = sandbox.stub(DataConnectEmulator, "generate");
2625
emptyConfig = new Config({}, { projectDir: process.cwd() });
27-
askProjectWriteFileStub = sandbox.stub(emptyConfig, "askWriteProjectFile");
2826
});
2927

3028
afterEach(() => {
@@ -50,9 +48,6 @@ describe("init dataconnect:sdk", () => {
5048

5149
await sdk.actuate(c.sdkInfo, emptyConfig);
5250
expect(generateStub.called).to.equal(c.shouldGenerate);
53-
expect(askProjectWriteFileStub.args).to.deep.equal([
54-
["dataconnect/connector/connector.yaml", CONNECTOR_YAML_CONTENTS, false, true],
55-
]);
5651
});
5752
}
5853
});

src/init/features/dataconnect/sdk.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,11 +249,9 @@ export async function generateSdkYaml(
249249
export async function actuate(sdkInfo: SDKInfo, config: Config) {
250250
const connectorYamlPath = `${sdkInfo.connectorInfo.directory}/connector.yaml`;
251251
logBullet(`Writing your new SDK configuration to ${connectorYamlPath}`);
252-
await config.askWriteProjectFile(
252+
config.writeProjectFile(
253253
path.relative(config.projectDir, connectorYamlPath),
254254
sdkInfo.connectorYamlContents,
255-
/* force=*/ false,
256-
/* confirmByDefault=*/ true,
257255
);
258256

259257
const account = getGlobalDefaultAccount();

0 commit comments

Comments
 (0)