Fixed an issue where the FDC emulator did not have ADC provided (#8820)

* Fixed an issue where the FDC emulator did not have ADC provided

* PR suggestion

* Format

Author: joehan

CHANGELOG.md

@@ -1,2 +1,3 @@
 - Improve App Hosting compute service account flow for source deploys. (#8785)
 - Fixed an issue with `ext:configure` where params without default values could not be set. (#8810)
+- Fixed an issue where the Data Connect emulator wasn't provided application default credentials. (#8819)

src/emulator/controller.ts

@@ -560,6 +560,8 @@ export async function startAll(
     await startEmulator(extensionEmulator);
   }
 
+  const account = getProjectDefaultAccount(options.projectRoot);
+
   if (emulatableBackends.length) {
     if (!listenForEmulator.functions || !listenForEmulator.eventarc || !listenForEmulator.tasks) {
       // We did not know that we need Functions and Eventarc earlier but now we do.
@@ -601,8 +603,6 @@ export async function startAll(
       );
     }
 
-    const account = getProjectDefaultAccount(options.projectRoot);
-
     // TODO(b/213241033): Figure out how to watch for changes to extensions .env files & reload triggers when they change.
     const functionsEmulator = new FunctionsEmulator({
       projectId,
@@ -887,6 +887,7 @@ export async function startAll(
       enable_output_generated_sdk: true, // TODO: source from arguments
       enable_output_schema_extensions: true,
       debug: options.debug,
+      account,
     };
 
     if (exportMetadata.dataconnect) {

src/emulator/dataconnectEmulator.ts

@@ -363,7 +363,6 @@ export class DataConnectEmulator implements EmulatorInstance {
       // If Firebase CLI is logged in, always pass in the credentials to FDC emulator.
       const defaultCredPath = await getCredentialPathAsync(account);
       if (defaultCredPath) {
-        logger.log("DEBUG", `Setting GAC to ${defaultCredPath}`);
         credsEnv.GOOGLE_APPLICATION_CREDENTIALS = defaultCredPath;
       }
     }