Merge branch 'master' into lazy-load-commands

Author: joehan

src/commands/functions-list.ts

@@ -1,31 +1,48 @@
 import { Command } from "../command";
 import * as args from "../deploy/functions/args";
 import { needProjectId } from "../projectUtils";
-import { Options } from "../options";
 import { requirePermissions } from "../requirePermissions";
 import * as backend from "../deploy/functions/backend";
 import { logger } from "../logger";
 import * as Table from "cli-table3";
+import { Options } from "../options";
+import { FunctionsPlatform } from "../deploy/functions/backend";
+
+type PLATFORM_DISPLAY_NAME = "v1" | "v2" | "run";
+const PLATFORM_TO_DISPLAY_NAME: Record<FunctionsPlatform, PLATFORM_DISPLAY_NAME> = {
+  gcfv1: "v1",
+  gcfv2: "v2",
+  run: "run",
+};
 
 export const command = new Command("functions:list")
   .description("list all deployed functions in your Firebase project")
-  .before(requirePermissions, ["cloudfunctions.functions.list"])
+  .before(requirePermissions, ["cloudfunctions.functions.list", "run.services.list"])
   .action(async (options: Options) => {
+    const projectId = needProjectId(options);
     const context = {
-      projectId: needProjectId(options),
+      projectId,
     } as args.Context;
+
     const existing = await backend.existingBackend(context);
-    const endpointsList = backend.allEndpoints(existing).sort(backend.compareFunctions);
+    const endpoints = backend.allEndpoints(existing).sort(backend.compareFunctions);
+
+    if (endpoints.length === 0) {
+      logger.info(`No functions found in project ${projectId}.`);
+      return [];
+    }
+
     const table = new Table({
       head: ["Function", "Version", "Trigger", "Location", "Memory", "Runtime"],
       style: { head: ["yellow"] },
     });
-    for (const endpoint of endpointsList) {
+
+    for (const endpoint of endpoints) {
       const trigger = backend.endpointTriggerType(endpoint);
       const availableMemoryMb = endpoint.availableMemoryMb || "---";
       const entry = [
         endpoint.id,
-        endpoint.platform === "gcfv2" ? "v2" : "v1",
+        PLATFORM_TO_DISPLAY_NAME[endpoint.platform] || "v1",
         trigger,
         endpoint.region,
         availableMemoryMb,
@@ -34,5 +51,5 @@ export const command = new Command("functions:list")
       table.push(entry);
     }
     logger.info(table.toString());
-    return endpointsList;
+    return endpoints;
   });