Skip to content

Commit 23c3e5f

Browse files
authored
Fix ext:configure not settings params without a default (#8814)
1 parent 740da34 commit 23c3e5f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
- Improve App Hosting compute service account flow for source deploys. (#8785)
2+
- Fixed an issue with `ext:configure` where params without default values could not be set. (#8810)

src/extensions/paramHelper.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ export function setNewDefaults(params: Param[], newDefaults: { [key: string]: st
6464
if (newDefaults[param.param]) {
6565
param.default = newDefaults[param.param];
6666
} else if (
67-
(param.param = `firebaseextensions.v1beta.function/location` && newDefaults["LOCATION"])
67+
param.param === `firebaseextensions.v1beta.function/location` &&
68+
newDefaults["LOCATION"]
6869
) {
6970
// Special case handling for when we are updating from LOCATION to system param location.
7071
param.default = newDefaults["LOCATION"];

0 commit comments

Comments
 (0)